monnier@iro.umontreal.ca (Stefan Monnier) writes: > branch: master > commit 1559cc445a306b61b2a47c710e049ea26fe5265d > Author: Stefan Monnier > Commit: Stefan Monnier > > Fix missing file&line info in "Unknown defun property" warnings > > * lisp/emacs-lisp/byte-run.el (defmacro, defun): Use > `macroexp--warn-and-return` rather than `message`. > > * lisp/emacs-lisp/macroexp.el: Fix `macroexp--compiling-p`. > (macroexp--warn-and-return): Don't try and detect repetition on forms > like `nil`. > (macroexp-macroexpand): Don't forget to bind `macroexpand-all-environment`. This gave rise to the following 'make check' failures: --8<---------------cut here---------------start------------->8--- Test cl-lib-defstruct-record passed unexpectedly Ran 47 tests, 46 results as expected, 1 unexpected (2021-01-23 22:05:59+0000, 0.052134 sec) 1 expected failures 1 unexpected results: PASSED cl-lib-defstruct-record lisp/emacs-lisp/seq-tests.el:416:41: Error: ‘add-to-list’ can’t use lexical var ‘elts’; use ‘push’ or ‘cl-pushnew’ In toplevel form: lisp/autorevert-tests.el:642:24: Error: ‘add-to-list’ can’t use lexical var ‘buffers’; use ‘push’ or ‘cl-pushnew’ lisp/autorevert-tests.el:657:15: Error: ‘add-to-list’ can’t use lexical var ‘buffers’; use ‘push’ or ‘cl-pushnew’ --8<---------------cut here---------------end--------------->8--- Are the attached changes TRT, or is there something subtle going on? Thanks, -- Basil