bug#46509: 28.0.50; Unused static function in xfns.c with GTK2

["Basil L. Contovounesios" <contovob@tcd.ie>]

Severity: minor

Building --with-x-toolkit=gtk2 gives the following warning:

  xfns.c:4947:1: warning: ‘x_get_monitor_attributes’ defined but not used

Its definition is conditional on !USE_GTK || !HAVE_GTK3, but its use
only on !USE_GTK.  Which one is right?  Or is this too inconsequential
to bother changing anything?

Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0)
 of 2021-02-14 built on tia
Repository revision: 103039b06c2c9a917fc796d2a4afda8433e37473
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux bullseye/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --program-suffix=-gtk2
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=gtk2 --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE
XIM XPM GTK2 ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix