* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-02-27 14:35 ` master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding Lars Ingebrigtsen
@ 2021-02-27 14:41 ` Lars Ingebrigtsen
2021-02-27 15:57 ` Stefan Monnier
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-02-27 14:41 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Ran 4741 tests, 4661 results as expected, 1 unexpected, 79 skipped
> 1 files contained unexpected results:
> lisp/calendar/time-date-tests.log
This comes from:
Test test-obsolete-encode-time-value condition:
(void-function internal--with-suppressed-warnings)
And, indeed, this gives a backtrace:
(should (equal (with-suppressed-warnings ((obsolete encode-time-value))
(encode-time-value 1 2 3 4 0))
'(1 . 2)))
Eval-ing just the thing inside the `should' works, though.
So something has happened to macro expansion over the past day or so, I
think?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-02-27 14:35 ` master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding Lars Ingebrigtsen
2021-02-27 14:41 ` Lars Ingebrigtsen
@ 2021-02-27 15:57 ` Stefan Monnier
2021-02-28 13:27 ` Lars Ingebrigtsen
2021-02-27 18:37 ` Basil L. Contovounesios
2021-02-27 20:36 ` Stefan Monnier
3 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-02-27 15:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
> I'm not at all sure what's going wrong in the tests today, but perhaps
> it's related to this change?
Do you say that because of the "bad" in "49bad2a"?
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-02-27 14:35 ` master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding Lars Ingebrigtsen
2021-02-27 14:41 ` Lars Ingebrigtsen
2021-02-27 15:57 ` Stefan Monnier
@ 2021-02-27 18:37 ` Basil L. Contovounesios
2021-02-27 20:36 ` Stefan Monnier
3 siblings, 0 replies; 9+ messages in thread
From: Basil L. Contovounesios @ 2021-02-27 18:37 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Stefan Monnier, emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I'm not at all sure what's going wrong in the tests today, but perhaps
> it's related to this change?
Doesn't bug#46818 seem a likelier culprit at first glance?
[...]
> So something has happened to macro expansion over the past day or so, I
> think?
--
Basil
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-02-27 14:35 ` master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding Lars Ingebrigtsen
` (2 preceding siblings ...)
2021-02-27 18:37 ` Basil L. Contovounesios
@ 2021-02-27 20:36 ` Stefan Monnier
2021-02-28 13:30 ` Lars Ingebrigtsen
3 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-02-27 20:36 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
> SUMMARY OF TEST RESULTS
> -----------------------
> Files examined: 348
> Ran 4741 tests, 4655 results as expected, 7 unexpected, 79 skipped
> 1 files contained unexpected results:
> lisp/emacs-lisp/eieio-tests/eieio-tests.log
AFAICT this is now fixed,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-02-27 20:36 ` Stefan Monnier
@ 2021-02-28 13:30 ` Lars Ingebrigtsen
2021-03-01 17:36 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-02-28 13:30 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> SUMMARY OF TEST RESULTS
>> -----------------------
>> Files examined: 348
>> Ran 4741 tests, 4655 results as expected, 7 unexpected, 79 skipped
>> 1 files contained unexpected results:
>> lisp/emacs-lisp/eieio-tests/eieio-tests.log
>
> AFAICT this is now fixed,
Yup; this now works. This still fails, though:
1 unexpected results:
FAILED test-obsolete-encode-time-value
Confusingly enough, it only fails with "cd test; make" and not "make
check" in the directory above...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-02-28 13:30 ` Lars Ingebrigtsen
@ 2021-03-01 17:36 ` Stefan Monnier
2021-03-01 17:39 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-03-01 17:36 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>>> SUMMARY OF TEST RESULTS
>>> -----------------------
>>> Files examined: 348
>>> Ran 4741 tests, 4655 results as expected, 7 unexpected, 79 skipped
>>> 1 files contained unexpected results:
>>> lisp/emacs-lisp/eieio-tests/eieio-tests.log
>>
>> AFAICT this is now fixed,
>
> Yup; this now works. This still fails, though:
>
> 1 unexpected results:
> FAILED test-obsolete-encode-time-value
I suspect this failed before as well.
Should be fixed now, tho.
I still get one error when I do (cd test; make):
1 files contained unexpected results:
lisp/net/ntlm-tests.log
but I hope it has nothing to do with my recent changes.
> Confusingly enough, it only fails with "cd test; make" and not "make
> check" in the directory above...
I must admit I don't understand in which way those two are different
(nor how they compare to `make test/lisp/calendar/time-date-tests`
which may also give different results).
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: master 49bad2a: * lisp/cedet/semantic/analyze*.el: Use lexical-binding
2021-03-01 17:36 ` Stefan Monnier
@ 2021-03-01 17:39 ` Lars Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-01 17:39 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Thomas Fitzsimmons, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> 1 unexpected results:
>> FAILED test-obsolete-encode-time-value
>
> I suspect this failed before as well.
> Should be fixed now, tho.
Yup; this works well now here too.
> I still get one error when I do (cd test; make):
>
> 1 files contained unexpected results:
> lisp/net/ntlm-tests.log
>
> but I hope it has nothing to do with my recent changes.
I'm not getting that failure... some of the tests depend on some things
in GNU ELPA, but they should be disabled if it can't find the resources
there. But perhaps those checks are failing in your setup?
(Added Thomas to the CCs.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread