From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Little improvements on pulse.el Date: Wed, 10 Mar 2021 20:59:33 +0200 Organization: LINKOV.NET Message-ID: <87y2eultaq.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14896"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Gabriel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 10 20:13:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK4H8-0003lg-29 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 20:13:42 +0100 Original-Received: from localhost ([::1]:35288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK4H7-0008Qz-40 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 14:13:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK4Ej-00078n-Bc for emacs-devel@gnu.org; Wed, 10 Mar 2021 14:11:13 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:55155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK4Ef-0006DA-Mj for emacs-devel@gnu.org; Wed, 10 Mar 2021 14:11:12 -0500 X-Originating-IP: 91.129.108.46 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A9D9020006; Wed, 10 Mar 2021 19:11:05 +0000 (UTC) In-Reply-To: (Gabriel's message of "Wed, 10 Mar 2021 02:39:56 -0300") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266294 Archived-At: > 2. The name and the docstring mention the use with hooks, but would be > nice to use with advices as well. For example, to highlight the current > line when the cursor, buffer or window changes: > > (dolist (symbol '(scroll-up-command > scroll-down-command > recenter-top-bottom Scrolling commands can be handled by this hook: (add-hook 'window-scroll-functions #'pulse-line) > other-window > windmove-do-window-select (add-hook 'window-configuration-change-hook #'pulse-line) > kill-current-buffer > delete-window)) (add-hook 'window-state-change-functions #'pulse-line) > The code above does not work, since 'pulse-line-hook-function' does not > accept any argument (sent by the advice function). We can make it accept > optional arguments, but again the name will not be the best one. A new command could ignore its arguments: (defun pulse-line (&rest _) (interactive) (pulse-momentary-highlight-one-line (point)))