From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Date: Sat, 27 Mar 2021 08:06:45 -0400 Message-ID: <87y2e894x6.fsf@gmail.com> References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22310"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 27 13:07:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQ7ii-0005iR-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Mar 2021 13:07:12 +0100 Original-Received: from localhost ([::1]:45738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQ7ih-0006qS-Iy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Mar 2021 08:07:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQ7ia-0006p5-0T for bug-gnu-emacs@gnu.org; Sat, 27 Mar 2021 08:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60203) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQ7iY-0007LE-Is for bug-gnu-emacs@gnu.org; Sat, 27 Mar 2021 08:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQ7iY-0000Hi-DL for bug-gnu-emacs@gnu.org; Sat, 27 Mar 2021 08:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Mar 2021 12:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47388 X-GNU-PR-Package: emacs Original-Received: via spool by 47388-submit@debbugs.gnu.org id=B47388.16168468161079 (code B ref 47388); Sat, 27 Mar 2021 12:07:02 +0000 Original-Received: (at 47388) by debbugs.gnu.org; 27 Mar 2021 12:06:56 +0000 Original-Received: from localhost ([127.0.0.1]:43516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQ7iR-0000HK-TI for submit@debbugs.gnu.org; Sat, 27 Mar 2021 08:06:56 -0400 Original-Received: from mail-qk1-f173.google.com ([209.85.222.173]:37787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQ7iQ-0000H8-0T for 47388@debbugs.gnu.org; Sat, 27 Mar 2021 08:06:55 -0400 Original-Received: by mail-qk1-f173.google.com with SMTP id g15so7991636qkl.4 for <47388@debbugs.gnu.org>; Sat, 27 Mar 2021 05:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uwmZYS1olI/nvFOoI+nvUbqipsT77HOChDSxIdqq4+8=; b=jq0cxUgYDv14f3lrorw2kRNBp4XcZz9cMdZieeOtqYY0n0FWH76K1FTktaECntsM2f IAJoKwtfJUcsKpZemSI2k3s+RSs7EacON7W3uxcqzDQYIw96tjAu92q6hstd3JuejarR CpM5utgMCEbCfuOcV9+vFA4RtBwoJRGyxPGAIgGuJI4WaJ5ut6bBA0CP2QYvim5uy/7D MKGRp6YrnxOLvGdrJYKsV/dgiRTQIf6JxPYiZvfPq6JAMHcBGSFc0aGO5GZGuHLfPOvk sGfMC6GM003oOgOMzyrTdccSAKZ1bHJ1TCyDh9AVZZeKGRJgamqorDuooHJdp9ZiPrKn EAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uwmZYS1olI/nvFOoI+nvUbqipsT77HOChDSxIdqq4+8=; b=UevuQNY3B5+8zIZXHu4Ko+qqqfhnqU9Y72czJc3Lf0OVyNXwp4iBnOiHCiagYRNruT C9KK2YU7o3GKyENmm803W97Fknrp9Bs98NXQyjz4qKy+8jVwLcQDK1/lkegJpVi0qx9S QiavqZPXfM89R8MSHGaCy5BKxIQAkfRYu83oy6aUvz9/AG6Kpvb0/wNthLjEu5ws8+qj w+LZREI5+hWyEW6brRhIROFfDCKB3NQWYmLfkAPDX3fHwUiPYdE0f6hfaPCJaBrDkM7X sTxbAvC7kPHVW4BCIeW450olL2w1vVuxv0eN69kgZgBMUZ/3LQVh/nQ4GBG4n/Yrj0+U J+BQ== X-Gm-Message-State: AOAM532zA0nvDoqmX3wj1UXFBD1JFkVMFM2FpE+zRtYnT2pNO/JD0sZn m/kvqxfv262CCjKPMIPBvpuwBGf24zEQGA== X-Google-Smtp-Source: ABdhPJwZGcaUvT5c8OCyxhFjP1xmeNpKQUjtEkbG7oC+JT5O5eSZnMuIB4uRp9PfUj8k/HbNZ9pHnw== X-Received: by 2002:a37:a644:: with SMTP id p65mr17375154qke.20.1616846808157; Sat, 27 Mar 2021 05:06:48 -0700 (PDT) Original-Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id a20sm8793506qkg.61.2021.03.27.05.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Mar 2021 05:06:47 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 26 Mar 2021 20:34:16 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203119 Archived-At: On Fri 26 Mar 2021 at 20:34, Jo=C3=A3o T=C3=A1vora w= rote: > Ah, I get it, so ess-mode does something different. I'm not sure I understand - different from what? > Then maybe it should also set eldoc-documentation-strategy to > something sensible. Eldoc-documentation-strategy is just the new name > of eldoc-documentation-function. If you find an `ignore` there, you're > safe to change it , buffer-locally, as you did before. Maybe you > should even do it even if you _don't_ find an ignore there. The fact > that it's now defcustom doesn't change much in my opinion, I don't see > defcustom's as off-limits to major/minor modes, as long as the user is > still given override power in the mode hooks. > > Alternatively, ess-mode should just use the old interface. > It's still available and functional. > > But I think you should select a strategy that suits `ess-mode`'s > functions. So the recommended strategy to support 27.1+old eldoc, 27.1+new eldoc, and 28.0+new eldoc is something like the below? (if (function-equal #'ignore eldoc-documentation-function) (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-eldoc-function))