From: Alex Branham <alex.branham@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, 47388@debbugs.gnu.org
Subject: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc
Date: Sat, 27 Mar 2021 08:06:45 -0400 [thread overview]
Message-ID: <87y2e894x6.fsf@gmail.com> (raw)
In-Reply-To: <CALDnm52NL1XN0+bda9oN8+qd3CRBq8hZo0AmOJTa_6ewdJQsaw@mail.gmail.com> ("João Távora"'s message of "Fri, 26 Mar 2021 20:34:16 +0000")
On Fri 26 Mar 2021 at 20:34, João Távora <joaotavora@gmail.com> wrote:
> Ah, I get it, so ess-mode does something different.
I'm not sure I understand - different from what?
> Then maybe it should also set eldoc-documentation-strategy to
> something sensible. Eldoc-documentation-strategy is just the new name
> of eldoc-documentation-function. If you find an `ignore` there, you're
> safe to change it , buffer-locally, as you did before. Maybe you
> should even do it even if you _don't_ find an ignore there. The fact
> that it's now defcustom doesn't change much in my opinion, I don't see
> defcustom's as off-limits to major/minor modes, as long as the user is
> still given override power in the mode hooks.
>
> Alternatively, ess-mode should just use the old interface.
> It's still available and functional.
>
> But I think you should select a strategy that suits `ess-mode`'s
> functions.
So the recommended strategy to support 27.1+old eldoc, 27.1+new eldoc,
and 28.0+new eldoc is something like the below?
(if (function-equal #'ignore eldoc-documentation-function)
(add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t)
(add-function :before-until (local 'eldoc-documentation-function)
#'ess-r-eldoc-function))
next prev parent reply other threads:[~2021-03-27 12:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 14:05 bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Alex Branham
2021-03-26 18:27 ` Basil L. Contovounesios
2021-03-26 18:50 ` João Távora
2021-03-26 19:08 ` Alex Branham
2021-03-26 19:57 ` João Távora
2021-03-26 20:23 ` Alex Branham
2021-03-26 20:34 ` João Távora
2021-03-27 12:06 ` Alex Branham [this message]
2021-03-27 12:53 ` João Távora
2021-03-28 11:23 ` Alex Branham
2021-03-28 14:50 ` João Távora
2021-03-28 16:05 ` Alex Branham
2021-03-28 18:45 ` João Távora
2021-03-28 16:37 ` Stefan Monnier
2021-03-28 18:56 ` João Távora
2021-03-28 19:09 ` Stefan Monnier
2021-03-28 19:15 ` João Távora
2021-03-28 19:36 ` Stefan Monnier
2021-03-28 19:37 ` Stefan Monnier
2021-03-28 19:39 ` Stefan Monnier
2021-03-26 19:52 ` bug#47388: (no subject) QuietApe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2e894x6.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=47388@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.