From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix M-x gdb when debugging over Tramp Date: Thu, 08 Apr 2021 14:58:21 +0200 Message-ID: <87y2dtaq6q.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 08 15:03:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUUJm-0000uI-Lz for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 15:03:30 +0200 Original-Received: from localhost ([::1]:46740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUUJl-0004JX-Mq for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 09:03:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUUEu-00016e-9f for emacs-devel@gnu.org; Thu, 08 Apr 2021 08:58:28 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:57155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUUEr-0004l1-VM for emacs-devel@gnu.org; Thu, 08 Apr 2021 08:58:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1617886703; bh=9SlmhJ9tf9FWEjA9WmtfJ1F+81NJSwJW3kFu1imOumo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=R+uckcPDYA7X5HYiV/W/nDQk9tWunisWTY5cVsQv9tECxESGjNKD30bczOWx6rGAn 3CmtnnWs+SL5dEbqfIatU2EhJAP5CARr15Z1Q5UcTY1hAkDEePkgVoQyZEyrxUw2m3 7hAm2TlwaPgB2IiXYKkylHW93vPnYiztrOOQhGHE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.238.1]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McpNo-1m2zyX1qBG-00Zx4r; Thu, 08 Apr 2021 14:58:23 +0200 In-Reply-To: (Jim Porter's message of "Wed, 7 Apr 2021 16:14:35 -0700") X-Provags-ID: V03:K1:d1Bwa1D0uDNaO6DbViDvbVxp0hTnPrxfMclZBTkKFwX85gNT8U8 2xMjBxYq2EubHzCitRIToitxXBSa9u/gY00o4o140WI0P8KT57QBnnomtP5P6d1bZSYYP7K X68Rd/x59xeZvV0bP+1mHv/zuvKYo39yivgbvppoNfB9sebsWvkKNdBsODS4eFGxjuWVrBe UNfB6ybmVvFrV5ViQhdYA== X-UI-Out-Filterresults: notjunk:1;V03:K0:A1rtENJjUGQ=:OP4RHBNvRueSBDb0Utiajm EBFiBZZKIm7F+5afGF+/nTYI/TtiSidajnn6tcMpUfNvP9LybZw7w+LoXiS+6Mw+5nqQg7usy q7kIbTCZ/nNhkaM17O1mULiOE1VUq1XyDrWNO0bdWk0GV5dyLt9/x1rlBUIdibrpHSuGsP83i L8gcK8uYIhaZOcbbq2Agfxyk6pU3AIQRi5qxmQ/vhsro6U1g5lzN62nSUIBAnh4rFRhKMXWxp U6s4AWJx0uJkDWByecvI0ycX/8ozAOAgHfCEq7ljGlmq3Yxm6wGee3m6xQ5TMXaiGUVGIUvlB OlfyL5Al5Ko3A5H8HQ3tPcPRrEevPxvHPWNohYUeLbPbzT1Lh+qlM5jbvyv5SxJ9sAD3MIqum EFkL+w/OWAtVPHzfzUqrKtb4ICx3kVlxxogwfcDFIgXbf6Z/Pwfp59QlBfgGHtkA/nZpi7/Vf R9OCxutIEBN1zht/f+5l5ZnSbSsW/GWYlTdbJeE5xW/mapWMEv+HZRUIvMb8XwpxAbHyV46Jf iNDU74ixqNNXYf52C38E/74dV9ubKhdkIyL0rWUCQqLzWkSA6z7A6MIsU7JOPOJTuaspA126A EkuvCN64CuWsLI8qztNI7NfJKocOPbYDoBWHYPr2tJ4ml8fGYpQ5HScdiCgZG4NaqYHXzNNmP JPx4Oj2oRiUp59kn/j6T2POcokcdjfLUCZufuBWL820jabmFYeIjNryksOggbw8VM4CN/Q2vX 1LwzU5VkGyEcb2fhdOIiPBsQgiyULEffSp5sZ4ySvmWb63gwqTC/n1HCl9XwM+YczjjUstrj Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267611 Archived-At: Jim Porter writes: Hi Jim, > Here's a pair of patches (one against the latest git revision, and one > against the emacs-27 branch) to fix debugging via M-x gdb over Tramp. > There were two problems: > > 1) In `gdb-jsonify-buffer', when replacing the "fullname" with a Tramp > path, the wildcard was greedy, resulting in only one "fullname" being > replaced. This had the effect of rendering it impossible to have more > than one breakpoint, as all but the first breakpoint would have > unmodified "fullname"s. This fix isn't needed for Emacs 28, since > `gdb-jsonify-buffer' was replaced with a more-accurate parser for > GDB/MI. > > 2) In `gdb-frame-handler', `gdb-selected-file' needs to be the *local* > file path, since that's what `gud-last-frame' expects. Without this, > the overlay arrow for the current line in the source buffer won't > show. >From my POV these patches look OK, but I'm a very occasional gdb user. It would be great if somebody else could verify. I have also the impression that this is related to bug#39408, bug#28392 and bug#44151. Perhaps this could be checked, and in case of yes, I would much appreciate if we could solve all of these bugs. > I've been running with these patches for a few months locally and > haven't found any further issues. Note that I haven't filled out > copyright assignment papers, but these patches are very small, so my > understanding is that's not necessary. If you'd like me to fill them > out, just let me know. Assign request sent. Jim has proposed a further patch on the Tramp ML. > - Jim Best regards, Michael.