From: Michael Albinus <michael.albinus@gmx.de>
To: Jim Porter <jporterbugs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix M-x gdb when debugging over Tramp
Date: Thu, 08 Apr 2021 14:58:21 +0200 [thread overview]
Message-ID: <87y2dtaq6q.fsf@gmx.de> (raw)
In-Reply-To: <CANh=_JHtPinyHe2sHHUOG199nmof-7EJO97rc=GP_TX1YStCKg@mail.gmail.com> (Jim Porter's message of "Wed, 7 Apr 2021 16:14:35 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
Hi Jim,
> Here's a pair of patches (one against the latest git revision, and one
> against the emacs-27 branch) to fix debugging via M-x gdb over Tramp.
> There were two problems:
>
> 1) In `gdb-jsonify-buffer', when replacing the "fullname" with a Tramp
> path, the wildcard was greedy, resulting in only one "fullname" being
> replaced. This had the effect of rendering it impossible to have more
> than one breakpoint, as all but the first breakpoint would have
> unmodified "fullname"s. This fix isn't needed for Emacs 28, since
> `gdb-jsonify-buffer' was replaced with a more-accurate parser for
> GDB/MI.
>
> 2) In `gdb-frame-handler', `gdb-selected-file' needs to be the *local*
> file path, since that's what `gud-last-frame' expects. Without this,
> the overlay arrow for the current line in the source buffer won't
> show.
From my POV these patches look OK, but I'm a very occasional gdb
user. It would be great if somebody else could verify.
I have also the impression that this is related to bug#39408, bug#28392
and bug#44151. Perhaps this could be checked, and in case of yes, I
would much appreciate if we could solve all of these bugs.
> I've been running with these patches for a few months locally and
> haven't found any further issues. Note that I haven't filled out
> copyright assignment papers, but these patches are very small, so my
> understanding is that's not necessary. If you'd like me to fill them
> out, just let me know.
Assign request sent. Jim has proposed a further patch on the Tramp ML.
> - Jim
Best regards, Michael.
next prev parent reply other threads:[~2021-04-08 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 23:14 [PATCH] Fix M-x gdb when debugging over Tramp Jim Porter
2021-04-08 12:58 ` Michael Albinus [this message]
2021-04-15 5:02 ` Jim Porter
2021-04-15 7:55 ` Michael Albinus
2021-04-16 5:03 ` Jim Porter
2021-05-01 4:13 ` Jim Porter
2021-05-01 10:18 ` Michael Albinus
2021-04-19 11:55 ` William Xu
2021-04-19 12:44 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2dtaq6q.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.