From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aHsLBwW0hmAJZgAAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 14:37:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OO6pAgW0hmDSawAAB5/wlQ (envelope-from ) for ; Mon, 26 Apr 2021 12:37:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7CB5A9AB9 for ; Mon, 26 Apr 2021 14:37:24 +0200 (CEST) Received: from localhost ([::1]:53194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb0UN-00005X-A7 for larch@yhetil.org; Mon, 26 Apr 2021 08:37:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb0TD-0008WR-GD for emacs-orgmode@gnu.org; Mon, 26 Apr 2021 08:36:11 -0400 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:40525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lb0TB-0001UC-AT for emacs-orgmode@gnu.org; Mon, 26 Apr 2021 08:36:11 -0400 Received: by mail-qk1-x731.google.com with SMTP id q136so35260629qka.7 for ; Mon, 26 Apr 2021 05:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=ZsWnyikSZYgad29BO+lLrdoLEmePK6TYS4EhC3xjRBw=; b=hefXMBadacldpiQhRJMMLBFMsrpzltyC9Tu1Kij/fe4d0X9YwMp2b9HXoMqmQoNPyW 3JOJSObvyyuuYsGpBAwm7zIyXDByFhAq8eTRLfmhgof2diNtn2/zlLSZX9lPcKnQbC8F KzcIfG1GE2qdVmo+N3NcOhY7uEIjygiIBVHOnj/Ql+byD6NLe+PWdGKgMDgUxymuE3bJ 6yUx4e0bFUotWZaKDG7yCokq0+9Z5QonaYS/o1IyKy6PZ/pAfL3K05W90+QddYymtcws msz0oYieoHE/7bMzhmu7ES7tyHU5kS/K2KW6kMXsJm/Llewo42egmqTR6EsIVXsDvjJe VcTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=ZsWnyikSZYgad29BO+lLrdoLEmePK6TYS4EhC3xjRBw=; b=Bi+X3rhjPsGkgxbfiweA055z9BGapg48uXBR5si/LzCllJ77ly/Fh+841zal1Z4d+E /zdkDWAXi4/PtYsMC7nixTT5yz2ybtP9e7aEanR7DgZhftc35zs5LxMewEP2BCPJKzMQ rq6usRwR+spIo+UMqt9lV370wKK/4UJtH2IELMq5uqNi3ehco/k63OhqBXh+28RJuibn ePznw6/P/bI6B6SwStHI7EzbA5cuO4wPufhdvlWiCnNCUqjyMSjPYZuJC1lZVPX7R2h2 fNfinIQMmJDzvZkCXJ33LS+9mtnPk5G28c7lQXC1tl8lyB84R+N79WnNIGwquhHcD93c FTxg== X-Gm-Message-State: AOAM532y0XstteEH4NJeizvbY8LGsUlgHr6hyJbTgL/IcVpnP4IrXzS3 AdIwfab1/cfFo3fQm6JEuBvnR0kyw3U= X-Google-Smtp-Source: ABdhPJySdSLkchNbWmBGrdq2s4o7unHGyImDBSV4Jlxp5S13eX6uv7gX0ULzISr2PthV4E1VWX2j9w== X-Received: by 2002:ae9:dc47:: with SMTP id q68mr17406714qkf.197.1619440567225; Mon, 26 Apr 2021 05:36:07 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id 3sm1546232qko.120.2021.04.26.05.36.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 05:36:06 -0700 (PDT) User-agent: mu4e 1.5.11; emacs 28.0.50 From: No Wayman To: emacs-orgmode@gnu.org Subject: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)] Date: Mon, 26 Apr 2021 08:32:54 -0400 Message-ID: <87y2d5mde2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::731; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qk1-x731.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619440644; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZsWnyikSZYgad29BO+lLrdoLEmePK6TYS4EhC3xjRBw=; b=TDCJF5llcnytmxvFYdgv2lVf49FXAPYcRMuQbtGX+1DKPzrwXQ/d/hWx/9ixF08arbC22h nc4urcHPFixGOT6HteHPSS7AkyM/mMV5Vy1HPH5z15As0y+KL67I1y3SXte76IPdf6ColV kebfgBQUVaUkhrpnyRNo6n+sv5cllvqVa9c8tIFjoalZ/3a6EnAxVzMhkU1i8jxnfRvzXD c3qygN4IjiQlGpVkq0/uhnnltIzQDul9gLR6iKouAQMygPWp6nKWA2j+MJeMFgaZrNjObV YzADuAftd+J4kEyUNIFCjX0vEeAutKx+usCDsPM/Q+R9kzhS6vfIynMbd8hbSg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619440644; a=rsa-sha256; cv=none; b=jeOeO1J2s02ptwRyBKbwM6+Jnsq7hNnm45Cd7WggWZpXcdpxa2cSF27RPUsD38spBUTl7f M+dOmT6bu+vQBYZUyBUNXJCXmsG7tJXxxPXUMQqjDg4bE2Sb9VZJ3MYmXee+Npq1ncJvP7 N/gWbU7mzi8yTDLB5ebTZl/zjZxDsJLpO+4T2ProggeJ2SXmDSGXCiOPLxY+KwEnZU2pq6 qDqBFuPeKOcIu3UzdFGEhak6orw0I+W5TzeUfZHhU3CvcFK9mFZEmy6t5Su32+qvXGTV2i Fsx83JP8mdhIKNuWtMwMkP92Sw4bx+iAheWJJEww5TEzSRE/StFSqZKYypCHSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=hefXMBad; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.15 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=hefXMBad; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7CB5A9AB9 X-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: cJNKEbVVMn3x --=-=-= Content-Type: text/plain; format=flowed Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list. ------------------------------------------------------------------------ The attached patch updates the calling convention for several minor-mode definitions to use keywords in place of the older positional arguments. With the native comp branch being merged into Emacs' master branch, these types of warnings become more apparent to end users, so I figure it's a good idea to stay on top of them. Thanks, Nick --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Update-define-minor-mode-calling-convention.patch Content-Description: define-minor-mode-keyword-args >From b33e081225a441e43cd03cd127197e4abaa0966d Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Mon, 26 Apr 2021 08:25:25 -0400 Subject: [PATCH] Update define-minor-mode calling convention * org-list.el, org-src.el, org-table.el, org.el: Migrate minor mode definitions from positional arguments to keyword args. --- lisp/org-list.el | 2 +- lisp/org-src.el | 2 +- lisp/org-table.el | 4 ++-- lisp/org.el | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/org-list.el b/lisp/org-list.el index 98d9e36da..4d84d99bb 100644 --- a/lisp/org-list.el +++ b/lisp/org-list.el @@ -2296,7 +2296,7 @@ is an integer, 0 means `-', 1 means `+' etc. If WHICH is ;;;###autoload (define-minor-mode org-list-checkbox-radio-mode "When turned on, use list checkboxes as radio buttons." - nil " CheckBoxRadio" nil + :lighter " CheckBoxRadio" (unless (eq major-mode 'org-mode) (user-error "Cannot turn this mode outside org-mode buffers"))) diff --git a/lisp/org-src.el b/lisp/org-src.el index 20acee4e6..cabedecb6 100644 --- a/lisp/org-src.el +++ b/lisp/org-src.el @@ -682,7 +682,7 @@ This minor mode is turned on in two situations: \\{org-src-mode-map} See also `org-src-mode-hook'." - nil " OrgSrc" nil + :lighter " OrgSrc" (when org-edit-src-persistent-message (setq header-line-format (substitute-command-keys diff --git a/lisp/org-table.el b/lisp/org-table.el index 3030751cc..a0c354d86 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -499,7 +499,7 @@ This may be useful when columns have been shrunk." ;;;###autoload (define-minor-mode org-table-header-line-mode "Display the first row of the table at point in the header line." - nil " TblHeader" nil + :lighter " TblHeader" (unless (eq major-mode 'org-mode) (user-error "Cannot turn org table header mode outside org-mode buffers")) (if org-table-header-line-mode @@ -1966,7 +1966,7 @@ lines." When this mode is active, the field editor window will always show the current field. The mode exits automatically when the cursor leaves the table (but see `org-table-exit-follow-field-mode-when-leaving-table')." - nil " TblFollow" nil + :lighter " TblFollow" (if org-table-follow-field-mode (add-hook 'post-command-hook 'org-table-follow-fields-with-editor 'append 'local) diff --git a/lisp/org.el b/lisp/org.el index 675a614e2..f7fd90cf9 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -15640,7 +15640,7 @@ When a buffer is unmodified, it is just killed. When modified, it is saved This mode supports entering LaTeX environment and math in LaTeX fragments in Org mode. \\{org-cdlatex-mode-map}" - nil " OCDL" nil + :lighter " OCDL" (when org-cdlatex-mode (require 'cdlatex) (run-hooks 'cdlatex-mode-hook) -- 2.31.1 --=-=-=--