From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Proposing changes to adjust_frame_size Date: Thu, 06 May 2021 09:59:59 +0200 Message-ID: <87y2cswam6.fsf@gnu.org> References: <69a5e928-2998-f776-fa0d-f35e6ab1e65d@gmx.at> <20210505.194756.2198057137743556501.masm@luna.pink.masm11.me> <20210505.230733.1330791046879877132.masm@luna.pink.masm11.me> <87a6p9knr9.fsf@gnu.org> <9712b3f0-c442-61fc-93a6-773ffcde1c2e@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.13; emacs 28.0.50 Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 06 10:07:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZ2D-0002w3-B3 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 10:07:01 +0200 Original-Received: from localhost ([::1]:53916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZ2C-0007rz-7m for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 04:07:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leZ0e-00070y-Qi for emacs-devel@gnu.org; Thu, 06 May 2021 04:05:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49580) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZ0e-0007RZ-8T; Thu, 06 May 2021 04:05:24 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:49875) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leZ0e-0000Vy-5H; Thu, 06 May 2021 04:05:24 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailauth.nyi.internal (Postfix) with ESMTP id DDB9427C0054; Thu, 6 May 2021 04:05:23 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 06 May 2021 04:05:23 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefledguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe evveeikeetkeeviefgfeffiedvteeguddvffeuueduveegtddthedvhfeuveffhfenucfk phepkeejrdduieefrdefuddrudehgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgse hfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 May 2021 04:05:23 -0400 (EDT) In-reply-to: <9712b3f0-c442-61fc-93a6-773ffcde1c2e@gmx.at> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268949 Archived-At: martin rudalics writes: Hi Martin, >>> And after fixing my latest thinko in Fframe_parameters as in commit >>> e9baa733b8cac00e008cb834abc8712c8c00beed >> >> Is it possible that this broke some things? > > Do you mean this specific commit or one of my preceding ones? I'm not sure. It's just that I've noticed when that commit was the HEAD and not the day before. I update my checkout every morning CEST, so we can restrict the issue to at least the commits in, say, 36 hours before my message. If you want, I can bisect when I find some time, maybe this evening. > That latest one should affect you only if you have some special code > in your init file that uses `frame-parameter', `frame-height' or > `frame-width'. I have (setq default-frame-alist '((width . 90) (height . 50))) which is basically a relict of the times where I've not used a tiling WM. >> When I do "emacs -Q" I get a frame with menubar but no toolbar. > > Which build, GTK3? Yes. >> Only when I resize the frame the toolbar appears. When I turn both >> of them off using `M-x tool-bar-mode' and `M-x menu-bar-mode', they >> also won't vanish before I resize the frame. > > We can trace these behaviors but please answer the two questions above > first. > >> I have to say that I use sway, a tiling window manager, so it might be >> that this behavior is not observable with a "normal" WM where windows >> may define their own size. > > By design, my commits should not have changed anything for you. Ok, great. Bye, Tassilo