From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#48609: Eglot and tab-always-indent conflict in python-mode Date: Tue, 25 May 2021 10:36:23 +0100 Message-ID: <87y2c3f948.fsf@gmail.com> References: <87v979b2tp.fsf@gmail.com> <87k0npb15j.fsf@gmail.com> <87fsydb05v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29262"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Doug Davis , 48609@debbugs.gnu.org To: Pankaj Jangid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 11:37:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llTUu-0007Sh-78 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 11:37:12 +0200 Original-Received: from localhost ([::1]:46320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llTUt-0000zm-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 05:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llTUk-0000wN-4f for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 05:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llTUj-0002RU-T9 for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 05:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llTUj-0004FB-Pt for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 05:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48609 X-GNU-PR-Package: emacs Original-Received: via spool by 48609-submit@debbugs.gnu.org id=B48609.162193539416264 (code B ref 48609); Tue, 25 May 2021 09:37:01 +0000 Original-Received: (at 48609) by debbugs.gnu.org; 25 May 2021 09:36:34 +0000 Original-Received: from localhost ([127.0.0.1]:44738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llTUH-0004EG-Ra for submit@debbugs.gnu.org; Tue, 25 May 2021 05:36:34 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:42865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llTUE-0004E1-QO for 48609@debbugs.gnu.org; Tue, 25 May 2021 05:36:31 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id f75-20020a1c1f4e0000b0290171001e7329so12417481wmf.1 for <48609@debbugs.gnu.org>; Tue, 25 May 2021 02:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=yD1tAcSwcm72nymSL0X4u1MTKpV/tJ0raWZhdsjeFVE=; b=otnvD/wRmd3Ydqos1cG0ZdNeAN0e0ZBqNCkDMtqIkPl45tvC0+h9MVXvCZ5HbrFMvE tukoVnJ5GMliYjOxbcxz7ufzUmUofdtE7tEljqSIJDcnV3dU9yaOHbIyvBrilMNhycNp slW/1VGnoT7DXb5Iajxv2hVC76R2VLu8ikTCzr8p+TM0Bs2fzGrZqaV811sn94u5hxd4 GgnznB/Z4/cK40fAenWGXfNipGe3OtNIDQVqq+l267jVngiqYAV5KXnnBorH8Wx8TUe0 ZGTfMjHm7/6klf4pQBRneqlhfa01/lI2++jdKYRUuypRHo/mo0IrvUQtmsQXm1bXzuWY 8N/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yD1tAcSwcm72nymSL0X4u1MTKpV/tJ0raWZhdsjeFVE=; b=DWWIM9OugDY9JQ2RI/nwDdsqgs7QngzttYDZqD9546949b27Wqh+ABZvNKkjV3jpLo mvu5Hml9HjFwKUSpbPOWv3eVPf8XD+iQPeIS5qpvpkVHAW9ZP668q86Yv/UQaJi7sFBm dmHIdK07EH6KxXhv2KOS6EXXMz/UaWRzn5TqSWNaaZC3HBYjgO8h8869x8YDgHSSxx50 gqHQqO1X5UAz93rA75wDuWgSSku90XIb3sDRHU+GwsWg4/f/PL5papuqhdnpV56oiClx Na03LeQLZ43Dt8RaH2Hr6Bz5y/Wu2Lmi2JVrrP/iZjbwrFeuqd7uodI9Tb+LLEFheTXB yiOQ== X-Gm-Message-State: AOAM533g870zla/RLxHoK8nyGdBsmmIUse/8kV9H/jefKoMJrgQcxWTb QQYVEUUDl010V4IjnRYg7jEPlCTDCNg= X-Google-Smtp-Source: ABdhPJziaZpuB0Wn98qsy3g6RFJHVLteQoMRJTRvPv5aKq2gfRUoSViC3Yu/Pz7Zq4oFUoeiobcTjA== X-Received: by 2002:a1c:5419:: with SMTP id i25mr2994355wmb.51.1621935384723; Tue, 25 May 2021 02:36:24 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id v12sm15739669wrv.76.2021.05.25.02.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 02:36:24 -0700 (PDT) In-Reply-To: (Pankaj Jangid's message of "Tue, 25 May 2021 12:17:06 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207186 Archived-At: Pankaj Jangid writes: > Jo=C3=A3o T=C3=A1vora writes: > >> When Eglot is active, the completion system can find a large number of >> completions available for that empty line. Since you have selected >> tab-always-indent to be 'complete, Eglot will request and present those >> completions in the *Completions* buffer. >> >> The only way to cancel that operation is by C-g or clicking somewhere >> else. This in turn makes it so that the "last" command issued isn't >> indent-for-tab-command anymore, and so there aren't two >> indent-for-tab-command commands in a row. And that is the criteria >> consulted by python.el's indentation function to decide to cycle the >> indentation. >> >> So I'm not sure what needs to be fixed here, if anything, or how you >> would like this to behave. > > I think that the best place should be python.el then. A variable > =E2=80=98python-completion-on-empty-line=E2=80=99 or some better name. I = don=E2=80=99t know if > such a variable already exist or not. Need to check. Yes, I agree, python.el. I wonder if instead of that variale the cycling logic could be changed to account for this case where there may be completions at point (Eglot is only one possible provider of such completions, btw.) Jo=C3=A3o