From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#49274: [PATCH] lisp/cus-theme: retain documentation string when customizing theme Date: Wed, 30 Jun 2021 11:09:29 -0300 Message-ID: <87y2ar78bq.fsf@tbb.theblackbeard.org> References: <20210629144412.455196-1-league@contrapunctus.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49274@debbugs.gnu.org To: Christopher League Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 30 16:09:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyatw-0008Ac-Iw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 16:09:16 +0200 Original-Received: from localhost ([::1]:38422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyatv-00037P-Gr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 10:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyati-000379-UH for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 10:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyati-0001D6-49 for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 10:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyati-0003VU-0H for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 14:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49274 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49274-submit@debbugs.gnu.org id=B49274.162506209513404 (code B ref 49274); Wed, 30 Jun 2021 14:09:01 +0000 Original-Received: (at 49274) by debbugs.gnu.org; 30 Jun 2021 14:08:15 +0000 Original-Received: from localhost ([127.0.0.1]:58375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyast-0003U4-8S for submit@debbugs.gnu.org; Wed, 30 Jun 2021 10:08:15 -0400 Original-Received: from mail-pf1-f172.google.com ([209.85.210.172]:47014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyasn-0003T7-U2 for 49274@debbugs.gnu.org; Wed, 30 Jun 2021 10:08:09 -0400 Original-Received: by mail-pf1-f172.google.com with SMTP id x16so2522464pfa.13 for <49274@debbugs.gnu.org>; Wed, 30 Jun 2021 07:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version; bh=Hdcupo2xecJt9rsQNALscllSHCI6h+fbaUrZRTizSbU=; b=nXIWWMc2Pmmr3vJVj2R1H/Vxgj27O3AizTAxmzrbvu34wtbOFsl75FnM6xJaNOVQex D86BqIvu5QrOYxu8PRBGlibvCnB5F5pj6R46bKJKsNqsBHnhEi6dZ+guS+F/v8mphGSB rctv4GawnAuwTwfTN9KzHXo4+krfTp6h2YqOP95EG1Yr0CO+6qAjkhM//HyHhjnUc/Gt egpKLXTK1LVmzqQWSu1UXiTi7tuAFDycO85JSPt92lRZNl/6HWtHcVN2XZEtjBJ3DJB0 4oQQwwT8B7rY3vWEwEPaLXn5bRXjJMAgGk4VXsYlA6N/yUM+8L9r6dbG66pvumCNw0xL h/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :mime-version; bh=Hdcupo2xecJt9rsQNALscllSHCI6h+fbaUrZRTizSbU=; b=XUXRiHIND3T1LmdK39pbv2vbX3w817HsXQN41kAEztM/WpWUlgSCZT24ByDw1iiZfJ nm2WLz7tH94eehAL0AftTYgoEb33AFCS7eHU11HG6Mp5635ivgE+JK6UdhEtCuQlPCsn z1rCO0PnUOy/kAUNL/Z9Vvv0oHgUfZBbsU/TEvRC7keTPyajvry3Vq5okGbYHSoQE01P 26fIJFjhHMjbhJpQws0LhtRCIaKzlk5mpI1cBcq1ysSRIRcEKfHFcEFYglr7/HHMFTlL CPSEwLNqBtfnGTdzfW48wMpczwTD/gO0avW+o8GjNhnB5emzRVdRW2133AtDxa7mPOTJ /ASg== X-Gm-Message-State: AOAM530Yy7YmstfFhomgK/0cHSmdcrD0WC2cmtQQcvF4U8NKy8ITTEDr 1ZVENSHGIhII55lEKGqvPDYUKuIbpc0= X-Google-Smtp-Source: ABdhPJzC2XP9sXrwCYLSDbNrKPl0R2SqB12oH6wXECthzfaoZ/uoihRQoQ7u1dzhFA78bfCiRm1rkA== X-Received: by 2002:a05:6a00:23ce:b029:30f:2089:25df with SMTP id g14-20020a056a0023ceb029030f208925dfmr6384582pfc.22.1625062079830; Wed, 30 Jun 2021 07:07:59 -0700 (PDT) Original-Received: from tbb.theblackbeard.org ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id a6sm21653479pfo.212.2021.06.30.07.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 07:07:59 -0700 (PDT) In-Reply-To: <77d32b46f062bc1dac34220709a8175f@contrapunctus.net> (message from Christopher League on Tue, 29 Jun 2021 21:57:51 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209198 Archived-At: Christopher League writes: > On 2021-06-29 20:03, Mauro Aranda wrote: >> That's because there was a change to the :format property of the text >> widget, but this call wasn't updated. Try overriding it like this: >> (widget-create 'text :format "%v" ...) >> >> The above should make it work. Please try it, thank you. > > Yes, that works. I'm including an updated patch below. Thanks. CL > [...] > + (widget-insert "Description: ") > + (setq custom-theme-description > + (widget-create 'editable-field > + :value (or (get theme 'theme-documentation) > + (format-time-string "Created %Y-%m-%d.")))) Did you send the old one by mistake? Also, please format the commit message according to the Emacs conventions: see the file CONTRIBUTE and the "Commit messages" section in particular.