all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Christopher League <league@contrapunctus.net>
Cc: 49274@debbugs.gnu.org
Subject: bug#49274: [PATCH] lisp/cus-theme: retain documentation string when customizing theme
Date: Wed, 30 Jun 2021 11:09:29 -0300	[thread overview]
Message-ID: <87y2ar78bq.fsf@tbb.theblackbeard.org> (raw)
In-Reply-To: <77d32b46f062bc1dac34220709a8175f@contrapunctus.net> (message from Christopher League on Tue, 29 Jun 2021 21:57:51 -0400)

Christopher League <league@contrapunctus.net> writes:

> On 2021-06-29 20:03, Mauro Aranda wrote:
>> That's because there was a change to the :format property of the text
>> widget, but this call wasn't updated.  Try overriding it like this:
>> (widget-create 'text :format "%v" ...)
>> 
>> The above should make it work.  Please try it, thank you.
>
> Yes, that works. I'm including an updated patch below. Thanks. CL
>

[...]

> +    (widget-insert "Description: ")
> +    (setq custom-theme-description
> +	  (widget-create 'editable-field
> +		         :value (or (get theme 'theme-documentation)
> +				    (format-time-string "Created %Y-%m-%d."))))

Did you send the old one by mistake?

Also, please format the commit message according to the Emacs
conventions: see the file CONTRIBUTE and the "Commit messages" section
in particular.





  reply	other threads:[~2021-06-30 14:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 14:44 bug#49274: [PATCH] lisp/cus-theme: retain documentation string when customizing theme Christopher League
2021-06-29 22:38 ` Mauro Aranda
2021-06-29 23:54   ` Christopher League
2021-06-30  0:03     ` Mauro Aranda
2021-06-30  1:57       ` Christopher League
2021-06-30 14:09         ` Mauro Aranda [this message]
2021-06-30 15:05           ` Christopher League
2021-07-03 13:23             ` Mauro Aranda
2021-07-03 13:30               ` Lars Ingebrigtsen
2021-07-03 13:52                 ` Mauro Aranda
2021-07-03 13:35               ` Eli Zaretskii
2021-07-03 13:55                 ` Mauro Aranda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2ar78bq.fsf@tbb.theblackbeard.org \
    --to=maurooaranda@gmail.com \
    --cc=49274@debbugs.gnu.org \
    --cc=league@contrapunctus.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.