From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Date: Mon, 16 Aug 2021 14:53:18 +0200 Message-ID: <87y291blfl.fsf@gnus.org> References: <87o89ygyu8.fsf@gnus.org> <87bl5xfvjv.fsf@gnus.org> <83lf518ter.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: tgbugs@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 14:54:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFc8N-0005bF-Rx for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 14:54:31 +0200 Original-Received: from localhost ([::1]:51836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFc8M-0005Ja-Lm for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 08:54:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFc7L-0003mv-0o for emacs-devel@gnu.org; Mon, 16 Aug 2021 08:53:27 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFc7J-0003HZ-GJ; Mon, 16 Aug 2021 08:53:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yRmIbwfavGXUAtQHGT73plqF5CMvBMkkslMFJ+WMCqo=; b=QWkqinnUGQ2K3FCCjCZaf9ZyXY qYSiUs4srAme0E19oPlJ05P7H8AZ3S7W2sXiN9H5Fmezmej6/q8qhyMoYDItCxYx6cWxe6HPYimTr uNo7OHOCzoETYzHLVW7CEwcHbme96gBpO5GBP8Cfl3yOwBQ1Xps60kqw5UOI90F81JNs=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFc7D-0004vy-7Z; Mon, 16 Aug 2021 14:53:23 +0200 In-Reply-To: <83lf518ter.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Aug 2021 15:29:16 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272434 Archived-At: Eli Zaretskii writes: > More importantly, what about selective-display, which replaces > newlines with \r's? I think this replacement is for that use case. > > So perhaps the condition for the replacement should be > selective-display? Aha! The initial revision of files.el had: +(defun hack-local-variables (&optional force) [...] + ;; Look at next local variable spec. + (if selective-display (re-search-forward "[\n\C-m]") + (forward-line 1)) So the ^M stuff that remains in here may have nothing to do with CRLF DOS stuff, but is something that's left over from code meant to deal with selective display? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no