From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#51550: 29.0.50; Customize Group INS buttons sometimes don't have a left box line Date: Tue, 02 Nov 2021 11:58:16 +0100 Message-ID: <87y266g6yf.fsf@rub.de> References: <87ee80gezy.fsf.ref@yahoo.com> <87ee80gezy.fsf@yahoo.com> <83a6iolzjd.fsf@gnu.org> <87zgqnk74n.fsf@rub.de> <83ee7zll84.fsf@gnu.org> <87wnlrfhdk.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51550@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 11:59:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhrVZ-0001Us-VM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 11:59:14 +0100 Original-Received: from localhost ([::1]:53338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhrVY-00065j-VN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 06:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhrVO-00063S-Qq for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 06:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53514) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhrVO-0006mw-FG for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 06:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhrVO-0007QR-9c for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 06:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51550 X-GNU-PR-Package: emacs Original-Received: via spool by 51550-submit@debbugs.gnu.org id=B51550.163585070928503 (code B ref 51550); Tue, 02 Nov 2021 10:59:02 +0000 Original-Received: (at 51550) by debbugs.gnu.org; 2 Nov 2021 10:58:29 +0000 Original-Received: from localhost ([127.0.0.1]:36827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhrUr-0007Pf-2h for submit@debbugs.gnu.org; Tue, 02 Nov 2021 06:58:29 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:34179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhrUo-0007PS-Eq for 51550@debbugs.gnu.org; Tue, 02 Nov 2021 06:58:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1635850698; bh=jp9ILOo6n0iGv48KDdSYU/G6sWlwnj1FXsxZzAc3bNg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Bz+0akgn6GBjkRdBnEhY7odpwfE9zwTft5fYbpvTsttkfXZ5YZ4oqgw7uJp2jW4Wa FtqNp9E9x8D4KmYpl85xhduy4FrH9W78xND2QoA4eZyW8shTv4ps4JQUrm2m/J8gzl cfrYcZiuCKrmZoGweD20oqI9L6QiH8WQSPMe3axI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs ([94.220.124.73]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhU5R-1mDSYr0qW3-00edLY; Tue, 02 Nov 2021 11:58:18 +0100 In-Reply-To: <87wnlrfhdk.fsf@yahoo.com> (Po Lu's message of "Tue, 02 Nov 2021 09:58:31 +0800") X-Provags-ID: V03:K1:VutKc1n0ERYkpql+kgEO9LkzvdqBgNb6+s1+MA2DpgpclDYJMfX rSML6PzRGmK+I3lIzHPgMlKMaO3V1shIVnIggi7jSjlmAoJWZC9lkd/bMuTA2JWpoQx4GlU v+1bH1sBZQyIOd4gBvKzw/Ak/jBeWqvyyulCHbzNyCP/oikmplv4qdiEP83xVVecMMI90MS 2hmQiQeGxYRXMEkqiPcGw== X-UI-Out-Filterresults: notjunk:1;V03:K0:AD3Cnr25HTc=:+fuNerCXnfK/ASNPN7sXqN EJGCqWKPDgQKC6oPG4I6EpOzdSfmrIuhgzheUigJDn2/qTtF7EPjHLRu9X8FMcyownqigzP6e M5oSy+lcjFB6tv6PdsScJJPAwrusys+4Xp/d9M08oy8rCQt4BBwQQqs+DyQstmxzL/fhZxTbu 8u8Gdkm5hnYhetClbXRzEbL07idLPfWLli+7vzpbv7IjFzOztVsAQKUD10bXZcfQ2oQ+NMRAS b2RDXfYgEGj+dBujAFCNFGe25e6siEhWiXxJ74OKyc1jjUsqh9ZqdA0J6g4lDVR/jIT7OWtUb g9p6VA53/PUJKYwT9su9IHkztLuh5p01SAo+2wxIOFaO8FvVkERhkOueNo0XNGtIsieLczmDz 443Pr4sBYZ6o0Zb7UenzMq9UR0F1M3JS6oS+GpJsm/rCjZoXDYMCN5cdeBTwSZLY9Arbk0D6X eiMF0m6jI3pCeIhIoIvFOa1zjpJbrr8mJfr3HtXEi0IE93IxmFqoCyNz0slFNyDAmPZxvXPoY EcPorKJIYpdmSij/e0SMT1PM56PpY71vI29S4oJoNtnWuloGzQRsPqtKQo3Q+U+iGxW+s5dTL E1LUixh5WH1OTOYry5ogCHe6pIxDH1W2o0eKoiPaNzcAberUTs01ezXi/8mcZkJfheqhqmR2I ef4CNnWtM5mPu5mazc+kXt2tjpoQy2FSI/+6tr59x+m6FnmOsK2R2UFSWzxi08ZoK1q2KbO3C H7eBynaPRB4sfiIejJxrj8ixB+7PR6eLbsNCN7UAIvgWCrnc+US5dCgmRaTUyz6F7O2YqmQ3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218801 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 02 Nov 2021 09:58:31 +0800 Po Lu wrote: > Eli Zaretskii writes: > >> I see that xterm does something special in x_draw_relief_rect when the >> line width is exactly 1 pixel, and w32term.c doesn't do that. maybe >> that's the problem. > > That isn't related, it only serves to make buttons look nicer and have > more contrast by drawing a black line outside a relief rect. > > FWIW, this bug doesn't manifest in 27.2. With the following patch I no longer see the display glitch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: widget-specify-field patch diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index fb06a95f51..ba6f26fccc 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -373,7 +373,7 @@ widget-specify-field (forward-char 1)) (widget-field-add-space (insert-and-inherit " "))) - (setq to (point))) + (setq to (1- (point)))) (let ((keymap (widget-get widget :keymap)) (face (or (widget-get widget :value-face) 'widget-field)) (help-echo (widget-get widget :help-echo)) --=-=-= Content-Type: text/plain However, this cannot be the right fix: with this patch the editable field widget is no longer editable (it also doesnt't extended to the right window margin, and it's one space shorter than when the widget-field face is edited to remove the :extend property (without the patch)). Moreover, in emacs-27 the editable field is also extended yet there's no display glitch. (There's one difference in widget-specify-field between emacs-27 and 28/master, but undoing that change in the latter does not eliminate the display glitch.) There's also something strange about customizing the widget-field face: when I uncheck the box for "Extend" and click the "State" button to "Set for Current Session", nothing happens with -Q and without -Q I get the message "End of file during parsing". If (without -Q) I click "State" to "Save for Future Sessions", then it says "SAVED and set" but the "Extend" checkbox remains checked and the editable fields are extended. If I keep "Extend" checked and click the Value Menu to "Off", then I can set the change for the current session, and then the editable field widget is not extended, but the display glitch remains (and the editable field is one space longer than with the above patch). Steve Berman --=-=-=--