From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 51674@debbugs.gnu.org
Subject: bug#51674: 29.0.50; [PATCH] Fix hang when displaying xwidget script dialog
Date: Mon, 08 Nov 2021 07:50:54 +0100 [thread overview]
Message-ID: <87y25z87jl.fsf@gnus.org> (raw)
In-Reply-To: <87r1brp3c0.fsf@yahoo.com> (Po Lu's message of "Mon, 08 Nov 2021 14:29:51 +0800")
Po Lu <luangruo@yahoo.com> writes:
> That's weird, because video works here. Does it work in another
> WebKitGTK based browser, like Epiphany, on your Debian system? Thanks.
I tried Epiphany now, and it works there. That is, it plays the mp4
very slowly, but it does play it. In the xwidget, it just puts up the
controls, and then nothing happens. (This happens with `M-x
xwidget-webkit-browse-url', too, so it's not just this way of creating
the xwidgets that's stopping the mp4s from working.)
> Unfortunately I don't know enough about macOS to solve the problem here.
>
> But try removing this snippet of x_draw_xwidget_glyph_string:
Yes, indeed, that fixed it, so I now have basic <video> support working
in eww. 😹 But only on Macos.
> /* On X11, this keeps generating expose events. */
> #ifndef USE_GTK
> /* Resize xwidget webkit if its container window size is changed in
> some ways, for example, a buffer became hidden in small split
> window, then it can appear front in merged whole window. */
> if (EQ (xww->type, Qwebkit)
> && (xww->width != text_area_width || xww->height != text_area_height))
> {
> Lisp_Object xwl;
> XSETXWIDGET (xwl, xww);
> Fxwidget_resize (xwl,
> make_int (text_area_width),
> make_int (text_area_height));
> }
> #endif
I'm not that familiar with the xwidget.c code... but that's just always
maximalising the widget to be as big as the Emacs window? That can't be
correct, surely. Should I just remove it? It doesn't seem to lead to
any regressions in xwidget-webkit-browse-url, either.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-08 6:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fss7s8gr.fsf.ref@yahoo.com>
2021-11-08 2:10 ` bug#51674: 29.0.50; [PATCH] Fix hang when displaying xwidget script dialog Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08 5:24 ` Lars Ingebrigtsen
2021-11-08 5:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08 5:40 ` Lars Ingebrigtsen
2021-11-08 5:45 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08 6:25 ` Lars Ingebrigtsen
2021-11-08 6:29 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08 6:50 ` Lars Ingebrigtsen [this message]
2021-11-08 6:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08 7:01 ` Lars Ingebrigtsen
2021-11-09 4:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 4:45 ` Lars Ingebrigtsen
2021-11-09 4:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 5:30 ` Lars Ingebrigtsen
2021-11-09 5:34 ` Lars Ingebrigtsen
2021-11-09 5:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 6:10 ` Lars Ingebrigtsen
2021-11-09 4:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y25z87jl.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51674@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.