[PATCH] ob-R async evaluation

[PATCH] ob-R async evaluation

[Jeremie Juste]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hello,

I'm attaching a patch that clean up a bit of non conventional coding
practices (mainly because of my ignorance), in ob-R. These were
initially generating warning during the compilation of org-mode.

The main feature is the use of the defvaralias ess-eval-visibly-p when
the :result output in async evaluation. 

With this change make does not generate any warning for ob-R.el and all
the test of ob-R.el passes, so no significant change for the user.

Best regards,
Jeremie


[-- Attachment #2: 0001-ob-R.el-Patch-4-async-evaluation.patch --]
[-- Type: application/pdf, Size: 4196 bytes --]

Re: [PATCH] ob-R async evaluation

[Timothy]

Hi Jeremie,

Sorry it's taken a while to get to this. I've just gone through your
patch and it looks quite reasonable. I also took the liberty of
fixing the indentation in a few spots and tweaking your commit message.

This has just been pushed as 58db28d.

> I'm attaching a patch that clean up a bit of non conventional coding
> practices (mainly because of my ignorance), in ob-R. These were
> initially generating warning during the compilation of org-mode.

By the way, just letting you know that your mail client declared your
.patch to be a PDF file 😛.
> [2. application/pdf; 0001-ob-R.el-Patch-4-async-evaluation.patch]...

--
Timothy