From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 6170c50: Fix regression in help-mode prompt Date: Tue, 14 Dec 2021 15:01:21 +0100 Message-ID: <87y24n5lqm.fsf@rub.de> References: <20211213135228.14462.36839@vcs0.savannah.gnu.org> <20211213135230.17FE620A0A@vcs0.savannah.gnu.org> <83h7bbl4el.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3237"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Kangas , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 14 15:08:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mx8UA-0000ez-7A for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Dec 2021 15:08:54 +0100 Original-Received: from localhost ([::1]:36308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mx8U8-0004PX-EQ for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Dec 2021 09:08:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx8N6-0004dF-U9 for emacs-devel@gnu.org; Tue, 14 Dec 2021 09:01:37 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:34901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx8N4-0000Gu-M4; Tue, 14 Dec 2021 09:01:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639490482; bh=aB3ZX64ri+g/jZZGY88b5971JPAFCB6y0GLbphre+B0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=fOKl0q6fKCOf+Cuj0HC3XBpGcTan3XAc36RkGwPQ+/qluO22Waxvv4nERIEjNAy14 jPa57KE+z+O8IhdhRSHx4HFqGN0488Y/26ofh1JTkE6JKavQKhT7pswV/DqMiMb1Lo AghhOC91/UqQiYkOiEcuOCZPqpynCyZJ6EdnhdN0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs ([89.246.38.80]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6Ue3-1mqplz0Kz3-006zOd; Tue, 14 Dec 2021 15:01:22 +0100 In-Reply-To: <83h7bbl4el.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Dec 2021 15:09:06 +0200") X-Provags-ID: V03:K1:lTNI5DJN/jpqwn3+g2xSRn/pgIP7oQldF4OtvOLy9V+q9vAwkzl o67uo0ol3LvPnAvwzHiZ2Pzei6+m36jq06ihChMblu2EWmTWhKq7zAWRITErKt+lNLy9Vf2 Fo4vCGAwcNanXRu8VBjisiOFP4/vCNtdcrHYnOwn+cPAryzpEfDg7UXYlMyzlWP6aZhVSg6 LfazmpPVCgA4xRJXbR7jg== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZaQE0x+rDWk=:B7QdvJC5WOmeW5GHF6IMW9 eewXC1Dqyo5SEkf0zNkU7/b1AbA2zTtuK7WCLMGMN5v8nc947Q8+q5zRk9KRcCMC0KnR8nUBt KxKsLQ0ud5OcuTCNUwq2y2Ljl8uQuUrzryI3oRPPT3H56cm3KuoYq/oIajJ2h2BmlvbPSuBvg fvH0y18Ajmy1icp/bCXmn9JDjsulTzpVYPSNZrYuLFCIsedMg9P0GP5imyREM1RJDYHVLQ1vv uG1LYqUypV5MUI0o973yU7v8N4hr7ThSkIC+CB2bm6gjn4P0kMqMA18DAIFTS4xSeS0rhbup5 RuRT0pbcHZiNNF2VUxnAIgcahoqgJCuik41kbidlr1FN7KDFrJ9gRK/L19vyigG15BpVlXHBC Huxd8Sug2y958Ru+o9lKuGx6MC34Q3STfpB4bLnouOdje6Ak7Nv4O4fdo6q5MLA3KcLbyjqgq GhVaebwn0A420v/4AE/By48matbp8QAjO/RF8FLISn79WXuvnGjGar5on8T61EAEK27LFkvRk Qr1kgnf5j4tFtx7UFXdee9Sg812Gdff2B1GE9Qk0im7QNMkdxR9I+yybZwzSwNU+BUhNaTf5a Ej8BZEZeq9uIwh9Fb0MCIJzbZIU5CPhMkB/4s/aF8welmW5WMCa5n0kTQJ4AxWljGPf19f3kD 0YELdc1C7+cqAg6fQKtMigPeb2mxXhSafwgYXl93QvuSeCTa3lwTg7P6S6wq4AJCAKqUCPzr4 b/NfemNwIERTRTux1j3xQ1acbgOA5NT4TteF8UqC2AnmDpuz/He0ZqACLV5BODY8K01uaqzv Received-SPF: pass client-ip=212.227.15.18; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281901 Archived-At: On Tue, 14 Dec 2021 15:09:06 +0200 Eli Zaretskii wrote: >> From: Stefan Kangas >> Date: Tue, 14 Dec 2021 03:30:22 -0800 >> >> eliz@gnu.org (Eli Zaretskii) writes: >> >> > diff --git a/lisp/help-macro.el b/lisp/help-macro.el >> > index 1fa9d82..b3c7e23 100644 >> > --- a/lisp/help-macro.el >> > +++ b/lisp/help-macro.el >> > @@ -165,14 +165,18 @@ and then returns." >> > (let ((cursor-in-echo-area t) >> > (overriding-local-map local-map)) >> > (setq key (read-key-sequence >> > - (format "Type one of the options lis= ted%s: " >> > + (format "Type one of listed options%= s: " >> >> Are we sure that this is an improvement? I find the old text more natu= ral. > > I didn't change the text to improve it, I changed it to make it > shorter. Because otherwise, when we echo the keys typed by the user, > they overflow the (default) window width, and that resizes the > mini-window, which causes an unpleasant effect of scrolling the Help > window. > > If you can suggest a different solution that avoids the resizing, > please do. Is this about the *Metahelp* buffer displayed by typing `C-h ?'? Then I think it's sufficient to prompt with "Type one of the options%s: ", since the buffer containing the options is in plain view. Steve Berman