From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: kahatlen@gmail.com, 54437@debbugs.gnu.org
Subject: bug#54437: 28.0.92; command-modes returns nil for native compiled functions
Date: Sun, 20 Mar 2022 16:18:24 +0100 [thread overview]
Message-ID: <87y214odof.fsf@gnus.org> (raw)
In-Reply-To: <xjfee2wc3ga.fsf@ma.sdf.org> (Andrea Corallo's message of "Sun, 20 Mar 2022 10:40:05 +0000")
Andrea Corallo <akrl@sdf.org> writes:
> Yes, we'd still need to store the information in each .eln and update
> the value of this new global hash table each time (probably in
> comp--register-subr). So some C should be modified anyway even if
> (maybe?) less, I doubt is doable in the realease branch at this point
> anyway.
There's also the problem with stale entries -- if you're re-loading an
.eln with different functions with different command modes, you'd need
some way to nix out the old ones (for instance, if a command goes from
having modes to not). Or you'd have to register all the commands in the
hash table, which seems awkward.
I think if we want this in Emacs 28, it's probably safer to just
cherry-pick the commit to master, as invasive as that is. On the other
hand, the command-modes stuff is new functionality in Emacs 28, so just
documenting that it doesn't work with native-comp (yet) would also be
fine, and then perhaps do an Emacs 28.2 later with the patch.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-20 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:53 bug#54437: 28.0.92; command-modes returns nil for native compiled functions Knut Anders Hatlen
2022-03-17 16:29 ` Lars Ingebrigtsen
2022-03-17 16:44 ` Lars Ingebrigtsen
2022-03-19 14:13 ` Lars Ingebrigtsen
2022-03-19 15:20 ` Eli Zaretskii
2022-03-19 17:54 ` Andrea Corallo
2022-03-19 18:05 ` Lars Ingebrigtsen
2022-03-20 10:40 ` Andrea Corallo
2022-03-20 15:18 ` Lars Ingebrigtsen [this message]
2022-03-21 9:56 ` Andrea Corallo
2022-03-21 14:53 ` Lars Ingebrigtsen
2022-03-19 18:49 ` Knut Anders Hatlen
2022-03-17 17:53 ` Eli Zaretskii
2022-03-17 17:56 ` Lars Ingebrigtsen
2022-03-17 17:58 ` Lars Ingebrigtsen
2022-03-17 18:21 ` Eli Zaretskii
2022-03-17 18:22 ` Lars Ingebrigtsen
2022-03-17 20:02 ` Lars Ingebrigtsen
2022-03-17 22:50 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y214odof.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=54437@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=kahatlen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.