all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 8b7aaf3e56: Speed up GIF animations
Date: Mon, 11 Apr 2022 15:10:39 +0200	[thread overview]
Message-ID: <87y20bahps.fsf@gnus.org> (raw)
In-Reply-To: <87v8vf22ge.fsf@yahoo.com> (Po Lu's message of "Mon, 11 Apr 2022 21:07:29 +0800")

Po Lu <luangruo@yahoo.com> writes:

>> +  int cache_image_size = width * height * ximg->bits_per_pixel / 8;
>
> Emacs_Pix_Container is an opaque type that can be typedefed to a variety
> of things on different platforms.
>
> You cannot directly refer to bits_per_pixel, which only exists on X.
> This will probably break if bits_per_pixel is not a multiple of 8 as
> well.  It can be any random value on X Windows, and might not even exist
> if the image format is not ZPixmap.

Right.

> What is the temp field for?  Is it for storing bitmap data?  If so, it
> should just be a bitmap set using the PUT_PIXEL macro.

I want to copy the bitmap that we've already computed in an efficient
way.  PUT_PIXEL would be way too slow.  Any ideas?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2022-04-11 13:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164968086746.23681.8842816343836400594@vcs2.savannah.gnu.org>
     [not found] ` <20220411124107.C2A8CC009A8@vcs2.savannah.gnu.org>
2022-04-11 13:07   ` master 8b7aaf3e56: Speed up GIF animations Po Lu
2022-04-11 13:10     ` Lars Ingebrigtsen [this message]
2022-04-11 13:13       ` Lars Ingebrigtsen
2022-04-11 13:45         ` Lars Ingebrigtsen
2022-04-11 14:54           ` Lars Ingebrigtsen
2022-04-11 23:58             ` Po Lu
2022-04-11 13:19       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y20bahps.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.