From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 43397@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Caio Henrique <caiohcs0@gmail.com>
Subject: bug#43397: 28.0.50; Adding tool bar items: update tool bar
Date: Tue, 03 May 2022 18:09:30 +0200 [thread overview]
Message-ID: <87y1zivbr9.fsf@gnus.org> (raw)
In-Reply-To: <jwvzgjymxnd.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 03 May 2022 11:41:58 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> My crystal ball suggests there's a weak hash-table in here somewhere.
That's a really good crystal ball:
(defconst tool-bar-keymap-cache (make-hash-table :weakness t :test 'equal))
If I remove the :weakness t there, then the toolbar is never updated.
So it's a caching problem, one of the two difficult problems in
programming.
Hm... poking around in that code, I don't quite follow how this is all
supposed to be hooked up, or which caches should be flushed. Does the
crystal ball have more insights?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-05-03 16:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 14:30 bug#43397: 28.0.50; Adding tool bar items: update tool bar Caio Henrique
2020-09-14 21:44 ` Caio Henrique
2020-09-15 15:27 ` Eli Zaretskii
2020-09-15 20:05 ` Stefan Monnier
2020-09-16 2:26 ` Eli Zaretskii
2021-08-27 17:40 ` Lars Ingebrigtsen
2021-08-27 22:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-28 15:30 ` Lars Ingebrigtsen
2022-05-03 15:28 ` Lars Ingebrigtsen
2022-05-03 15:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-03 16:09 ` Lars Ingebrigtsen [this message]
2022-05-03 16:19 ` Lars Ingebrigtsen
2022-05-03 16:49 ` Eli Zaretskii
2022-05-03 16:50 ` Lars Ingebrigtsen
2022-05-03 16:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-03 16:39 ` Lars Ingebrigtsen
2022-05-03 16:46 ` Lars Ingebrigtsen
2022-05-03 16:54 ` Eli Zaretskii
2022-05-03 16:57 ` Lars Ingebrigtsen
2022-05-03 17:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-03 18:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1zivbr9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43397@debbugs.gnu.org \
--cc=caiohcs0@gmail.com \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.