From: Ihor Radchenko <yantar92@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 55451@debbugs.gnu.org
Subject: bug#55451: 28.1.50; Executing (jit-lock-mode -1) does not disable jit-lock-mode
Date: Fri, 20 May 2022 16:13:58 +0800 [thread overview]
Message-ID: <87y1yw39kp.fsf@localhost> (raw)
In-Reply-To: <83mtfdd3ln.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> That's exactly the situation I had:
>> 1. Tried M-x jit-lock-mode. Did not work. Understandable - special minor
>> mode.
>> 2. M-: (jit-lock-mode -1). No error. Executed.
>> 3. Tried to debug something assuming that jit-lock is disabled.
>> 4. After several minutes, realised that jit-lock is still working.
>
> But the doc string already caters to your use case:
>
> If you need to debug code run from jit-lock, see `jit-lock-debug-mode'
To clarify, I was trying to debug race condition in font-lock itself.
jit-lock made things even more complex and I just wanted to quickly
disable it. I did not want to debug jit-lock behaviour at all.
>> I would not expect users to read minor mode docstring every time to
>> check if the usual convention is broken.
>
> Users don't need to turn off jit-lock. People who want to debug it,
> OTOH, _are_ expected to read the doc string.
I understand. I do not consider the described issue critical. However,
from a perspective of Elisp developer, minor mode docstrings rarely
contain low-level information. Rather general minor mode description +
standard boilerplate generated by define-minor-mode. That boilerplate is
well-known an is usually not worth checking out multiple times:
>>> This is a minor mode. If called interactively, toggle the
>>> Org-Indent mode mode. If the prefix argument is positive,
>>> enable the mode, and if it is zero or negative, disable the mode.
>>>
>>> If called from Lisp, toggle the mode if ARG is toggle. Enable
>>> the mode if ARG is nil, omitted, or is a positive number.
>>> Disable the mode if ARG is a negative number.
>>>
>>> To check whether the minor mode is enabled in the current buffer,
>>> evaluate ...
So, I would not expect that habituated developers actually check out the
docstring regarding enabling/disabling the mode. At least I did not
until I realised that something is strange and jit-lock-mode was not
disabled after M-: (jit-lock-mode -1)
Again, it is just my perspective consisting of a single personal
datapoint. If you think that the current state is ok, feel free to
disregard my complaint.
Best,
Ihor
next prev parent reply other threads:[~2022-05-20 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 14:00 bug#55451: 28.1.50; Executing (jit-lock-mode -1) does not disable jit-lock-mode Ihor Radchenko
2022-05-16 15:53 ` Eli Zaretskii
2022-05-17 18:03 ` Lars Ingebrigtsen
2022-05-18 11:46 ` Ihor Radchenko
2022-05-18 17:27 ` Lars Ingebrigtsen
2022-05-18 17:41 ` Eli Zaretskii
2022-05-19 13:49 ` Ihor Radchenko
2022-05-19 14:00 ` Eli Zaretskii
2022-05-20 8:13 ` Ihor Radchenko [this message]
2022-05-19 23:13 ` Richard Stallman
2022-05-20 6:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1yw39kp.fsf@localhost \
--to=yantar92@gmail.com \
--cc=55451@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.