From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: F. Jason Park Newsgroups: gmane.emacs.devel Subject: Re: master df1e553688 4/5: Accommodate nonstandard turbo file senders in erc-dcc Date: Thu, 26 May 2022 08:48:13 -0700 Message-ID: <87y1yo70si.fsf@neverwas.me> References: <165326807986.26072.15447905248642892407@vcs2.savannah.gnu.org> <20220523010801.21947C009A8@vcs2.savannah.gnu.org> <87ee0gbh0s.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2717"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 26 18:25:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuGJ0-0000Tl-FT for ged-emacs-devel@m.gmane-mx.org; Thu, 26 May 2022 18:25:46 +0200 Original-Received: from localhost ([::1]:57122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuGIz-0007rB-J9 for ged-emacs-devel@m.gmane-mx.org; Thu, 26 May 2022 12:25:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuFiu-0008Ou-RZ for emacs-devel@gnu.org; Thu, 26 May 2022 11:48:28 -0400 Original-Received: from mail-108-mta51.mxroute.com ([136.175.108.51]:38519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuFir-0000fq-LT for emacs-devel@gnu.org; Thu, 26 May 2022 11:48:28 -0400 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta51.mxroute.com (ZoneMTA) with ESMTPSA id 181010debbb000c327.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 26 May 2022 15:48:18 +0000 X-Zone-Loop: 5954ce749d15ec335a76678b023c00b220ea9df3123b X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mjmecT2x39D6aI2+eIVMuXvqzprvXzG1ulQwroBu3lo=; b=jVs2Zv8nrEjqttRjlb8lVB1CTh sEv1JiMCklmC9LosI8Y54VZtNBeLCw0X2Y1OTQW5NwUL0d3B+tMZsugcPm853XCHvlQMyT+dTicu8 LqLTALkuu59UwAA0dZX/S/aEnv4f1jSv20Dxze7ZaKuC+zaeHDypOUKB+o2JEX0gTtq97CD7kauCX Dv0HI5Ky4vk6ssj22FAOAU1ovT2rhJJ70xyiDBcrwDFBAZHhBT6oWHIv+UJmvTmzQTqMchrauS+Ok gtZaPdFR8WdMVtQwnPu4NJSbRyHhlFreeW5s6ufuWBDQ3dvwl+13HoALJkn0ipU/9lq4h/6la6ieq Z6hcSzbA==; In-Reply-To: <87ee0gbh0s.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 26 May 2022 14:44:03 +0200") X-AuthUser: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.51; envelope-from=jp@neverwas.me; helo=mail-108-mta51.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 26 May 2022 12:24:20 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290282 Archived-At: Hi Lars, Lars Ingebrigtsen writes: > Something in recent erc changes is making the EMBA build test fail. For > instance: > > https://emba.gnu.org/emacs/emacs/-/jobs/46150 This links to a job on my branch for fix/bug-48598, so I'm guessing you meant to highlight something else. (More info on that specific failure below, just in case anyone's curious.) The subject line of this email references a commit on master. If it triggered a pipeline named after it, I can't find it. Do you have a different link by any chance? My initial push for that same bug set triggered this pipeline: https://emba.gnu.org/emacs/emacs/-/pipelines/18010 which didn't build anything. But since you say "build test," I'm guessing you mean build-image-inotify (or similar), which it seems is included in those "scheduled 3x daily" pipelines and some but not all pipelines triggered by routine pushes. There actually was a more recent failure on master (triggered by a push from me) that ended in a weird timeout or hang, namely: > Subject: Failed pipeline for master | emacs | 4d60dcd8 > Newsgroups: gmane.emacs.buildstatus > Date: Tue, 24 May 2022 23:01:08 -0400 (1 day, 11 hours, 21 minutes ago) > Pipeline #18061 has failed! > Project: emacs ( https://emba.gnu.org/emacs/emacs ) > Branch: master ( https://emba.gnu.org/emacs/emacs/-/commits/master ) > Commit: 4d60dcd8 ( https://emba.gnu.org/emacs/emacs/-/commit/4d60dcd87c72f7b96cac04233ffb253bd79f5bb1 ) > Commit Message: ; Fix inevitable failure in erc-dcc test > * tes... > Commit Author: F. Jason Park > Pipeline #18061 ( https://emba.gnu.org/emacs/emacs/-/pipelines/18061 ) > triggered by EMBA bot ( https://emba.gnu.org/bot ) > had 1 failed build. > Job #46114 ( https://emba.gnu.org/emacs/emacs/-/jobs/46114/raw ) > Stage: build-images > Name: build-image-inotify But I don't think this is what you're referring to because there were other, similar build failures preceding it, such as https://emba.gnu.org/emacs/emacs/-/pipelines/18058 https://emba.gnu.org/emacs/emacs/-/pipelines/18060 and ones following it that succeeded, like https://emba.gnu.org/emacs/emacs/-/pipelines/18063 So the failure(s) you're talking about must have occurred elsewhere between 18010 and 18061. I clicked through that interval in the web UI and couldn't find anything. Perhaps someone deleted them? (If there's an API token I could borrow to better investigate, I have tooling made for this sort of thing.) BTW, the job you linked to above, 46150, failed because I neglected to quote the `make_params' variable properly in the generated YAML document test/infra/test-jobs.yml. And it failed in the test stage, not the build stage. In case anyone cares, I modified that variable in that throwaway branch to ensure my expensive tests always run, something I inferred was acceptable from my conversations with Michael Albinus on the tracker for bug#48598. If that's not the case, please say so. Regardless, I was alerted to that job failure shortly after it occurred and tried to address it promptly, as was hopefully shown by the subsequent pipeline: https://emba.gnu.org/emacs/emacs/-/jobs/46152 Anyway, I'd like people to know that ERC (and I) take these tests seriously. So, whatever it is, we'll get to the bottom of it. Thanks, J.P.