bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Sean Whitton]

Hello,

I'd like to define an abbrev for minibuffer-mode but it doesn't have an
abbrev table.  There's a comment in minibuffer.el saying that this is
because abbrev.el is not loaded early enough.  It would be useful to
have the abbrev table for this mode too.

-- 
Sean Whitton

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Eli Zaretskii]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Mon, 13 Jun 2022 11:38:43 -0500
> 
> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
> abbrev table.  There's a comment in minibuffer.el saying that this is
> because abbrev.el is not loaded early enough.

AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
try changing that, and see if both a bootstrap and a simple build run
to completion OK.

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Sean Whitton]

Hello,

On Mon 13 Jun 2022 at 08:04PM +03, Eli Zaretskii wrote:

>> From: Sean Whitton <spwhitton@spwhitton.name>
>> Date: Mon, 13 Jun 2022 11:38:43 -0500
>>
>> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>> abbrev table.  There's a comment in minibuffer.el saying that this is
>> because abbrev.el is not loaded early enough.
>
> AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
> try changing that, and see if both a bootstrap and a simple build run
> to completion OK.

Thanks.  I see what you mean.  Tested both of those and it works.  Shall
I push to master so it can receive wider testing?

-- 
Sean Whitton

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Eli Zaretskii]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: 55946@debbugs.gnu.org
> Date: Mon, 13 Jun 2022 12:35:43 -0500
> 
> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
> >> abbrev table.  There's a comment in minibuffer.el saying that this is
> >> because abbrev.el is not loaded early enough.
> >
> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
> > try changing that, and see if both a bootstrap and a simple build run
> > to completion OK.
> 
> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
> I push to master so it can receive wider testing?

Let's see what Stefan thinks about this.

Stefan, any comments?

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>> >> abbrev table.  There's a comment in minibuffer.el saying that this is
>> >> because abbrev.el is not loaded early enough.
>> >
>> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
>> > try changing that, and see if both a bootstrap and a simple build run
>> > to completion OK.
>> 
>> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
>> I push to master so it can receive wider testing?
>
> Let's see what Stefan thinks about this.
> Stefan, any comments?

I couldn't find the corresponding patch, so I don't know what to say.

The comment only refers to defining an abbrev table while loading
`minibuffer.el` because `minibuffer.el` was loaded by `abbrev.el`.
But AFAICT nowadays `abbrev.el` is loaded before `minibuffer.el`, so the
problem seems to have disappeared.


        Stefan

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Sean Whitton]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

Hello,

On Mon 13 Jun 2022 at 05:26PM -04, Stefan Monnier wrote:

>>> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>>> >> abbrev table.  There's a comment in minibuffer.el saying that this is
>>> >> because abbrev.el is not loaded early enough.
>>> >
>>> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
>>> > try changing that, and see if both a bootstrap and a simple build run
>>> > to completion OK.
>>>
>>> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
>>> I push to master so it can receive wider testing?
>>
>> Let's see what Stefan thinks about this.
>> Stefan, any comments?
>
> I couldn't find the corresponding patch, so I don't know what to say.

Just the attached simple change.

> The comment only refers to defining an abbrev table while loading
> `minibuffer.el` because `minibuffer.el` was loaded by `abbrev.el`.
> But AFAICT nowadays `abbrev.el` is loaded before `minibuffer.el`, so the
> problem seems to have disappeared.

Cool.

-- 
Sean Whitton

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-abbrev-tables-for-minibuffer-mode-and-minibuffer.patch --]
[-- Type: text/x-patch, Size: 1214 bytes --]

From 791f4991873d4eba25ae608bedb67190f347074f Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Mon, 13 Jun 2022 12:24:17 -0500
Subject: [PATCH] Add abbrev tables for minibuffer-mode and
 minibuffer-inactive-mode

* lisp/minibuffer.el (minibuffer-mode, minibuffer-inactive-mode): Add
an abbrev table for each of these modes (bug#55946).
---
 lisp/minibuffer.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index bf89874ecc..2fd4902ef2 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2837,7 +2837,6 @@ minibuffer-inactive-mode-map
   "<down-mouse-1>" #'ignore)
 
 (define-derived-mode minibuffer-inactive-mode nil "InactiveMinibuffer"
-  :abbrev-table nil          ;abbrev.el is not loaded yet during dump.
   ;; Note: this major mode is called from minibuf.c.
   "Major mode to use in the minibuffer when it is not active.
 This is only used when the minibuffer area has no active minibuffer.
@@ -2859,7 +2858,6 @@ minibuffer-mode
 `minibuffer-setup-hook' and `minibuffer-exit-hook' rather than
 the mode hook of this mode."
   :syntax-table nil
-  :abbrev-table nil
   :interactive nil)
 
 ;;; Completion tables.
-- 
2.30.2

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> I couldn't find the corresponding patch, so I don't know what to say.
> Just the attached simple change.

Looks fine to me, thanks,


        Stefan

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Sean Whitton]

Hello,

On Mon 13 Jun 2022 at 09:40PM -04, Stefan Monnier wrote:

>>> I couldn't find the corresponding patch, so I don't know what to say.
>> Just the attached simple change.
>
> Looks fine to me, thanks,

Thanks, pushed.  I don't believe this needs a NEWS entry, but happy to
write one if others thing otherwise.

-- 
Sean Whitton

bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table

[Robert Pluim]

>>>>> On Tue, 14 Jun 2022 14:38:43 -0500, Sean Whitton <spwhitton@spwhitton.name> said:

    Sean> Hello,
    Sean> On Mon 13 Jun 2022 at 09:40PM -04, Stefan Monnier wrote:

    >>>> I couldn't find the corresponding patch, so I don't know what to say.
    >>> Just the attached simple change.
    >> 
    >> Looks fine to me, thanks,

    Sean> Thanks, pushed.  I don't believe this needs a NEWS entry, but happy to
    Sean> write one if others thing otherwise.

Itʼs a new feature (in a sense) so announcing it would be nice.

Robert
--