all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist
@ 2021-02-09 23:56 jakanakaevangeli
  2022-06-16 13:40 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: jakanakaevangeli @ 2021-02-09 23:56 UTC (permalink / raw)
  To: 46414

add-hook can add an entry to the hook symbol's hook--depth-alist
property and remove-hook doesn't remove it. This means that for each
call to eval-after-load, after-load-functions' hook--depth-alist gets a
new element when the feature is loaded, which can hinder performance.

This can also cause problems if your completing-read-function uses

    (minibuffer-with-setup-hook (:append generated-function-symbol)
      (read-from-minibuffer ...))

This will add a new element to minibuffer-setup-hook's the depth alist
for each completing-read session (such is the case when using
selectrum.el [1] completion function).

[1] https://github.com/raxod502/selectrum/





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist
  2021-02-09 23:56 bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist jakanakaevangeli
@ 2022-06-16 13:40 ` Lars Ingebrigtsen
  2022-06-16 14:18   ` jakanakaevangeli
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-16 13:40 UTC (permalink / raw)
  To: jakanakaevangeli; +Cc: 46414

jakanakaevangeli <jakanakaevangeli@chiru.no> writes:

> add-hook can add an entry to the hook symbol's hook--depth-alist
> property and remove-hook doesn't remove it. This means that for each
> call to eval-after-load, after-load-functions' hook--depth-alist gets a
> new element when the feature is loaded, which can hinder performance.
>
> This can also cause problems if your completing-read-function uses
>
>     (minibuffer-with-setup-hook (:append generated-function-symbol)
>       (read-from-minibuffer ...))
>
> This will add a new element to minibuffer-setup-hook's the depth alist
> for each completing-read session (such is the case when using
> selectrum.el [1] completion function).

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

The test case here isn't complete, so I can't test whether the problem
is still present.  I think it might have been fixed by:

commit 4bd7963e2e244ace94afa59124f2637543d74ba2
Author:     Stefan Monnier <monnier@iro.umontreal.ca>
AuthorDate: Tue Feb 22 10:18:43 2022 -0500

    (add-hook, remove-hook): Fix leaks (bug#48666)
    
    * lisp/subr.el (add-hook, remove-hook): Rewrite the hook depth
    management so we only keep the info relevant to functions present on
    the hook.

Do you still see this problem in Emacs 29?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist
  2022-06-16 13:40 ` Lars Ingebrigtsen
@ 2022-06-16 14:18   ` jakanakaevangeli
  0 siblings, 0 replies; 3+ messages in thread
From: jakanakaevangeli @ 2022-06-16 14:18 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 46414-done

Lars Ingebrigtsen <larsi@gnus.org> writes:

> jakanakaevangeli <jakanakaevangeli@chiru.no> writes:
>
>> add-hook can add an entry to the hook symbol's hook--depth-alist
>> property and remove-hook doesn't remove it. This means that for each
>> call to eval-after-load, after-load-functions' hook--depth-alist gets a
>> new element when the feature is loaded, which can hinder performance.
>>
>> This can also cause problems if your completing-read-function uses
>>
>>     (minibuffer-with-setup-hook (:append generated-function-symbol)
>>       (read-from-minibuffer ...))
>>
>> This will add a new element to minibuffer-setup-hook's the depth alist
>> for each completing-read session (such is the case when using
>> selectrum.el [1] completion function).
>
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> The test case here isn't complete, so I can't test whether the problem
> is still present.  I think it might have been fixed by:
>
> commit 4bd7963e2e244ace94afa59124f2637543d74ba2
> Author:     Stefan Monnier <monnier@iro.umontreal.ca>
> AuthorDate: Tue Feb 22 10:18:43 2022 -0500
>
>     (add-hook, remove-hook): Fix leaks (bug#48666)
>     
>     * lisp/subr.el (add-hook, remove-hook): Rewrite the hook depth
>     management so we only keep the info relevant to functions present on
>     the hook.
>
> Do you still see this problem in Emacs 29?
>
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

Yep it was fixed by this commit and also the related


commit db92e83797bf2f1af4e0b0383283a49968746b51
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Apr 23 16:50:12 2021 -0400

    * lisp/subr.el (add-hook): Try and fix bug#46326
    
    Use `eq` indexing on `hook--depth-alist`.
    
    (remove-hook): Remove old entries from `hook--depth-alist`.

Thanks.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-16 14:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-09 23:56 bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist jakanakaevangeli
2022-06-16 13:40 ` Lars Ingebrigtsen
2022-06-16 14:18   ` jakanakaevangeli

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.