From: Lars Ingebrigtsen <larsi@gnus.org>
To: jakanakaevangeli <jakanakaevangeli@chiru.no>
Cc: 46414@debbugs.gnu.org
Subject: bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist
Date: Thu, 16 Jun 2022 15:40:56 +0200 [thread overview]
Message-ID: <87y1xwbuaf.fsf@gnus.org> (raw)
In-Reply-To: <878s7w94o1.fsf@miha-pc> (jakanakaevangeli@chiru.no's message of "Wed, 10 Feb 2021 00:56:14 +0100")
jakanakaevangeli <jakanakaevangeli@chiru.no> writes:
> add-hook can add an entry to the hook symbol's hook--depth-alist
> property and remove-hook doesn't remove it. This means that for each
> call to eval-after-load, after-load-functions' hook--depth-alist gets a
> new element when the feature is loaded, which can hinder performance.
>
> This can also cause problems if your completing-read-function uses
>
> (minibuffer-with-setup-hook (:append generated-function-symbol)
> (read-from-minibuffer ...))
>
> This will add a new element to minibuffer-setup-hook's the depth alist
> for each completing-read session (such is the case when using
> selectrum.el [1] completion function).
(I'm going through old bug reports that unfortunately weren't resolved
at the time.)
The test case here isn't complete, so I can't test whether the problem
is still present. I think it might have been fixed by:
commit 4bd7963e2e244ace94afa59124f2637543d74ba2
Author: Stefan Monnier <monnier@iro.umontreal.ca>
AuthorDate: Tue Feb 22 10:18:43 2022 -0500
(add-hook, remove-hook): Fix leaks (bug#48666)
* lisp/subr.el (add-hook, remove-hook): Rewrite the hook depth
management so we only keep the info relevant to functions present on
the hook.
Do you still see this problem in Emacs 29?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-16 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 23:56 bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist jakanakaevangeli
2022-06-16 13:40 ` Lars Ingebrigtsen [this message]
2022-06-16 14:18 ` jakanakaevangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1xwbuaf.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=46414@debbugs.gnu.org \
--cc=jakanakaevangeli@chiru.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.