From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55768: 26.3; isearch highlighting in dired Date: Tue, 28 Jun 2022 19:22:18 +0200 Message-ID: <87y1xgn1o5.fsf@gnus.org> References: <87leuebeyj.fsf@gnus.org> <87mtesacyr.fsf@gnus.org> <86tu84ohjw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27756"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55768@debbugs.gnu.org, Thierry EMERY To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 28 19:24:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6EwX-00073D-B3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 19:24:05 +0200 Original-Received: from localhost ([::1]:48184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6EwW-00029M-7i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 13:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6EvW-0000pX-83 for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 13:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6EvV-0000Du-Ve for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 13:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6EvV-0004Pl-ML for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 13:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jun 2022 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55768 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55768-submit@debbugs.gnu.org id=B55768.165643695416924 (code B ref 55768); Tue, 28 Jun 2022 17:23:01 +0000 Original-Received: (at 55768) by debbugs.gnu.org; 28 Jun 2022 17:22:34 +0000 Original-Received: from localhost ([127.0.0.1]:56226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Ev3-0004Ou-Mq for submit@debbugs.gnu.org; Tue, 28 Jun 2022 13:22:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Euy-0004Od-Oi for 55768@debbugs.gnu.org; Tue, 28 Jun 2022 13:22:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=b4+oKAfcxyv4ACFA4QaYVA4SFMe4L5s3unAzryk4j+4=; b=cYaFznHIoohOQ6xljSTXDtM+w+ HofpS8THYzmy/xhIZTdog872yYadfIKqME4PExyCZJbbgjQ1NMc0lylule78ZObhyp0sLMlgBPbJG 6zQuMrWM4g5qqq8slYWDOWW/giDmESLl3BegXdLdwoT5DDLFdWoNHfM7pUssco9Qwv8Q=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6Eup-0004cD-EJ; Tue, 28 Jun 2022 19:22:21 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX4+PajoZ1RTEj/ //9oJKOWAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YGHBERAaB8lXkAAAGlSURBVCjPfZI9bhsxEIUf B7sDi9UGUASZlQs5kPcUIxUqVG1hC7AqFzJg7SloA0lNBU4KVzSwEUieMrM6gFkQfPx58/iRwFet hnnsgCNgH3ZFbPHPpQhs0b4vsS8FF4F/fepLBriUdwqcv99HwDzcL6xwBvmL29KhymAZx7K8RpMw uSzcHFp0A1weF5rYyiqYshMY+RHcX/JuUAdC6222+IwqGK3QMKd1sKImGlAONftrjWOGFgiVlYPG 2X1+CEltTRyz/WFhsBvjmPPAMjdGDbVRIL/gkJajYCEfKL48jcJi/eYpNifFAEflF3igbVJxnLhH 7DNPtbi5m9fzWQlXnQOql4VeZeNvRbNVhxtwsP4Z1qMZOii913ewx7fYUYBdR/M7YBaDC53bBD7r nFJe5Za9fQsw6ItSJXGrEdwsTVw2aC/cKE6VLo6NJih731BCPb4P98U3JtUlG48rU1Kj9zxFBFTo c0OFtbJam3RUIRuv28w6LqZc/FZ5AZsQK/sR9hjx9P78025Dru9UtJ5ee46JhlHASaJTGvGiMnrQ yBPkix/1H0iqgxbgryChAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA2LTI4VDE3OjE3OjAxKzAw OjAwfWaDygAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNi0yOFQxNzoxNzowMSswMDowMAw7O3YA AAAASUVORK5CYII= X-Now-Playing: Mark Fell & Will Guthrie's _Infoldings_: "Infoldings 1" In-Reply-To: <86tu84ohjw.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 28 Jun 2022 19:53:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235563 Archived-At: Juri Linkov writes: >>> (invisible-p (point)) has already been tested in the previous line, >>> but it only tests that >>> there is a text property, not actual invisibility: >>> (defun invisible-p (pos) >>> (get-text-property pos 'invisible)) >> >> That's not the definition of invisible-p. It's >> >> DEFUN ("invisible-p", Finvisible_p, Sinvisible_p, 1, 1, 0, >> doc: /* Non-nil if text properties at POS cause text there to >> be currently invisible. > > I checked this again, and I see nothing wrong in the current implementati= on: > > (invisible-p (get-text-property (point) 'invisible)) > > is a valid call, because the arg of =E2=80=98invisible-p=E2=80=99 can be = the actual value > of the =E2=80=98invisible=E2=80=99 text property. The claim was that invisible-p: >>> it only tests that there is a text property, not actual >>> invisibility and then there's a definition of invisible-p, which indeed only tests that. I pointed out that that's not what invisible-p is defined as, or what it does. In other words, this: ;; If the following character is currently invisible, ;; skip all characters with that same `invisible' property value. ;; Do that over and over. (while (and (< (point) end) (invisible-p (point))) (if (invisible-p (get-text-property (point) 'invisible)) Is fine, but (eq (invisible-p (point)) (invisible-p (get-text-property (point) 'invisible))) is always true. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no