From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil Date: Thu, 07 Jul 2022 20:02:42 +0200 Message-ID: <87y1x4er7h.fsf@gnus.org> References: <87mtdlguwi.fsf@gnus.org> <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7343"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56430@debbugs.gnu.org To: Brennan Vincent Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 20:03:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9VqV-0001jg-2u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 20:03:23 +0200 Original-Received: from localhost ([::1]:54328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9VqU-000091-4s for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 14:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9VqA-0008Mc-L7 for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 14:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9VqA-0007Uv-D0 for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 14:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9VqA-0006KJ-Au for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56430 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 56430-submit@debbugs.gnu.org id=B56430.165721697524286 (code B ref 56430); Thu, 07 Jul 2022 18:03:02 +0000 Original-Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 18:02:55 +0000 Original-Received: from localhost ([127.0.0.1]:57817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Vq2-0006Jd-RI for submit@debbugs.gnu.org; Thu, 07 Jul 2022 14:02:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Vq0-0006JP-J3 for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 14:02:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J5c6pJYIeZPTZ9jzF46CrvgcIcbX7CUFk61Ena4DF30=; b=Uw5ZRrvI0Ce13woBPLc8hvdIRE GDQ+Aqj+vEYPi52tdVO6/UXYhazd2JzJIyZldh96FgRQaFwy6T7iVRE0x7Jw1yUlt/5YFoaFcY0BF lCdhcdnwst9bgxjIpAWWArZWdUjG5yoSb/yTpecymkyr/z5QE7KnxOG3Lx6RtGzmP710=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9Vps-0001zY-7N; Thu, 07 Jul 2022 20:02:46 +0200 In-Reply-To: <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> (Brennan Vincent's message of "Thu, 7 Jul 2022 10:26:37 -0400") X-Now-Playing: Maeror Tri's _Mort Aux Vaches_: "(Mind) Alternation" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236402 Archived-At: Brennan Vincent writes: > I actually observed item itself being nil, not just (car item). Does the following simple change fix the problem, then? diff --git a/lisp/imenu.el b/lisp/imenu.el index 040e373fb4..dcd816cb7a 100644 --- a/lisp/imenu.el +++ b/lisp/imenu.el @@ -471,7 +471,7 @@ imenu--create-keymap (t (lambda () (interactive) (if cmd (funcall cmd item) item)))))) - alist))) + (seq-filter #'identity alist)))) (defun imenu--in-alist (str alist) "Check whether the string STR is contained in multi-level ALIST." -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no