From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56552: [PATCH] Make gnus display webp images inline Date: Thu, 14 Jul 2022 19:44:52 +0200 Message-ID: <87y1wv7fmz.fsf@gnus.org> References: <87mtdbswl2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17086"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56552@debbugs.gnu.org, Visuwesh To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 14 19:46:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC2vF-0004Ec-Ip for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 19:46:45 +0200 Original-Received: from localhost ([::1]:52368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC2vE-0000yx-97 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 13:46:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC2uY-0000yX-E8 for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 13:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oC2uY-000249-5p for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 13:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oC2uX-0004pF-Vs for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 13:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2022 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56552-submit@debbugs.gnu.org id=B56552.165782070310255 (code B ref 56552); Thu, 14 Jul 2022 17:46:01 +0000 Original-Received: (at 56552) by debbugs.gnu.org; 14 Jul 2022 17:45:03 +0000 Original-Received: from localhost ([127.0.0.1]:38800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oC2ta-0002ea-Jl for submit@debbugs.gnu.org; Thu, 14 Jul 2022 13:45:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oC2tZ-0002dj-8C for 56552@debbugs.gnu.org; Thu, 14 Jul 2022 13:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C4YhrWSc/wWKntAo9X2VNgym4GITZcmeIpnWY4FLwV4=; b=lTu7vR8NRFiNBVk08j8wIptE4T FGy1MUBfRDWvvptYL3U5l39LsEYb8Egyt8FcsWBxVhdiFwTkkbugVy1qyC7UkCHatN170sWxBfidX GvZLncAUpOFg/SIZHd3hV2vhr3l5YtVHr5nANV0Tjxdgkng5h8C6bRi9L3zD72z8SFpU=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC2tQ-0004ro-Mi; Thu, 14 Jul 2022 19:44:55 +0200 In-Reply-To: (Stefan Kangas's message of "Thu, 14 Jul 2022 06:42:44 -0700") X-Now-Playing: Heidi Berry's _Love_: "Lonely Heart" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237023 Archived-At: Stefan Kangas writes: >> `(("image/p?jpeg" >> mm-inline-image >> ,(lambda (handle) >> - (mm-valid-and-fit-image-p 'jpeg handle))) >> + (mm-valid-and-fit-image-p 'jpeg handle))) >> + ("image/webp" >> + mm-inline-image >> + ,(lambda (handle) >> + (mm-valid-and-fit-image-p 'webp handle))) >> ("image/png" >> mm-inline-image >> ,(lambda (handle) > > Maybe this comment belongs in a separate wishlist item, but why isn't > this all using the `image-file-name-regexp' function? I think this code is this way for historical reasons -- different image types were handled differently at one time (I think), but they now all call `mm-valid-and-fit-image-p'. So, yes, it should all be rewritten. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no