all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 56552@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
Subject: bug#56552: [PATCH] Make gnus display webp images inline
Date: Thu, 14 Jul 2022 19:44:52 +0200	[thread overview]
Message-ID: <87y1wv7fmz.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmmeSL8vuuPLA4ZevYYvOpeYv1pGZmp=r4e29T0qXmEQpA@mail.gmail.com> (Stefan Kangas's message of "Thu, 14 Jul 2022 06:42:44 -0700")

Stefan Kangas <stefan@marxist.se> writes:

>>    `(("image/p?jpeg"
>>       mm-inline-image
>>       ,(lambda (handle)
>> -       (mm-valid-and-fit-image-p 'jpeg handle)))
>> +        (mm-valid-and-fit-image-p 'jpeg handle)))
>> +    ("image/webp"
>> +     mm-inline-image
>> +     ,(lambda (handle)
>> +       (mm-valid-and-fit-image-p 'webp handle)))
>>      ("image/png"
>>       mm-inline-image
>>       ,(lambda (handle)
>
> Maybe this comment belongs in a separate wishlist item, but why isn't
> this all using the `image-file-name-regexp' function?

I think this code is this way for historical reasons -- different image
types were handled differently at one time (I think), but they now all
call `mm-valid-and-fit-image-p'.  So, yes, it should all be rewritten.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2022-07-14 17:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 12:33 bug#56552: [PATCH] Make gnus display webp images inline Visuwesh
2022-07-14 13:42 ` Stefan Kangas
2022-07-14 13:53   ` Visuwesh
2022-07-14 17:44   ` Lars Ingebrigtsen [this message]
2022-07-14 17:42 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1wv7fmz.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=56552@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.