From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akib Azmain Turja Newsgroups: gmane.emacs.devel Subject: Re: Supporting git-send-email/hg email in VC Date: Wed, 24 Aug 2022 20:43:41 +0600 Message-ID: <87y1vdaehu.fsf@disroot.org> References: <848rndq2i7.fsf@iki.fi> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Philip Kaluderdic To: Antoine Kalmbach Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 24 19:13:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQtwx-0009nC-2m for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 19:13:55 +0200 Original-Received: from localhost ([::1]:47558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQtww-0000Td-4c for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 13:13:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQttR-0003sG-Po for emacs-devel@gnu.org; Wed, 24 Aug 2022 13:10:17 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:52974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQttO-0000J3-M5 for emacs-devel@gnu.org; Wed, 24 Aug 2022 13:10:16 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id E798440078; Wed, 24 Aug 2022 19:10:10 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id tJVVGtlKjhXc; Wed, 24 Aug 2022 19:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1661360964; bh=UKSySNdKdLE5kCT3V7721fyO1i5WQ66rCRgV4qZoMPc=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=O9hXxEvk5OsvZQQYXTD5VBo3enr7d2fn1OH/guLfrQHNQ1M28tkcsW6fDDm14XfR5 qG0Jayh/mq7DlsosRKHswtkA+LpQRgnCjbMhqz9LJ2BZzqZ5cqKlokHUAQMk7+qRR4 iDpUUh4gK4+d7IRZY3cxbOJn1CfttF889BedjS7bXrGW5FmLPw6VGg89VcBK3xiSOD Erx+XaKqG6BAj/6Rs3WKoFGDXPGE3Agz6PSBpMMjzwCwjOIFY3mqy9UWj+lfn5XcSV LzbAQfTo17yhzgwdZcwF7HMmUus7gY3diDjy0OWEcE1f8DROXsZN/6XBiulzZ+mRaa 62DWoFEFJIo2A== In-Reply-To: <848rndq2i7.fsf@iki.fi> (Antoine Kalmbach's message of "Wed, 24 Aug 2022 14:56:00 +0300") Received-SPF: pass client-ip=178.21.23.139; envelope-from=akib@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294043 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Antoine Kalmbach writes: > Would it make sense for Emacs' VC to support emailing patches from > within Emacs? It kind of doesn't make sense that I can do mostly > everything in VC... but I have to jump to the command line (shell) to > use git-send-email. > > I was thinking there could be a command called 'vc-mail-commit' which > would in vc-dir-mode or vc-log-mode do the right thing and call git > format-patch and then compose a mail with the contents of the patch (or > the patch attached, depending on customization). > > The right thing would be in vc-dir-mode to prompt for a ref (branch, -1, > HEAD^, etc), in vc-log-mode it would be to compose a set of patches from > the marked commit(s), or prompt like in vc-dir-mode for a ref to send a > patch from a user-specified ref. > > Does such a feature make sense? I know sites like git-send-email.io[1] > say things like: > >> Warning! Some people think that they can get away with sending patches >> through some means other than git send-email, but you can't. Your >> patches will be broken and a nuisance to the maintainers whose inbox >> they land in. Follow the golden rule: just use git send-email. > > But I find that if and only if you use git-format-patch, the end result > is pretty much the same. To that end, I think if Emacs managed to > integrate with the different DVCS' email-based workflows, it would be > a great usability improvement. > > If people think this would be a useful feature, I can open a bug report > to track this and start working on it. The proposed reference > implementation for Git would be to (1) ask the user for a ref (2) call > git format-patch with that (3) compose a new message in Emacs, and set > the body of the message to be the output of git-format-patch (OR attach > the file) and (4) let the MUA take it from there. > > Alternatively, it would be possible to use a combination of with-editor > + git-send-email, but only if we should need ot abide by the "rule", > because to me there aren't many nuances beyond using the format > specified by git-format-patch with your own MUA vs. using > git-send-email. Or do I not know enough about the latter to not see the > missing pieces? > > [1] https://git-send-email.io/#step-3 I want this feature. Even better if I can integrate this with Gnus. =2D-=20 Akib Azmain Turja Find me on Mastodon at @akib@hostux.social. This message is signed by me with my GnuPG key. Its fingerprint is: 7001 8CE5 819F 17A3 BBA6 66AF E74F 0EFA 922A E7F5 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmMGOR0ACgkQVTX89U2I YWsarA/+KzQqWuRLrnz4vij1rM/aJ4CkD19x86rfeMPA7NQOdKwphnUbFoDrM/M7 FN+hxRoL3o6YfVGoPCSxxz5105A4ixqaOahtZOm7ozLIwhjM4dqSAuZk1lrbTEhe XgbkzOszeRmP7BogXn3kYY0Eb7sPVLoSaCvV6KYV9M1MVcAVofa97xBWnz0myEiu cYNyrg6q6/2ISdyB9I/j4izoZ/wQzSNEAzaDXv6PVn9CaE6X9jp0V0N3tVzh/AJP asdBjLQe/o71bMJxBhDAQ4Sj4bvDkDdNz8jVaNzHqun2hVInRDEOVwTije6Zx+4r nWt4XDqNQKAgCMc/gu0kA6s6vMUmqQnouZ/EZQ+cC33rdp5xnKHH/+dacXHzPHCT mtOoo76OImvVe438giEnJTpDG9DA8Bw0QjA77h/98+fX4+rE1SrCwyY4BHVGmyBC tB94eN99f7agusvy1CT+uyj1R3we2SeRKetiC5dPC/D9uRAvbnTeHWknu+LSO80+ kC3sXjYIMbdCqxTqIcKTRxiTFaN82u+jlsR0arbT3RaN7w1rE1Oou5qlq10ul1Vx oGqP2JsmKPAeuIPuMg+HxGWHRoeSI+ocxU805EZdEKZXQO9po0WIo8LLlGYCyZwB ymo2sL/xJiykvzArVuPhft//XEmJH9yoDfOVzs5AMhFU/0nrDQU= =tTvX -----END PGP SIGNATURE----- --=-=-=--