From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Tue, 04 Oct 2022 10:40:23 +0000 Message-ID: <87y1tvub1k.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <878rlw681a.fsf@gnus.org> <87r0zovbzr.fsf@posteo.net> <87mtacvag8.fsf@posteo.net> <83r0zow0nl.fsf@gnu.org> <87a66cukrs.fsf@posteo.net> <83bkqsvx18.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 57400@debbugs.gnu.org, ane@iki.fi To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 04 12:41:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1offMM-0002r4-Mg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 12:41:10 +0200 Original-Received: from localhost ([::1]:35430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1offML-0000C1-NI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 06:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offMF-0000Bk-At for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 06:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1offME-0002NI-Vz for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 06:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1offME-0001OV-FV for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 06:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.16648800355318 (code B ref 57400); Tue, 04 Oct 2022 10:41:02 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 4 Oct 2022 10:40:35 +0000 Original-Received: from localhost ([127.0.0.1]:52564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1offLn-0001Nh-GK for submit@debbugs.gnu.org; Tue, 04 Oct 2022 06:40:35 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:38639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1offLl-0001NR-Bh for 57400@debbugs.gnu.org; Tue, 04 Oct 2022 06:40:34 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CD5A2240028 for <57400@debbugs.gnu.org>; Tue, 4 Oct 2022 12:40:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1664880027; bh=gMr7IFnGnO80mpX1ULEn/ChY+LEPxU2Pqo4zERMCRl8=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=V+v4iRUaZJuSgKqlWWFuytYALVHuG0pYBSidbbCoCHqeF6IHD1GAx7FfwDGC7xDAR BEdEXCUZPmHARWaCoxjW9x9bHhp03tjPKNQfPTjya6lvp83pzYmpz5ZoGGrtMwQICY OE3/5hxeksOXMkdHZQzMJ/98FQy7Kc/rf6usGDEZB4nqdM0RFudLYuAQAFdZKnPyqc tjXZgofGeXU0xeVXhmy/n7VCldTO9xV9eTbkd3ktXU8y4SZrr2osXQLcyXosznzh+c wghXYmiSHE4iiBcz4aPRV+hJmjbBlQg7g/2hbF6hrFUDebatKP0fXj8VGH9RdYBh4q LAjBMC99VB1oA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MhZ3X3Xm9z6tnM; Tue, 4 Oct 2022 12:40:23 +0200 (CEST) In-Reply-To: <83bkqsvx18.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 04 Oct 2022 11:00:03 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244384 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 57400@debbugs.gnu.org, ane@iki.fi >> Date: Tue, 04 Oct 2022 07:10:15 +0000 >> >> Eli Zaretskii writes: >> >> >> + (compose-mail addressee >> >> + (or (plist-get patch :subject) >> >> + (concat >> >> + "Patch for " ;guess >> >> + (file-name-nondirectory >> >> + (directory-file-name >> >> + (vc-root-dir))))) >> >> + nil nil nil nil >> >> + `((exit-recursive-edit))) >> >> + (message-goto-body) >> > >> > compose-mail doesn't necessarily invoke message.el functions, so >> > message-goto-body is not necessarily appropriate here. >> >> Oh, I thought it was because `submit-emacs-patch' did the same. Again, >> do you have any suggestions what else could be done to keep this >> generic? > > Can you ask more specific questions? Are you looking for a generic > way of doing what message-goto-body does? Kind of, I would like to have some function that would place the point at the beginning of the message body, no matter what MUA is used. From what I see, the implicit assumption always is that a message is composed in a single buffer where the headers are written out at the beginning of the buffer, then there is some kind of to detect the end of the headers, followed by the body. But what if a MUA wants to use a separate buffer for the headers and the body, placing them in two separate windows? What if the headers aren't shown at all? If I want to handle the situation generically, it seems like I would have to take all the design decisions into consideration. > If so, would > rfc822-goto-eoh do the job? It doesn't seem to do the same, as in message-mode, it jumps to the beginning of the "--text follows this line--" line, not to the line after it.