From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59816: [PATCH]: bug#59816: 29.0.60; c++-ts-mode handles one-line comments badly Date: Mon, 05 Dec 2022 14:21:10 +0100 Message-ID: <87y1rmvveh.fsf@thornhill.no> References: <08257d6b-2426-bbdf-0ed4-edd161801ad6@gmail.com> <878rjmdnpa.fsf@thornhill.no> <83sfhu80o3.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="726"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casuri@gmail.com, 59816@debbugs.gnu.org, geza.herman@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 14:22:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2BQl-000AWy-CR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 14:22:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2BQE-0008GV-2s; Mon, 05 Dec 2022 08:22:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2BQ3-0008FM-97 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:22:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2BQ2-0007N7-Uh for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2BQ2-0000pX-Ig for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59816 X-GNU-PR-Package: emacs Original-Received: via spool by 59816-submit@debbugs.gnu.org id=B59816.16702464763161 (code B ref 59816); Mon, 05 Dec 2022 13:22:02 +0000 Original-Received: (at 59816) by debbugs.gnu.org; 5 Dec 2022 13:21:16 +0000 Original-Received: from localhost ([127.0.0.1]:35989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BPH-0000ov-Oo for submit@debbugs.gnu.org; Mon, 05 Dec 2022 08:21:16 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:28576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BPE-0000op-L5 for 59816@debbugs.gnu.org; Mon, 05 Dec 2022 08:21:14 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670246471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZSdsAa54msHihXoEQzN4ok4RfN8GRJvBmcfkjjaaVRg=; b=P5SRVlju3DoC2njQPPeYRFuhQGF+P4I1zwfpfeJ3tRUQsTNUBA8RbKmrbDoH8JPJdzVS12 u2Om4CiSdaNHOCULaCASLbm1ytuGVHa+DoBhqZZ7hcpgB/qDycr6/e34jLXJ7NJIk0YDIe jk/Ai/ElCheZhugZRXLSJ4x4qFFMKFJ+Sq5U9DRnAISNwBHhBmPcfyJ1iaWBVeIU5Q65Kn yc+ays4WAeZ9zqd8s8r95wUFtn187PduXz70PcnOEws4XqeWCNJ+hr0l3XAzXDdE0DRO6u axywfI9IoUJFhNqON2MXtIwahOZY8dSC6+fCJtwAhPotw6dMxm3ilPRfYh1l1w== In-Reply-To: <83sfhu80o3.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250022 Archived-At: Eli Zaretskii writes: >> From: Theodor Thornhill >> Cc: geza.herman@gmail.com, eliz@gnu.org >> Date: Mon, 05 Dec 2022 13:44:49 +0100 >>=20 >> You're right. This is my bad. This patch addresses it. What do you >> think, Eli? > > I'll defer to people who know more than I do about these modes. > Sure, added Yuan to CC. >> BTW - I see that many modes in general don't refer to their >> syntax-tables in their define-derived-mode form. Is that intentional? > > The ELisp manual says: > > -- Macro: define-derived-mode variant parent name docstring > keyword-args... body... > This macro defines VARIANT as a major mode command, using NAME as > the string form of the mode name. VARIANT and PARENT should be > unquoted symbols. > > The new command VARIANT is defined to call the function PARENT, > then override certain aspects of that parent mode: > > [...] > > =E2=80=A2 The new mode has its own syntax table, kept in the vari= able > =E2=80=98VARIANT-syntax-table=E2=80=99, unless you override thi= s using the > =E2=80=98:syntax-table=E2=80=99 keyword (see below). =E2=80=98= define-derived-mode=E2=80=99 > makes the parent mode=E2=80=99s syntax-table the parent of > =E2=80=98VARIANT-syntax-table=E2=80=99, unless the latter is al= ready set and > already has a parent different from the standard syntax table. > > So there's no need to mention it because it happens automatically. Right, thanks! Can you test this patch, Herman, and see if it works for you now? Theo