From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X Date: Wed, 07 Dec 2022 21:13:51 +0800 Message-ID: <87y1rjl5kg.fsf@yahoo.com> References: <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org> <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> <87fsdtnn8x.fsf@yahoo.com> <83r0xc7mf8.fsf@gnu.org> <87v8mon18x.fsf@yahoo.com> <83h6y87gj5.fsf@gnu.org> <87fsdsm3mp.fsf@yahoo.com> <83359r5qr5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19191"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 14:14:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2uGJ-0004iV-Ai for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 14:14:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2uFa-0005MN-7N; Wed, 07 Dec 2022 08:14:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2uFY-0005MA-Hw for emacs-devel@gnu.org; Wed, 07 Dec 2022 08:14:12 -0500 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2uFW-0004US-HM for emacs-devel@gnu.org; Wed, 07 Dec 2022 08:14:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670418845; bh=X/M9tbMBT19a8Xc3ssvNqdZCoPUu5P820KQH21yMCcQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=qg10ZJHkc+cSPAqFAq+zUypr31JZteUXJAXG1cgWcCt241Rsmsx/mP2zaGuw2E39TTw0l32TxCQAcJCVLAg4FDEH02GkW+sr947KyRH5w/MpI/Mzku+ir++WWGFbZ1opK2JtU4Yh6Dv/tzoxdnllpRS1qbRzs2jPPTeOc7Lemj9kD0yWJpXrWZAWqV3iFGVSz4Yz0xyhivgIe6NDVhyhRZHsfLgqKFzbHvhNye3+5vGsSWCwzfu5Juyim4Ngx9AgOjYCvq+buomOPxDRV4GbrUsL0r2WF2cAh84ld91w9CmR4W/yV1qtDrgRGJvbd0zY8Hw1SUBI9O0va8HmThqHsg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670418845; bh=wi2tyU/C4gVRGtV2LpGEdg9zkBusnoNLbU9+NUaIZlr=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PRzNRJl+wzcNMB2gvfxqkjvIwnbN22iR1gP/ScwFW0y9TF8cVpeB/98JI9oCPG/Qgih6Oiowu8k004d4qgL76MUnQRP/MPfNRNMYmUUSeRTxRMeDQTQz+ehU78uHFM6BwMxEXkxr7//OLv384ZfBKnUBVlw0r4dGy4b2/q7HU1cE3Yxbm9o38emZvWyHuIr5pTiCBAJ3qb4qnlK9c0Tdv1BM3GBI7a64mOJvxL5dwUy0lEH+ifzoYdoFTsNqCw3lDyoFzCTwNmF9CfZb3dclKL1GN0zyWHwzTQgIrmLRzp7zhmptbzjSf4PNiZNyxK4Uok8/lKyvVYji2ub0K5+new== X-YMail-OSG: 5y5VVLUVM1miZhRvz2LKYB.j3ERFenFcQlGxtf.PT7pP9c9.O_RfJLdmYKc6gPa 20ZI.knf7wd6NE240C2EKL1XlPEgbO.Uf4N4SDBSn9iGEOQxGM5rRVbWwIS7s6eReaffvVl5Up2L ZV9g3gT9ha92Xjsp0pV5D5sXIRZnWCraqINTEbFEegCtC5OBqjFU1Fq1W4dxC1WPepUCojdLMx50 mfZtq6vWwTyXO9aGnjkh_iOC7GBrQbluW6wXxTTYrwpu441np1LTzsXKJiaQ1RGmEA.bRmSBtmXn P0UYBaAn5_CJ8olv6hTc6qJ.jnFM96mY_.4AzYJ6u71ROltH988g8XXNMaTII3mVwsXxCkd_h0zM ZCrG6yCFiMcSh1qy9nWxSG3KtkQGo0Lax_PgT6Ncy4eeUOJM0WyP4LPKl_EG3SCLi.7D20DC9M1p cm2P9_oEdQQLEB_OZf1gyHQlOXb8PfLVq7imkjFWoH5mHtx5426PFFkQp_WPbClDLU3FZFayghQB 8GaWAJjAgBqIDaF2gIiWcYXatsUg31nGZOqw4MBvbxvugdlIvrnSGLHgiMAYBRA5gicCAuwOxBIK 6bXS_0qvSNd9xomadVXoH0P9I0gIb.BCUNtynqnBHaQgvyxXjdrMO8hrcIqTpkyh15lbfKTWPv8H Nnle4naKdLMU.Dc9jPvPboXZERqJ3pzB_4TPsYgwydm8nKF_rbsVMS3cABcUTF7x_vkbEwkbjGw1 VDF.1WHrsrZuvFjDcENXUC1e4Vhsjh9.Lyg4owPj49H6h2m78cfBEYibXluKbNWUlg9XzrX7gw_b AtAXCqBga5HGhFnCAKmJ0KlWlyIzI4.oteVv3ScIeA X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Wed, 7 Dec 2022 13:14:05 +0000 Original-Received: by hermes--production-sg3-b666c6484-7jgtw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 65fa4d99e115561c0481fbe949939b11; Wed, 07 Dec 2022 13:14:02 +0000 (UTC) In-Reply-To: <83359r5qr5.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Dec 2022 14:42:54 +0200") X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301012 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Wed, 07 Dec 2022 08:58:06 +0800 >> >> Eli Zaretskii writes: >> >> > It might, so I'd prefer not to risk such duplicate calls. It should be easy >> > to make sure it is called only once when dumping for unexec, and only once >> > in the pdumper build (both when dumping and when not dumping). >> >> Something like this? > > Without the "if (!initialized)" part, since in the pdumper build we > want it invoked both when dumping and when starting after dumping. So, just like this? Thanks; now comes the question of how to install this on the release branch without causing conflicts with master, as part of the change is already on master. diff --git a/src/emacs.c b/src/emacs.c index d8a2863fd9c..2d924da1cdb 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -1937,7 +1937,9 @@ main (int argc, char **argv) } init_alloc (); +#ifndef HAVE_UNEXEC init_bignum (); +#endif init_threads (); init_eval (); running_asynch_code = 0;