bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Benjamin Orthen]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

In lisp/progmodes/eglot.el:192,
"vscode-json-languageserver"
(https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
which causes eglot to fail to find the executable.

[-- Attachment #2: Type: text/html, Size: 336 bytes --]

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Brian Leung]

Benjamin Orthen <benjamin@orthen.net> writes:

> In lisp/progmodes/eglot.el:192,
> "vscode-json-languageserver"
> (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
> which causes eglot to fail to find the executable.

It's not a spelling error;
https://github.com/hrsh7th/vscode-langservers-extracted exposes an
executable with that name. If you happen to use Nix, the
nodePackages.vscode-langservers-extracted provides additional
executables for HTML, CSS, and more.

We could add vscode-json-languageserver as an additional executable to eglot-server-programs.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Eli Zaretskii]

> Date: Mon, 19 Dec 2022 11:13:32 +0100
> From: Benjamin Orthen <benjamin@orthen.net>
> 
> In lisp/progmodes/eglot.el:192,
> "vscode-json-languageserver"
> (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
> which causes eglot to fail to find the executable.

João, it looks like all the vscode-* servers have the same problem in
the eglot DB?

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Eli Zaretskii]

> Cc: 60198@debbugs.gnu.org
> From: Brian Leung <leungbk@posteo.net>
> Date: Mon, 19 Dec 2022 12:42:54 +0000
> 
> Benjamin Orthen <benjamin@orthen.net> writes:
> 
> > In lisp/progmodes/eglot.el:192,
> > "vscode-json-languageserver"
> > (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
> > which causes eglot to fail to find the executable.
> 
> It's not a spelling error;
> https://github.com/hrsh7th/vscode-langservers-extracted exposes an
> executable with that name. If you happen to use Nix, the
> nodePackages.vscode-langservers-extracted provides additional
> executables for HTML, CSS, and more.
> 
> We could add vscode-json-languageserver as an additional executable to eglot-server-programs.

Is the same true for the other 2 servers we have in
eglot-server-programs?

Thanks.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Benjamin Orthen]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Alright thanks, I wasn't aware of the extracted versions.

I still think vscode-json-languageserver should be included, as this is the "original" program and not everybody might know or use the extracted langservers you're quoting.

On December 19, 2022 1:42:54 PM GMT+01:00, Brian Leung <leungbk@posteo.net> wrote:
>Benjamin Orthen <benjamin@orthen.net> writes:
>
>> In lisp/progmodes/eglot.el:192,
>> "vscode-json-languageserver"
>> (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
>> which causes eglot to fail to find the executable.
>
>It's not a spelling error;
>https://github.com/hrsh7th/vscode-langservers-extracted exposes an
>executable with that name. If you happen to use Nix, the
>nodePackages.vscode-langservers-extracted provides additional
>executables for HTML, CSS, and more.
>
>We could add vscode-json-languageserver as an additional executable to eglot-server-programs.
>

[-- Attachment #2: Type: text/html, Size: 1517 bytes --]

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

That might be, Eli.  When people submit changes to the Eglot
eglot-server-programs, I rarely double-check to see if they actually
work.  As Brian points out, it does seem to work in some installations
of this language server.

Just as a data point, I myself almost always start my servers with
C-u M-x eglot and then proceed to find the right server using Emacs's
completion system. Even if the invocation is complicated, it will last
me through the session and  be available in my next session with
C-u M-x eglot M-p RET (because I use savehist-mode).

João

[-- Attachment #2: Type: text/html, Size: 740 bytes --]

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Brian Leung]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]


Benjamin Orthen <benjamin@orthen.net> writes:

> Alright thanks, I wasn't aware of the extracted versions.
>
> I still think vscode-json-languageserver should be included, as 
> this is the "original" program and not everybody might know
> or use the extracted langservers you're quoting.

OK, see attached for a patch. I added only 
vscode-json-languageserver since I could not find anything named 
vscode-{html,css}-languageserver on NPM. CCing João.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: vscode-json --]
[-- Type: text/x-patch, Size: 1209 bytes --]

From f38132183a3deb28458ce2747bb375912b73afd2 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@posteo.net>
Date: Mon, 19 Dec 2022 15:03:06 -0800
Subject: [PATCH] eglot.el: Add vscode-json-languageserver

* lisp/progmodes/eglot.el (eglot-server-programs): Add.
---
 lisp/progmodes/eglot.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index ce4ca4f3d92..0f1bfd0447d 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -190,6 +190,7 @@ eglot-server-programs
                                      '("pylsp" "pyls" ("pyright-langserver" "--stdio") "jedi-language-server")))
                                 ((js-json-mode json-mode json-ts-mode)
                                  . ,(eglot-alternatives '(("vscode-json-language-server" "--stdio")
+                                                          ("vscode-json-languageserver" "--stdio")
                                                           ("json-languageserver" "--stdio"))))
                                 ((js-mode js-ts-mode tsx-ts-mode typescript-ts-mode typescript-mode)
                                  . ("typescript-language-server" "--stdio"))
-- 
2.38.1

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Brian Leung]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 60198@debbugs.gnu.org
>> From: Brian Leung <leungbk@posteo.net>
>> Date: Mon, 19 Dec 2022 12:42:54 +0000
>> 
>> Benjamin Orthen <benjamin@orthen.net> writes:
>> 
>> > In lisp/progmodes/eglot.el:192,
>> > "vscode-json-languageserver"
>> > (https://www.npmjs.com/package/vscode-json-languageserver) is 
>> > spelled as "vscode-json-language-server",
>> > which causes eglot to fail to find the executable.
>> 
>> It's not a spelling error;
>> https://github.com/hrsh7th/vscode-langservers-extracted exposes 
>> an
>> executable with that name. If you happen to use Nix, the
>> nodePackages.vscode-langservers-extracted provides additional
>> executables for HTML, CSS, and more.
>> 
>> We could add vscode-json-languageserver as an additional 
>> executable to eglot-server-programs.
>
> Is the same true for the other 2 servers we have in
> eglot-server-programs?
>
> Thanks.

Yes, I've used those other two servers before via Eglot with no 
further modifications.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

OK with me.  Are we sure that we can't just have one of them?  Maybe
those other distributions which create the "language-server" variety
_also_ create the "languageserver" version? Anyway, again, looks
ok to me, but let's try not to get too slippery on this slope.
Sometimes a misspelling is just a misspelling and we shouldn't
help perpetuate it.

João

[-- Attachment #2: Type: text/html, Size: 511 bytes --]

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Eli Zaretskii]

> From: Brian Leung <leungbk@posteo.net>
> Cc: benjamin@orthen.net, 60198@debbugs.gnu.org
> Date: Mon, 19 Dec 2022 23:07:51 +0000
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Cc: 60198@debbugs.gnu.org
> >> From: Brian Leung <leungbk@posteo.net>
> >> Date: Mon, 19 Dec 2022 12:42:54 +0000
> >> 
> >> Benjamin Orthen <benjamin@orthen.net> writes:
> >> 
> >> > In lisp/progmodes/eglot.el:192,
> >> > "vscode-json-languageserver"
> >> > (https://www.npmjs.com/package/vscode-json-languageserver) is 
> >> > spelled as "vscode-json-language-server",
> >> > which causes eglot to fail to find the executable.
> >> 
> >> It's not a spelling error;
> >> https://github.com/hrsh7th/vscode-langservers-extracted exposes 
> >> an
> >> executable with that name. If you happen to use Nix, the
> >> nodePackages.vscode-langservers-extracted provides additional
> >> executables for HTML, CSS, and more.
> >> 
> >> We could add vscode-json-languageserver as an additional 
> >> executable to eglot-server-programs.
> >
> > Is the same true for the other 2 servers we have in
> > eglot-server-programs?
> >
> > Thanks.
> 
> Yes, I've used those other two servers before via Eglot with no 
> further modifications.

I'm not sure I understand the answer.  I was asking whether the other
two also have two varieties.  If they do, I think we want to have both
in the DB.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Brian Leung]

Eli Zaretskii <eliz@gnu.org> writes:

> I'm not sure I understand the answer.  I was asking whether the 
> other
> two also have two varieties.  If they do, I think we want to 
> have both
> in the DB.

I don't think the others have vscode-{html,css}languageserver 
variants:

https://www.npmjs.com/search?q=vscode%20languageserver

You will find on that page the NPM packages 
vscode-{css,html}-languageserver-bin, but those are already 
accounted for in Eglot, via the executables named 
{css,html}-languageserver.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Brian Leung]

João Távora <joaotavora@gmail.com> writes:

> OK with me.  Are we sure that we can't just have one of them? 
> Maybe
> those other distributions which create the "language-server" 
> variety 
> _also_ create the "languageserver" version? Anyway, again, looks
> ok to me, but let's try not to get too slippery on this slope.
> Sometimes a misspelling is just a misspelling and we shouldn't
> help perpetuate it.
>
> João

See 
https://github.com/nixos/nixpkgs/blob/6844c91781fdad8ad523b77ec9d1f35ff407a8e6/pkgs/development/node-packages/node-packages.json#L383-L387.

It appears that there are no executables named 
vscode-{css,html}-languageserver, so the only way of accessing 
those corresponding executables (at least in Nix) is via 
nodePackages.vscode-langservers-extracted, which provides 
vscode-{css,html,json}-language-server. Meanwhile, 
vscode-{css,html}-languageserver-bin are already accounted for in 
eglot-server-programs via the executables 
{css,html}-languageserver.

So I think we should keep support for the "language-server" 
variants as well.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Eli Zaretskii]

> Cc: Benjamin Orthen <benjamin@orthen.net>, 60198@debbugs.gnu.org
> From: Brian Leung <leungbk@posteo.net>
> Date: Tue, 20 Dec 2022 10:25:14 +0000
> 
> 
> João Távora <joaotavora@gmail.com> writes:
> 
> > OK with me.  Are we sure that we can't just have one of them? 
> > Maybe
> > those other distributions which create the "language-server" 
> > variety 
> > _also_ create the "languageserver" version? Anyway, again, looks
> > ok to me, but let's try not to get too slippery on this slope.
> > Sometimes a misspelling is just a misspelling and we shouldn't
> > help perpetuate it.
> >
> > João
> 
> See 
> https://github.com/nixos/nixpkgs/blob/6844c91781fdad8ad523b77ec9d1f35ff407a8e6/pkgs/development/node-packages/node-packages.json#L383-L387.
> 
> It appears that there are no executables named 
> vscode-{css,html}-languageserver, so the only way of accessing 
> those corresponding executables (at least in Nix) is via 
> nodePackages.vscode-langservers-extracted, which provides 
> vscode-{css,html,json}-language-server. Meanwhile, 
> vscode-{css,html}-languageserver-bin are already accounted for in 
> eglot-server-programs via the executables 
> {css,html}-languageserver.
> 
> So I think we should keep support for the "language-server" 
> variants as well.

Thanks, so I've now installed your patch on the emacs-29 branch, and
I'm closing this bug.

bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, so I've now installed your patch on the emacs-29 branch, and
> I'm closing this bug.

This was accidentally left open, so I'm closing it now.