From: Augusto Stoffel <arstoffel@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 61532@debbugs.gnu.org, "Theodor Thornhill" <theo@thornhill.no>,
"João Távora" <joaotavora@gmail.com>
Subject: bug#61532: 30.0.50; [PATCH]: Make completions without sortText fall to back of the list
Date: Tue, 21 Feb 2023 09:24:42 +0100 [thread overview]
Message-ID: <87y1orfmt1.fsf@gmail.com> (raw)
In-Reply-To: <jwv3571qni7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 19 Feb 2023 17:56:06 -0500")
On Sun, 19 Feb 2023 at 17:56, Stefan Monnier wrote:
>> Anyway, this boils down to a limitation of LSP, that it doesn't report on
>> what kind of matching style it uses for textDocument/completion.
>
> It's not just "matching style". It's that it's designed under the
> premise that all the control is on the LSP server side, and the client
> (editor) side just provides a "dumb UI".
This not quite true, actually. I once proposed a mechanism for the
server to request the editor to "act dumb", but the idea didn't stick.
Also, I gather from the discussion that VS Code does its own sorting and
filterting too.
https://github.com/microsoft/language-server-protocol/issues/898
> A better API is probably harder to design (e.g. you need to define what
> is a "matching style", for one), admittedly.
I think if the server returns all possible candidates with no filtering,
then Emacs would be happy, right? Apparently some servers do that, as
claimed in the above discussion. Of course there is one big issue with
this approach, namely the response can be quite big and slow down both
ends of the communication channel.
next prev parent reply other threads:[~2023-02-21 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 14:52 bug#61532: 30.0.50; [PATCH]: Make completions without sortText fall to back of the list Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 22:18 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 11:13 ` João Távora
2023-02-19 16:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 18:19 ` João Távora
2023-02-19 18:43 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 18:48 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 22:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 23:39 ` João Távora
2023-02-19 23:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 18:52 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 22:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 8:24 ` Augusto Stoffel [this message]
2023-02-21 8:24 ` Augusto Stoffel
2023-02-21 12:47 ` João Távora
2023-02-21 14:08 ` Augusto Stoffel
2023-02-21 14:28 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1orfmt1.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=61532@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.