From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Fri, 17 Mar 2023 18:22:14 +0100 Message-ID: <87y1nvgunt.fsf@miha-pc> References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> <87ttykj45i.fsf@gmx.de> <878rfw51mh.fsf@gmail.com> <87pm98iw1e.fsf@gmx.de> <87fsa43f36.fsf@gmail.com> <87sfe4eh09.fsf@gmx.de> <87wn3g1ssd.fsf@gmail.com> <87zg8co0n0.fsf@miha-pc> <875yaziax4.fsf@miha-pc> <83y1nvcokf.fsf@gnu.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="434"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, joaotavora@gmail.com, 62194@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 18:18:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdDid-000A1v-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 18:18:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdDiO-0006RD-6Y; Fri, 17 Mar 2023 13:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDiM-0006Pu-MK for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 13:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdDiM-0008Qe-D5 for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 13:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdDiM-0000j9-3p for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 13:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.16790734502742 (code B ref 62194); Fri, 17 Mar 2023 17:18:02 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 17 Mar 2023 17:17:30 +0000 Original-Received: from localhost ([127.0.0.1]:45531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdDhp-0000i9-V1 for submit@debbugs.gnu.org; Fri, 17 Mar 2023 13:17:30 -0400 Original-Received: from mail.kamnitnik.top ([209.250.245.214]:55148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdDhn-0000hx-DQ for 62194@debbugs.gnu.org; Fri, 17 Mar 2023 13:17:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1679073444; bh=S+YNxvEJR6xaDX+yu1Lb12AFZ7VYfSjrHM+2Fn1827k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iktY5Kqb8lUa/9XiINNO21yOkgHMogBGemP2on+pF5HPuOf8gZQDzLO/b8GPuLzHM 1jlHvmFaCgDa5Xvu1F4zh3DScig0YDBVsuX8uKwxAqryuN5Nmc4blQPm5SdPa9kXBL DOZtflGBwOTj7AmtRlL6QWO3GugLsNfbvkXm95Q4yWnKrYqRmL14cpOvFrqjamRW5G P7mpc4jRFOVzunmo5bGB+mLdwz8X2jefxqqM6XDzjk+hzU9ZedeSGU4GZjv/HpnGGt 0cfKUwAJOJg/GsNHYIWB+zj6stcOkc57GHff/EOl6mIPV9CydBAmP/lhVUlrLx1a69 5AnfGki/lql8Q== In-Reply-To: <83y1nvcokf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258096 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> Cc: Michael Albinus , 62194@debbugs.gnu.org >> Date: Fri, 17 Mar 2023 17:45:43 +0100 >> From: miha--- via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Though I do think that if a function that calls a-p-o with >> JUST-THIS-ONE=3Dnil isn't internal, it should mention that it can run >> timers in its doc string. > > I don't see why: timers can run in Emacs almost anywhere, so > mentioning that in doc strings of every function makes little sense. I'm not completely sure how timers work, but >> But here we are talking about 'expand-file-name' and other functions >> from tramp-sh-file-name-handler. For these, I disagree that we want them >> to accept output from other processes and call their filters. >> 'expand-file-name' and others are used often and, for most of the >> existence of Emacs, they did not call proc filters. I think it's >> dangerous to have them do it now. > > Process filters can be also called at any time, because they basically > depend on when the output from a subprocess arrives. Why would you > want that to stop while Emacs processes expand-file-name? From=20'(elisp) Output from Processes': Output from a subprocess can arrive only while Emacs is waiting: when reading terminal input, in =E2=80=98sit-for=E2=80=99 and =E2=80=98sleep-for= =E2=80=99, in =E2=80=98accept-process-output=E2=80=99, and in functions which send data t= o processes. From=20my understanding of process.c, wait_reading_process_output normally needs to be in the call stack in order for process filters to run. >> 'expand-file-name' is synchronous, therefore tramp has to make it use >> accept-process-filter (tell me if there's another way). It can use it in >> roughly two ways: with JUST-THIS-ONE=3Dt or JUST-THIS-ONE=3Dnil. In the >> first case, we hit the eglot-over-ssh freeze problem and in the second >> case, we'll have 'expand-file-name' call timers and process filters, >> which I explained above why I don't like. > > I think you should teach yourself to like that. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmQUocYTHG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP1RFEACVkaaS8EGmHHr0752kkUj5u7Qt5QGG oHqKWHshlzpJxiAYJFxWu7i60KQ4ZXV5sWP68/nbjvDU8swnjK090dIQ1/iKwSWL zdVS4RxZIydgQ7mUUXUvZqu8VDgFjOLhOe4ZaaYHLqhQEg26u/LoIu1V2aAuCmHw BJl3RGIMCEelx4i5eVTbK7o4Ti0hkdhdK5AIyGzXhRoB0pATbaPzOakBVQFYzyZG b363kyV2QN0OEiDcIBieZtVJT7yUYQK/EvFZFNvvA7oqWKdH4aPXZTHHlm6TFpn6 hPWNVXWNpmokTTfz3CE2s1AGJX0XZWptSFSyRCjnouEubWeFdenuWWlJ8celx2/6 LxkYJt360GAqHzfohKty3vmDk7n/2i/JuWgTFGtBeEn47e4V1txN2VD2DrviUbdp GmISi4TlFHjhGQt6Ladwe65TT5VPWhRy9es/HC+fHyuXwLSfdMSRxlqNVHFydJvo xyGzJZ6JxdM4EDdc6tifzEWw51wW6AsEAttBDaPJ4DIIf0IMqzJKI2r73Jj1oAua HhdBzPqIvbbC1ealnZ/lvSgirAoDoQwrNz6+R1pfMdoq/+niLCBxf5zf7OH+0wTk lQgqis2qPGNtME6O+rszgnZdKq+C6B7E8f5GLKjwNbRanXKfLwAJjPTA7h3svkLD yI0mAQf7ZK0UvA== =QZDU -----END PGP SIGNATURE----- --=-=-=--