From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Request to add Package to GNU ELPA Date: Fri, 07 Apr 2023 07:23:02 +0000 Message-ID: <87y1n417hl.fsf@posteo.net> References: <87tty24ap2.fsf@bernoul.li> <87wn2y5em5.fsf@posteo.net> <87r0t44zbx.fsf@bernoul.li> <87sfde7lh4.fsf@posteo.net> <87lej6ju1m.fsf@bernoul.li> <875yaayyly.fsf@posteo.net> <87bkk2xcjz.fsf@posteo.net> <87pm8hf1z0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21279"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jonas Bernoulli , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 07 09:24:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkgSH-0005JE-8I for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Apr 2023 09:24:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkgRH-0000Fs-4m; Fri, 07 Apr 2023 03:23:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkgRB-0000FQ-Ka for emacs-devel@gnu.org; Fri, 07 Apr 2023 03:23:10 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkgR8-0001pX-NG for emacs-devel@gnu.org; Fri, 07 Apr 2023 03:23:09 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 11FE32405AA for ; Fri, 7 Apr 2023 09:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1680852184; bh=WD5/RfWrmf0n66IXb/cmdolGu3KW21Dd48JW9ePcn0U=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Ig6CVt+fvyOxYgmXsV0ADyrwSQ/lvuhEE1Y77jYGP3CbwqMTAnLR9CW+ZSSJsVEfs IXr3l+pk6NhpgEV3L6CmMGS3h4C/6aNXxbsdS4zzLcLvhdkTgISJ2T3LXwlmNj/L50 krBCEkxfs1ZarRQUnEOGGOuJXaubB7wz4EFZAptj/6p834t8yFr27NnSPLLnv4a+od CLVjh+Z7xZZFeTSwHUSydA2KS3BUVGmqiPyyLE0FxoKsaaDOYJU1i94LyJQ5tvQFsj LjxiLCsaRPqhVKAx7Sgj51622GIwKPluG2s7WCSiv+Jqk1dU75GVZGyhITSaPgs+BJ IzU9XE4kmcqKA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pt8wR1hFfz9rxF; Fri, 7 Apr 2023 09:23:03 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Thu, 06 Apr 2023 17:36:22 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305155 Archived-At: Stefan Monnier writes: >> +;; Package-Requires: ((emacs "26.1") (compat "29.1.0.0")) > > [ I'm curious which definitions of `compat` this uses. ] Those should be - file-name-concat - length> - with-suppressed-warnings - named-let - length=3D - ensure-list - macroexp-file-name - dlet Do you think it is worth mentioning them? >> @@ -1208,10 +1214,13 @@ package-buffer-info >> :kind 'single >> :url website >> :keywords keywords >> - :maintainer >> + :maintainer (lm-maintainer) >> ;; For backward compatibility, use a single string if there's on= ly >> ;; one maintainer (the most common case). >> - (let ((maints (lm-maintainers))) (if (cdr maints) maints (car ma= ints))) >> + (if (fboundp 'lm-maintainers) >> + (let ((maints (lm-maintainers))) >> + (if (cdr maints) maints (car maints))) >> + (lm-maintainer)) >> :authors (lm-authors))))) > > Hmm... isn't the `(lm-maintainer)` right after `:maintainer` erroneous? Yes, that was a typo. > [ BTW, I think Jonas has another change pending for this code. ] > >> (when news >> - (insert "\n" (make-separator-line) "\n" >> - (propertize "* News" 'face 'package-help-section-name) >> + (newline) >> + (when (fboundp 'make-separator-line) >> + (insert (make-separator-line)) >> + (newline)) >> + (insert (propertize "* News" 'face 'package-help-section-name) >> "\n\n") >> (insert-file-contents news)) > > Why not just replace (make-separator-line) with > (if (fboundp 'make-separator-line) (make-separator-line) "")? I believe what I had in mind was to avoid formatting issues when `make-separator-line' was not available. I'll check again. > `newline` is a command and I think it's preferable not to use it > from ELisp. Oops, right. >> @@ -4571,8 +4581,11 @@ package-report-bug >> (dolist (ent (get (cdr group) 'custom-group)) >> (when (and (custom-variable-p (car ent)) >> (boundp (car ent)) >> - (not (eq (custom--standard-value (car ent)) >> - (default-toplevel-value (car ent)))) >> + (not (eq >> + ;; We are not using `custom--standard-value' >> + ;; to retain compatibility for Emacs 27. >> + (eval (car (get (car ent) 'standard-value)) t) >> + (default-toplevel-value (car ent)))) > > I'd use > > (if (fboundp 'custom--standard-value) ;; Emacs=E2=89=A527 > (custom--standard-value (car ent)) > (eval (car (get (car ent) 'standard-value)) t)) > > so the code "speaks for itself". Good point. --=20 Philip Kaludercic