From: Robert Pluim <rpluim@gmail.com>
To: "Jakub Ječmínek" <jecminek.k@gmail.com>
Cc: 64205@debbugs.gnu.org
Subject: bug#64205: Fix missing border cell when using orgtbl-to-table.el function
Date: Wed, 21 Jun 2023 14:45:59 +0200 [thread overview]
Message-ID: <87y1kdf0fs.fsf@gmail.com> (raw)
In-Reply-To: <CAFBiodLywYt7h+rdpVZT00eN80sPftcVEzOfjopX+v_-YUUjYQ@mail.gmail.com> ("Jakub Ječmínek"'s message of "Tue, 20 Jun 2023 23:57:35 +0200")
>>>>> On Tue, 20 Jun 2023 23:57:35 +0200, Jakub Ječmínek <jecminek.k@gmail.com> said:
Jakub> Previously used buffer-size function is (1- (point-max)) which means
Jakub> that last cell border was omitted.
Jakub> ---
Jakub> lisp/org/org-table.el | 2 +-
Jakub> 1 file changed, 1 insertion(+), 1 deletion(-)
Jakub> diff --git a/lisp/org/org-table.el b/lisp/org/org-table.el
Jakub> index 42f234790c5..9d3507e34b7 100644
Jakub> --- a/lisp/org/org-table.el
Jakub> +++ b/lisp/org/org-table.el
Jakub> @@ -6134,7 +6134,7 @@ supported."
Jakub> (org-table-align)
Jakub> (replace-regexp-in-string
Jakub> "-|" "-+"
Jakub> - (replace-regexp-in-string "|-" "+-" (buffer-substring 1 (buffer-size))))))
Jakub> + (replace-regexp-in-string "|-" "+-" (buffer-substring 1 (point-max))))))
Thatʼs just (buffer-string).
For bonus points, rewrite it to do the replacement in the temp buffer,
and then return (buffer-string), itʼs likely to be much faster (and
will generate less garbage).
Robert
--
next prev parent reply other threads:[~2023-06-21 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 21:57 bug#64205: Fix missing border cell when using orgtbl-to-table.el function Jakub Ječmínek
2023-06-21 12:45 ` Robert Pluim [this message]
2023-06-21 14:08 ` bug#64205: Fix missing cell border " Jakub Ječmínek
2023-06-21 15:24 ` Robert Pluim
2023-06-21 15:42 ` Jakub Ječmínek
[not found] ` <CAFBiodLYe+98=dYnvYCqxW0yY1feR8t_OKEH9VLUYXvLRXpEAA@mail.gmail.com>
2023-06-22 14:38 ` Robert Pluim
2023-06-22 15:15 ` Eli Zaretskii
2023-06-22 15:43 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1kdf0fs.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=64205@debbugs.gnu.org \
--cc=jecminek.k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.