From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon. Date: Wed, 26 Jul 2023 14:36:58 +0200 Message-ID: <87y1j2n91x.fsf@gmail.com> References: <877cqpsnct.fsf@trop.in> <83fs5dsd0g.fsf@gnu.org> <87zg3kk3jw.fsf@trop.in> <837cqoqjy7.fsf@gnu.org> <379c4b8a-db49-06b3-f313-91e550c8c14c@gutov.dev> <87y1j4jego.fsf@trop.in> <83jzuoozn0.fsf@gnu.org> <5a944e55-1c49-35d0-e554-eaf7ca42df7e@gutov.dev> <837cqnq48p.fsf@gnu.org> <87v8e74xm2.fsf@gmx.de> <831qgvpzpu.fsf@gnu.org> <87r0ov40gv.fsf@gmx.de> <83tttqorcv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13070"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus , dmitry@gutov.dev, andrew@trop.in, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 26 15:12:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOeJ7-0003AU-Dh for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Jul 2023 15:12:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOdlN-000358-BL; Wed, 26 Jul 2023 08:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOdlL-00034z-JU for emacs-devel@gnu.org; Wed, 26 Jul 2023 08:37:07 -0400 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOdlI-0005AJ-5w; Wed, 26 Jul 2023 08:37:07 -0400 Original-Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fc0aecf15bso68352105e9.1; Wed, 26 Jul 2023 05:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690375021; x=1690979821; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+LZj1JU5YR9A5RPFFx15fgzNVUcKpSbxMvKAzqp8RH4=; b=aWdgxt42uC/OmTrwOFqh5bcOLL9QvtuiE7K3vnZXMUO6SJT4aezaOnDkrLCsD9UxjP 1feIe5QomRAei/OS2z0JuamjRs23lClcQoGjG0pQTMyXY6kn+LpKoPJ7GTXsjAtjnp9G DMZWptYFpi4QM7hnGgZ52TxGMKGSb3awdHWAjkY0axPDMp7Uyp1Fgdev5xMvwccl+tOi aj8eC2wkiIpahx/hZNQoEAhfzEfV8hTeKQYq9EcJCn192QaDB09f1icFpbGLa/0YT1Tl olqqKQGWW0YgtYz9HvIzmYQMLxUdDHERrxNKlDD7ZaLEkzqjty1EGFiKlD47JYrdO3NZ jm9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690375021; x=1690979821; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+LZj1JU5YR9A5RPFFx15fgzNVUcKpSbxMvKAzqp8RH4=; b=fEEs84Dx920FsmeWx7DRHzI8egNCYJgdZq6q9LaJHHdKSpci9CkOjyIxczxEaCBn3q yxaclOdZS4RYNjsOOHG/Ani+K3QY0e1GXjYBIXyl/0XQgtTB+GaZQomvtwncDE3E9guB VdlO+j4bu/+5voz9dKMF0nYzHdW1hLB8HaaHLJo/QuC77WfWx3E6Xv33vECcZcezCVWq aP9hnl0VWjrQVTtixWQYJYR9HEtIXcJ6+jsiCAn4C0Q0DXwnnEbLv8LDKFZ+Q5CXmstb BuhEEZdES0fY6mYemtyjtRZLslSc7BAyGfxPudKVptM/ZKQaQYxWBsf1tdmwk+LCd4+x Otyw== X-Gm-Message-State: ABy/qLYA5Qq+qrpnMeRzIabx8hvwDh64sddi/n9u/fNt8AiaaCHGUgxU fiYovl/nBIdEN7wx705022GyNsDuRh5CdAOy X-Google-Smtp-Source: APBJJlE6a1HsnufFff5HSRJ8N9GUOMfCSYND6BYacFHB/xiRYZW1RpU1LsQ1KPfv8Oo4fCooKWzvwQ== X-Received: by 2002:a05:6000:1a4f:b0:306:2e62:8d2e with SMTP id t15-20020a0560001a4f00b003062e628d2emr1219928wry.1.1690375021210; Wed, 26 Jul 2023 05:37:01 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id v1-20020a5d6781000000b0031434c08bb7sm19632417wru.105.2023.07.26.05.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 05:37:00 -0700 (PDT) In-Reply-To: <83tttqorcv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Jul 2023 14:16:16 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=orontee@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308116 Archived-At: Eli Zaretskii writes: >> From: Michael Albinus >> Cc: dmitry@gutov.dev, andrew@trop.in, emacs-devel@gnu.org >> Date: Wed, 26 Jul 2023 09:05:04 +0200 >> >> Eli Zaretskii writes: >> >> >> As always with relative file names: the caller is responsible to use a >> >> proper default-directory. What else? >> > >> > Wait a minute. The icon's file is not processed by Emacs, right? We >> > pass it to an external program/library/service, right? >> >> We pass it to an external service via a D-Bus call. > > In that case, we _definitely_ must call expand-file-name, and using > relative file names without that is asking for trouble. Why not try to be compliant with the called API? According to the Desktop Notification specification the Notify method support image path being file URIs or in a freedesktop.org-compliant icon theme (see https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#icons-and-images). Being able to specify an icon with its name name according to Icon Naming Specification (see https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html) is useful since file path vary depending on the OS! -- Matthias