From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: Changes to make in elpa-packages file for nongnu elpa Date: Tue, 08 Aug 2023 06:17:52 +0000 Message-ID: <87y1im9h5l.fsf@posteo.net> References: <87r0oftgye.fsf@posteo.net> <87350vt1wz.fsf@posteo.net> <871qgen1ln.fsf@posteo.net> <87edke4mou.fsf@posteo.net> <87wmy6kuan.fsf@posteo.net> <87wmy6w070.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8184"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 08 08:35:15 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTGJG-0001vc-L4 for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Aug 2023 08:35:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTGIc-0001NQ-4X; Tue, 08 Aug 2023 02:34:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTGIT-0001Mq-CR for emacs-devel@gnu.org; Tue, 08 Aug 2023 02:34:25 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTGIQ-00008I-N5 for emacs-devel@gnu.org; Tue, 08 Aug 2023 02:34:25 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CE0D4240106 for ; Tue, 8 Aug 2023 08:34:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1691476459; bh=z+2wEVt8AZb39zaoWz1958pG6A5aqZqVYp17innQud8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=mX2RGBbcgRRrXc5pYJ3M4aN4VrQMiA0QstxOZE9iWyuRzn3jRyEEauEf5IiV3rz6w SUzvsJiJr//l1Naai1slIira/wVHNTrffG3whuykkyKmSafqOzg742LWdYyaOTPiHz vNEQ7ns65T2Dt5yuQ2ZjJJdkfBroAIkbqVMHIJvZtGR81sRpXu6j3pnhFnmuWFy1UN uQDoc5bdC0e9nn86bfZE3lWNluGfnllk3rGZyXJsS5wbUJJNgIzJb79rfEMv6JLZKf Nz1sr89Vx8Y22nf+01iy5H+AByvjg7gq+WFjl40zW1OLeKVbP/szKXZiW5d3pcgiq/ ZMpL8RPxjZjSg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RKk1N3zmpz9rxb; Tue, 8 Aug 2023 08:34:16 +0200 (CEST) In-reply-to: <87wmy6w070.fsf@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=thievol@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308435 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Philip Kaludercic writes: > Thierry Volpiatto writes: > >> Hello Philip, >> >> Philip Kaludercic writes: >> >>> Thierry Volpiatto writes: >>> >>>> Philip Kaludercic writes: >>>> >>>>> Thierry Volpiatto writes: >>>>> >>>>>> I see that Helm installation from nongnu elpa doesn't include >>>>>> emacs-helm.sh script, would it be possible to modify this? >>>>>> >>>>>> diff --git a/elpa-packages b/elpa-packages >>>>>> index 77d7a5409e..0923724b62 100644 >>>>>> --- a/elpa-packages >>>>>> +++ b/elpa-packages >>>>>> @@ -312,11 +312,11 @@ >>>>>> :ignored-files "COPYING") >>>>>>=20=20=20=20=20=20=20=20=20=20 >>>>>> (helm :url "https://github.com/emacs-helm/helm" >>>>>> - :ignored-files ("images" "Cask" "Makefile" "emacs-helm.sh= " "helm-core.el" "helm.el" >>>>>> + :ignored-files ("images" "Makefile" "helm-core.el" "helm.= el" >>>>>> "helm-lib.el" "helm-source.el" "helm-multi-match.el")) >>>>>>=20=20=20=20=20=20=20=20=20=20 >>>>>> (helm-core :url "https://github.com/emacs-helm/helm" >>>>>> - :ignored-files ("images" "Cask" "Makefile" "emacs-helm.sh= " "helm-adaptive.el" >>>>>> + :ignored-files ("images" "Makefile" "emacs-helm.sh" "helm= -adaptive.el" >>>>>> "helm-bookmark.el" "helm-buffers.el" "helm-color.el" "h= elm-comint.el" >>>>>> "helm-command.el" "helm-config.el" "helm-dabbrev.el" "h= elm-easymenu.el" >>>>>> "helm-elisp.el" "helm-elisp-package.el" "helm-epa.el" "= helm-eshell.el" >>>>> >>>>> There shouldn't be any issue in applying this patch, but could you >>>>> explain the propose of this script? >>>> >>>> It is used specially for reproducing bugs in a clean environment, see = it >>>> as emacs -Q for Emacs when reporting bugs. This script starts Emacs -Q >>>> with only Helm loaded, this ensure the bug if one comes from Helm and >>>> not another package. This is important especially nowaday people are >>>> using "Emacs distribution" with the world list of packages installed. >>>> Apart that the script is useful to quickly launch Emacs with helm, one >>>> can use it from the Helm directory or symlinked to e.g. ~/bin.=20 >>> >>> I see. In that case is there any reason you implement this as a shell >>> script? >> >> Well when I wrote the script, packages where not existing and from >> outside emacs it is actually the only way to run a package isolated. >> >>> (It might be interesting to provide something like this for >>> package.el, to test packages in a generic way.) >> >> Yes, this would be interesting, it would be something like this: >> >> Emacs -Q >> M-x > packages nuisances> > > I was actually thinking of a command like > > M-x package-isolate RET foo,bar,baz RET Then you want completion on packages and return a list of packages, you can involve helm without requiring it by using completing-read if helm-mode is enabled otherwise fallback to completing-read-multiple. You will have to let-bound (and declare it on top of your file) helm-comp-read-use-marked. Example from mu4e: (cond ((bound-and-true-p helm-mode) ;; tweaks for "helm"; it's not nice to have to special-case for ;; completion frameworks, but this has been supported for while. ;; basically, with helm, helm-comp-read-use-marked + completing-read ;; is preferred over completing-read-multiple (let ((helm-comp-read-use-marked t)) (completing-read prompt candidates))) (multi (completing-read-multiple prompt candidates)) (t (completing-read prompt candidates))) > and a new instance of Emacs using -Q is spun up, Yes much better. > with all the packages you have listed loaded, and nothing > else... Sounds like a fun little weekend project ;^) Yes, nice. >> Apart requiring a package just for the faces no, font-lock family >> doesn't provide :background faces. > > I wasn't thinking just of font-lock, you could pick any face, > eg. wfnames-modified could inherit from diff-refine-changed. Yes, but I will have to require diff, right? > That way themes don't have to add extra support, and the package looks > more "native" without any additional effort. Of course that would be nice. >>> "Provide filename completion in wfnames buffer." >>> (let ((beg (line-beginning-position)) >>> (end (point))) >>> + ;; Does it make sense to extend beyond END to allow completing >>> + ;; file names mid-string? >> >> This one for now I don't know, I transformed your comment with a FIXME. > > That is fine, this is just a general thing I wonder about with CAP > functions. So yes, as explained in previous post it is what we want, i.e. get the completion of the part of the line from bol to point. > I am totally indifferent, they expand to almost the same code anyway: Yes, I have no problems either to use dolist here. > Great, I'll add the package then. Great thanks! =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmTR4eYTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk1+OC/9VI+upmNCVwpv7n+nVfkz27UguPb7u UfuHF6giuQ2I4v68B5vHMcF5Gpckx58UTV2qECDtETgge2GiqNd1Q7l/DreXxvAm 8vDgHDOvfw0PsGIn51eX0EJw71hQtAjr+ez9VgMuCj+0eQkbu6O7iK8lW1Nal6r/ ppXghYbwq/KvsPpsofH00fRwIDpAUBWBefXGCMU/lF9iaqmDsAGIKYtqmL8WeaXK 0BFBrDEBKOdDBX4wWhgOXRWwe0MQXGS1F/ycwNlPmFRmUPmMm8i5zVosJpQpKuzV UH3ojajsuQaJRbIaICYU//+p9AcA1pKxPCSFhjzyEecrpU11fQutQnCdKVsXlBFn 7cRkbuvjrKwzQ+BNnVYiOxuWMq/BhQu7ZIl16aE6rKQc9upvN/T8jVvrGlYXLXV8 o2aISzQHOEsIV0jeI4ytGMYuI9MyPYaOc2uQNm4t1uBF0S95uvvMRZzzrRac9mpP 7+mLQf0RuK3LDpQe8T79Qd0PWCPYPQLC76g= =EwEx -----END PGP SIGNATURE----- --=-=-=--