bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Felix]

The background of stipple stays opaque with alpha-background parameter
set for transparency.
This came up in the use of the new package 'indent-bars'.
The github issue: https://github.com/jdtsmith/indent-bars/issues/8
I tested this with 'emacs -Q' only enabling the needed packages (compat
and indent-bars).


In GNU Emacs 30.0.50 (build 12, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-08-03 built on
 felix-lifebooka531
Repository revision: 588a0363d9a3ce6d678618ad545f7a8f9af27880
Repository branch: makepkg
System Description: Arch Linux

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
 --with-modules --without-libotf --without-m17n-flt --without-gconf
 --enable-link-time-optimization --with-native-compilation=yes
 --with-xinput2 --with-pgtk --without-xaw3d --with-cairo-xcb
 --with-sound=no --with-xwidgets --with-tree-sitter --without-gpm
 --without-compress-install
 '--program-transform-name=s/\([ec]tags\)/\1.emacs/'
 'CFLAGS=-march=native -mtune=generic -O3 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection'
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK
PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER
WEBP XIM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8

bug#65042: Simple example to reproduce.

[Felix]

The following code should visualize the problem.


(font-lock-mode -1)
(set-frame-parameter (selected-frame) 'alpha-background 50)
(let* ((w (window-font-width))
       (stipple `(,w 1 ,(apply #'unibyte-string
			       (append (make-list (1- (/ (+ w 7) 8)) ?\0)
				       '(1))))))
  (insert "\n" (propertize (concat  (make-string 15 ?\s)
				    "THIS IS A TEST"
				    (make-string 15 ?\s))
                           'face `(:foreground "blue" :stipple ,stipple))))

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Felix <felix.dick@web.de> writes:

> The background of stipple stays opaque with alpha-background parameter
> set for transparency.
> This came up in the use of the new package 'indent-bars'.
> The github issue: https://github.com/jdtsmith/indent-bars/issues/8
> I tested this with 'emacs -Q' only enabling the needed packages (compat
> and indent-bars).

Thanks.  Do stipples start displaying adequately with this change?

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 9c1fc7bef4e..bc5c6209d42 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -1328,14 +1328,16 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
 			 int width, int height)
 {
   cairo_t *cr = pgtk_begin_cr_clip (f);
+  double r, g, b, a;
 
   cairo_rectangle (cr, x, y, width, height);
   cairo_clip (cr);
 
-  double r = ((face->background >> 16) & 0xff) / 255.0;
-  double g = ((face->background >> 8) & 0xff) / 255.0;
-  double b = ((face->background >> 0) & 0xff) / 255.0;
-  cairo_set_source_rgb (cr, r, g, b);
+  r = ((face->background >> 16) & 0xff) / 255.0;
+  g = ((face->background >> 8) & 0xff) / 255.0;
+  b = ((face->background >> 0) & 0xff) / 255.0;
+  a = f->alpha_background;
+  cairo_set_source_rgba (cr, r, g, b, a);
   cairo_paint (cr);
 
   if (face->stipple != 0)
@@ -1343,10 +1345,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
       cairo_pattern_t *mask
 	= FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern;
 
-      double r = ((face->foreground >> 16) & 0xff) / 255.0;
-      double g = ((face->foreground >> 8) & 0xff) / 255.0;
-      double b = ((face->foreground >> 0) & 0xff) / 255.0;
-      cairo_set_source_rgb (cr, r, g, b);
+      r = ((face->foreground >> 16) & 0xff) / 255.0;
+      g = ((face->foreground >> 8) & 0xff) / 255.0;
+      b = ((face->foreground >> 0) & 0xff) / 255.0;
+      cairo_set_source_rgba (cr, r, g, b, a);
       cairo_mask (cr, mask);
     }
 

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Felix]

Po Lu <luangruo@yahoo.com> writes:

> Felix <felix.dick@web.de> writes:
>
>> The background of stipple stays opaque with alpha-background parameter
>> set for transparency.
>> This came up in the use of the new package 'indent-bars'.
>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8
>> I tested this with 'emacs -Q' only enabling the needed packages (compat
>> and indent-bars).
>
> Thanks.  Do stipples start displaying adequately with this change?
>
No it doesn't.
But it gives weird artifacts (doubling the character one
line above or something like that)

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Felix <felix.dick@web.de> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> Felix <felix.dick@web.de> writes:
>>
>>> The background of stipple stays opaque with alpha-background parameter
>>> set for transparency.
>>> This came up in the use of the new package 'indent-bars'.
>>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8
>>> I tested this with 'emacs -Q' only enabling the needed packages (compat
>>> and indent-bars).
>>
>> Thanks.  Do stipples start displaying adequately with this change?
>>
> No it doesn't.
> But it gives weird artifacts (doubling the character one
> line above or something like that)

How about this?

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 9c1fc7bef4e..a7c687d811d 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -1328,14 +1328,17 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
 			 int width, int height)
 {
   cairo_t *cr = pgtk_begin_cr_clip (f);
+  double r, g, b, a;
 
+  cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
   cairo_rectangle (cr, x, y, width, height);
   cairo_clip (cr);
 
-  double r = ((face->background >> 16) & 0xff) / 255.0;
-  double g = ((face->background >> 8) & 0xff) / 255.0;
-  double b = ((face->background >> 0) & 0xff) / 255.0;
-  cairo_set_source_rgb (cr, r, g, b);
+  r = ((face->background >> 16) & 0xff) / 255.0;
+  g = ((face->background >> 8) & 0xff) / 255.0;
+  b = ((face->background >> 0) & 0xff) / 255.0;
+  a = f->alpha_background;
+  cairo_set_source_rgba (cr, r, g, b, a);
   cairo_paint (cr);
 
   if (face->stipple != 0)
@@ -1343,10 +1346,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
       cairo_pattern_t *mask
 	= FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern;
 
-      double r = ((face->foreground >> 16) & 0xff) / 255.0;
-      double g = ((face->foreground >> 8) & 0xff) / 255.0;
-      double b = ((face->foreground >> 0) & 0xff) / 255.0;
-      cairo_set_source_rgb (cr, r, g, b);
+      r = ((face->foreground >> 16) & 0xff) / 255.0;
+      g = ((face->foreground >> 8) & 0xff) / 255.0;
+      b = ((face->foreground >> 0) & 0xff) / 255.0;
+      cairo_set_source_rgba (cr, r, g, b, a);
       cairo_mask (cr, mask);
     }
 

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Felix]

Po Lu <luangruo@yahoo.com> writes:

> Felix <felix.dick@web.de> writes:
>
>> Po Lu <luangruo@yahoo.com> writes:
>>
>>> Felix <felix.dick@web.de> writes:
>>>
>>>> The background of stipple stays opaque with alpha-background parameter
>>>> set for transparency.
>>>> This came up in the use of the new package 'indent-bars'.
>>>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8
>>>> I tested this with 'emacs -Q' only enabling the needed packages (compat
>>>> and indent-bars).
>>>
>>> Thanks.  Do stipples start displaying adequately with this change?
>>>
>> No it doesn't.
>> But it gives weird artifacts (doubling the character one
>> line above or something like that)
>
> How about this?
>
> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
> index 9c1fc7bef4e..a7c687d811d 100644
> --- a/src/pgtkterm.c
> +++ b/src/pgtkterm.c
> @@ -1328,14 +1328,17 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
>  			 int width, int height)
>  {
>    cairo_t *cr = pgtk_begin_cr_clip (f);
> +  double r, g, b, a;
>
> +  cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
>    cairo_rectangle (cr, x, y, width, height);
>    cairo_clip (cr);
>
> -  double r = ((face->background >> 16) & 0xff) / 255.0;
> -  double g = ((face->background >> 8) & 0xff) / 255.0;
> -  double b = ((face->background >> 0) & 0xff) / 255.0;
> -  cairo_set_source_rgb (cr, r, g, b);
> +  r = ((face->background >> 16) & 0xff) / 255.0;
> +  g = ((face->background >> 8) & 0xff) / 255.0;
> +  b = ((face->background >> 0) & 0xff) / 255.0;
> +  a = f->alpha_background;
> +  cairo_set_source_rgba (cr, r, g, b, a);
>    cairo_paint (cr);
>
>    if (face->stipple != 0)
> @@ -1343,10 +1346,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
>        cairo_pattern_t *mask
>  	= FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern;
>
> -      double r = ((face->foreground >> 16) & 0xff) / 255.0;
> -      double g = ((face->foreground >> 8) & 0xff) / 255.0;
> -      double b = ((face->foreground >> 0) & 0xff) / 255.0;
> -      cairo_set_source_rgb (cr, r, g, b);
> +      r = ((face->foreground >> 16) & 0xff) / 255.0;
> +      g = ((face->foreground >> 8) & 0xff) / 255.0;
> +      b = ((face->foreground >> 0) & 0xff) / 255.0;
> +      cairo_set_source_rgba (cr, r, g, b, a);
>        cairo_mask (cr, mask);
>      }
>

This time it works,
Thanks for this, and thanks your work on Emacs in general!

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Felix <felix.dick@web.de> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> Felix <felix.dick@web.de> writes:
>>
>>> Po Lu <luangruo@yahoo.com> writes:
>>>
>>>> Felix <felix.dick@web.de> writes:
>>>>
>>>>> The background of stipple stays opaque with alpha-background parameter
>>>>> set for transparency.
>>>>> This came up in the use of the new package 'indent-bars'.
>>>>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8
>>>>> I tested this with 'emacs -Q' only enabling the needed packages (compat
>>>>> and indent-bars).
>>>>
>>>> Thanks.  Do stipples start displaying adequately with this change?
>>>>
>>> No it doesn't.
>>> But it gives weird artifacts (doubling the character one
>>> line above or something like that)
>>
>> How about this?
>>
>> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
>> index 9c1fc7bef4e..a7c687d811d 100644
>> --- a/src/pgtkterm.c
>> +++ b/src/pgtkterm.c
>> @@ -1328,14 +1328,17 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
>>  			 int width, int height)
>>  {
>>    cairo_t *cr = pgtk_begin_cr_clip (f);
>> +  double r, g, b, a;
>>
>> +  cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
>>    cairo_rectangle (cr, x, y, width, height);
>>    cairo_clip (cr);
>>
>> -  double r = ((face->background >> 16) & 0xff) / 255.0;
>> -  double g = ((face->background >> 8) & 0xff) / 255.0;
>> -  double b = ((face->background >> 0) & 0xff) / 255.0;
>> -  cairo_set_source_rgb (cr, r, g, b);
>> +  r = ((face->background >> 16) & 0xff) / 255.0;
>> +  g = ((face->background >> 8) & 0xff) / 255.0;
>> +  b = ((face->background >> 0) & 0xff) / 255.0;
>> +  a = f->alpha_background;
>> +  cairo_set_source_rgba (cr, r, g, b, a);
>>    cairo_paint (cr);
>>
>>    if (face->stipple != 0)
>> @@ -1343,10 +1346,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y,
>>        cairo_pattern_t *mask
>>  	= FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern;
>>
>> -      double r = ((face->foreground >> 16) & 0xff) / 255.0;
>> -      double g = ((face->foreground >> 8) & 0xff) / 255.0;
>> -      double b = ((face->foreground >> 0) & 0xff) / 255.0;
>> -      cairo_set_source_rgb (cr, r, g, b);
>> +      r = ((face->foreground >> 16) & 0xff) / 255.0;
>> +      g = ((face->foreground >> 8) & 0xff) / 255.0;
>> +      b = ((face->foreground >> 0) & 0xff) / 255.0;
>> +      cairo_set_source_rgba (cr, r, g, b, a);
>>        cairo_mask (cr, mask);
>>      }
>>
>
> This time it works,
> Thanks for this, and thanks your work on Emacs in general!

OK, thanks.  Eli, should this reach Emacs 29.2, or is it too involved
for the release branch?

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: 65042@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 04 Aug 2023 21:28:50 +0800
> 
> Felix <felix.dick@web.de> writes:
> 
> > This time it works,
> > Thanks for this, and thanks your work on Emacs in general!
> 
> OK, thanks.  Eli, should this reach Emacs 29.2, or is it too involved
> for the release branch?

This is okay for the release branch, thanks.

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Felix]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: 65042@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>> Date: Fri, 04 Aug 2023 21:28:50 +0800
>>
>> Felix <felix.dick@web.de> writes:
>>
>> > This time it works,
>> > Thanks for this, and thanks your work on Emacs in general!
>>
>> OK, thanks.  Eli, should this reach Emacs 29.2, or is it too involved
>> for the release branch?
>
> This is okay for the release branch, thanks.

Friendly reminding ping.

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Felix <felix.dick@web.de> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Po Lu <luangruo@yahoo.com>
>>> Cc: 65042@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>>> Date: Fri, 04 Aug 2023 21:28:50 +0800
>>>
>>> Felix <felix.dick@web.de> writes:
>>>
>>> > This time it works,
>>> > Thanks for this, and thanks your work on Emacs in general!
>>>
>>> OK, thanks.  Eli, should this reach Emacs 29.2, or is it too involved
>>> for the release branch?
>>
>> This is okay for the release branch, thanks.
>
> Friendly reminding ping.

I apologize for neglecting this; it will be installed on the Emacs 29
branch shortly, though you may have to wait several days for that change
to reach master.

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> Felix <felix.dick@web.de> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> From: Po Lu <luangruo@yahoo.com>
>>>> Cc: 65042@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>>>> Date: Fri, 04 Aug 2023 21:28:50 +0800
>>>>
>>>> Felix <felix.dick@web.de> writes:
>>>>
>>>> > This time it works,
>>>> > Thanks for this, and thanks your work on Emacs in general!
>>>>
>>>> OK, thanks.  Eli, should this reach Emacs 29.2, or is it too involved
>>>> for the release branch?
>>>
>>> This is okay for the release branch, thanks.
>>
>> Friendly reminding ping.
>
> I apologize for neglecting this; it will be installed on the Emacs 29
> branch shortly, though you may have to wait several days for that change
> to reach master.

So this has been fixed?  Should the bug be closed?

Thanks.

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> So this has been fixed?  Should the bug be closed?

Yes, all that remains is for Felix to reply.

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Felix]

Po Lu <luangruo@yahoo.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> So this has been fixed?  Should the bug be closed?
>
> Yes, all that remains is for Felix to reply.

I didn't know that a reply is needed, sorry.
It's fixed and can be closed, thanks.

bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk

[Stefan Kangas]

Felix <felix.dick@web.de> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> Stefan Kangas <stefankangas@gmail.com> writes:
>>
>>> So this has been fixed?  Should the bug be closed?
>>
>> Yes, all that remains is for Felix to reply.
>
> I didn't know that a reply is needed, sorry.
> It's fixed and can be closed, thanks.

Thanks, closed.