From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sun, 10 Sep 2023 15:33:39 +0800 Message-ID: <87y1hea3e4.fsf@yahoo.com> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> <83zg259iwz.fsf@gnu.org> <878r9losil.fsf@ledu-giraud.fr> <83tts2scvp.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38125"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: stefankangas@gmail.com, Manuel Giraud , 64440@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 09:35:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfEyn-0009g3-W3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 09:35:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfEyD-0002yc-18; Sun, 10 Sep 2023 03:35:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfEyB-0002wm-CF for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 03:34:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfEyB-0000F7-36 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 03:34:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfEyE-00043C-9v for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 03:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.169433124615484 (code B ref 64440); Sun, 10 Sep 2023 07:35:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 10 Sep 2023 07:34:06 +0000 Original-Received: from localhost ([127.0.0.1]:48896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfExK-00041f-Jr for submit@debbugs.gnu.org; Sun, 10 Sep 2023 03:34:06 -0400 Original-Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:36534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfExJ-00041C-0s for 64440@debbugs.gnu.org; Sun, 10 Sep 2023 03:34:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694331235; bh=yrCKCk73Np7Fd/BiijD0xwrVAmTa2Lw2Q2XZeq/op/0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=V5MwD9L6Gric3RwvQ2dT3rZW9Tfha6jVvfjMF3d5ocOGVVVLc4srNipV9tERRT7CGRrJ1EjyeEMcKqxliVM3y7/Y6HIzPTaxvNszpjjfx45NOvBZaxZSlKlkY+PEz1tBWM6cqEr5+9BhkdyFvFD4Jc7lHyux6yjPFB5xUfNErpOcQs2EvDYLvi+MyXF7/+XizE4CIQk35RTdxYfJuRadsyhj+XM2Pm6t6eL8ry+e8cW3EAyyFdjN7MPkVqG0NdgGfl1JGUBGbF9o7oTBcgG+P6hPcr3P7+xrXSh/M3EjwF+7WBKr+1EAS6skJHx1F6Qkc+AH3v17wlemxAFJpSlBpQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694331235; bh=XNRduyU54dZhWC+eObLRpdvJNdA5luVG98oV43ETTFW=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PBfdwllVdaAcWB58iFEwHCWhegxWD6nlXRGNJDfSIObJ28Lh61oxMvR/V8CBgLR+ljFsmNZ5T61PHfH/tWWXkoZHrY9BSlYUQu6U+1Ck8ytIzaUUUQGr+YfnL/2Pj6wWjgi3OsXoFiLtCPLtszpcn+3ISKZB7CsbUwvrzjI69Z4s177ft0DbWfBfBa4CJ1/p4u0yCaneqDiTiWUV8VP/qApTEL+RlE0mgGOmYqy7g8WS2Uav3tKojvzapPRxtSw09uVlJFQRDw3onpMsehd80iUYjSVR6pIVxr5sD05t5wg87iPn1lVxR0IhFT9UNbpeAlNzw3a+1oEMYUt/JxiUsA== X-YMail-OSG: 3TircI4VM1linSIIPZcmnWCUYE_I19U2KDbIC6ynHnCGmthO_3QWUz5iv2YcG9p ZesahhVwCn02UE_kbyzGzSOoR2GKrrB169qMuXzBvnco6LkJSb8QS1aoaoidtrFCG.iBeyTXziUO oaLGGixoNMnXvwDhz89pXXHUjNWEAcbCdDvp8qLJdLdEsUO1HKJHkqDGZWW5Yn8AFcARat536LyV PC7gGowhWexYF42dDZlKxEdc6hGd9jJkkGkd4ODJnq.kTa33UtRUBJyY6GHXzmlA3N8QbQ9BR6fC UMJc6OqOQTrWI7vO4Jgd8i6yRISTxcgOClZm5DpHe7yw.ULMW7XBz7FddtMxRBJZPsqIPq7BM_0v jweZmBz2K_1pdoV4SFGHaY3KZl3BhVAdrpebNSZCvrkHlCO8sokZI0IiYMoRWICAcVQgTHHN3FTi RVMgLnirT5UPuBqjFz5ifPvF45U9P_irmQDPeLaXsc_jax_3eo70hrBlUK.gfVrhCw5Epij_B5jh ftF9DNSNlV4JdZ46jE1r8tLE4hwJyA10crJDQBApKBbiHS0xell6Z154Wm8qrhjzR1ycsSfMgBzv K7HzVkvDbQnLBUlciBsumk0rdovPIkFNI1rZsVURLxP89xHAtSY7_XpnVOJiQK9jMtqGN5CYqlr4 n1EqDIAc8E71yXwGR5bg0B8i927bLVdmzdvEY684ov8Y569o7H_j3J6HZFWb5bS56Ak7IZEQ4Yfa 5Deqgs5dCOq8P9QPfb2lHv8G0NQROg01y6Xwc53o0tOan.p_hjUEhWc4ZbmIPxE5hFEZYB0se1cu ghKEClo_eIQn0UIZJskGoirzE04q0Rd_cayWWUvA1U X-Sonic-MF: X-Sonic-ID: ca14cdc6-2646-4545-a5ab-1f47951ec678 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sun, 10 Sep 2023 07:33:55 +0000 Original-Received: by hermes--production-sg3-69654d8bd-tsbjv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f8410ebbb14325a0ea689ba1e7efa6db; Sun, 10 Sep 2023 07:33:51 +0000 (UTC) In-Reply-To: <83tts2scvp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Sep 2023 10:31:22 +0300") X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269923 Archived-At: Eli Zaretskii writes: > Is this function under a suitable #if condition? AFAIU, it is only > appropriate in a build with X but without any toolkit, so it shouldn't Or on Android, which also utilizes our own menu bars. The right conditional is: #if defined HAVE_WINDOW_SYSTEM && !defined HAVE_EXT_MENU_BAR