From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Monaco Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Jumping to message by ID Date: Fri, 20 Oct 2023 19:26:44 +0200 Message-ID: <87y1fxyzl7.fsf@autistici.org> References: <83sf65si7o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 20 19:27:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qttHl-0007JT-4E for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Oct 2023 19:27:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qttGv-0003w0-T8; Fri, 20 Oct 2023 13:26:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qttGt-0003vh-Oh for emacs-devel@gnu.org; Fri, 20 Oct 2023 13:26:52 -0400 Original-Received: from confino.investici.org ([93.190.126.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qttGr-0007SW-IB; Fri, 20 Oct 2023 13:26:51 -0400 Original-Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4SBs2Z1RgXz11DY; Fri, 20 Oct 2023 17:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1697822806; bh=GpHk04UuROEaY5fK4s2KKAcdtcGHCUwtVpGnWcF+Hgo=; h=From:To:Cc:Subject:In-Reply-To:Date:From; b=tY2xl28dLcehUB6I87ZeD/AoF43jhDeBxiHHz0r3qzwEt9xgSGzWp1NrDTOXoenUL eXSkFfNCa90gDt1dAuGrEeBMbBz1jHDcx8PMUtxEZ+Lo6Ap+AmmRdFjzkLn21ZWE2c Xzub9536Ccbjc/1LJ+6Kg8oVD8KisMPebaONiA8U= Original-Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: andrea.monaco@autistici.org) by localhost (Postfix) with ESMTPSA id 4SBs2Z0Y9Sz11DJ; Fri, 20 Oct 2023 17:26:46 +0000 (UTC) In-Reply-To: <83sf65si7o.fsf@gnu.org> (message from Eli Zaretskii on Fri, 20 Oct 2023 13:26:19 +0300) Received-SPF: pass client-ip=93.190.126.19; envelope-from=andrea.monaco@autistici.org; helo=confino.investici.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311627 Archived-At: > The name of the function doesn't seem to reflect what it does. Can > you come up with a better name? What about rmail-match-email-address-around-point? Of course I'm looking for message ids, but those have the same syntax as email addresses and the latter are surely known to whoever reads my function. > If so, perhaps it would make sense to update the data each time we > update the summary, instead of punishing the first call after > getting new email? You're right, that's the same issue as rmail-summary-by-thread. In this case I only need the message id hash table so I could just update that, at the risk of making it out of sync with the vectors of parents and descendants. The only solution is updating all the data structures each time new mail is got or mail is expunged, instead of recreating them from scratch; I can look into that. Andrea Monaco