From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ebdb f7b50402cf: Final round of compiler quieting Date: Wed, 25 Oct 2023 11:18:59 -0700 Message-ID: <87y1fqpnu4.fsf@ericabrahamsen.net> References: <169810882764.9789.14002053467217676494@vcs2.savannah.gnu.org> <20231024005348.35660C09BE2@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22007"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:4cp/2YopvCo6DcGNRSjIE/Diumc= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 25 20:26:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qviai-0005XI-MG for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Oct 2023 20:26:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qviaM-0002In-Pr; Wed, 25 Oct 2023 14:26:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qviTI-0002qj-T2 for emacs-devel@gnu.org; Wed, 25 Oct 2023 14:19:12 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qviTG-0004CO-0h for emacs-devel@gnu.org; Wed, 25 Oct 2023 14:19:12 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qviTC-0005MV-Pc for emacs-devel@gnu.org; Wed, 25 Oct 2023 20:19:06 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 25 Oct 2023 14:26:29 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311857 Archived-At: Stefan Monnier writes: >> Not all the way there, but I don't know what to do about the format >> complaints. > > The suspect that problem is that your definition of `ebdb-add-to-list` > duplicates its argument, so > > (ebdb-add-to-list X (format FOO BAR)) > > becomes > > (when (format FOO BAR) (push (format FOO BAR) X)) > > Since `format` always returns a string, the `when` can be optimized away > so the above becomes: > > (progn (format FOO BAR) (push (format FOO BAR) X)) > > Beside the useless call to `format` there are other minor problems with > this definition of `ebdb-add-to-list`, such as the fact that its > arguments are not evaluated in the expected order (left to right), and > the fact that the second argument gets evaluated twice, so: > > (ebdb-add-to-list (progn (message "hello") 'x) > (progn (message "world") 3)) > > ends up adding 3 to x and emitting > > world > world > hello > > instead of > > hello > world > > But the more serious problem is that `ebdb-add-to-list` is defined as > a function yet it can't work as a function because its first argument is > expected to be a "place" not a value. > So you have to define it as a macro rather than a (define-inline) function. > > Also, personally I'd recommend you rename the to use a word like "push" > (and to switch its args) rather than `add-to-list`, so the reader can > guess that it takes an place, like `(cl-)push(new)`, rather than > a symbol, like `add-to-list`. Thank you very much for the detailed explanation, and for the patch! This is an area of Elisp I still don't have much feel for, and I don't think would have come up with the right gv-/macroexp- invocations myself. I'll get this released in the next few days. Thanks again, Eric