From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#66649: 29.1; `project-remember-projects-under' behavior doesn't match its doc Date: Wed, 08 Nov 2023 08:13:16 +0000 Message-ID: <87y1f8r7c3.fsf@posteo.net> References: <87v8b18qh7.fsf@cassou.me> <057a5ddf-2974-ce53-f795-b146e205db1e@yandex.ru> <87bkcd1utg.fsf@posteo.net> <87y1fhxijq.fsf@posteo.net> <87zfzw6i7m.fsf@cassou.me> <540bbdb3-5861-146c-688f-41534962fdf5@yandex.ru> <87wmuzq9dl.fsf@cassou.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19731"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66649@debbugs.gnu.org, Dmitry Gutov To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 08 09:14:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0dhx-0004xe-3v for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Nov 2023 09:14:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0dhh-0000v1-Hp; Wed, 08 Nov 2023 03:14:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0dhf-0000us-Td for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:14:24 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0dhf-00084Y-LX for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:14:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0diH-00018e-LU for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2023 08:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66649 X-GNU-PR-Package: emacs Original-Received: via spool by 66649-submit@debbugs.gnu.org id=B66649.16994312464283 (code B ref 66649); Wed, 08 Nov 2023 08:15:01 +0000 Original-Received: (at 66649) by debbugs.gnu.org; 8 Nov 2023 08:14:06 +0000 Original-Received: from localhost ([127.0.0.1]:43956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0dhN-000171-PY for submit@debbugs.gnu.org; Wed, 08 Nov 2023 03:14:06 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:47955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0dhK-00016Q-QA for 66649@debbugs.gnu.org; Wed, 08 Nov 2023 03:14:04 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E482B240101 for <66649@debbugs.gnu.org>; Wed, 8 Nov 2023 09:13:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1699431197; bh=jdpm0G26OCtXu60nxdLmwIHhhVyqdbJRK9SRwNiRhzs=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=L79gXPmKXk3yaC8u1aSRwL8SfJHzA2hi/L/mnY5kgWsD/9p7h31zb1fA+8CTkfa23 COVkLOhahmaF6Rujecmr2skF7p1XDz5gcTM2wvA5gH0Kbn2n2VqGBWoD3xYK1wCicJ pUNeR1YzKNCQHldOVVcLcpXfF7EQImalgIXlkTMGTftaetWO4/kl9ZgbIX2nfaT9HI 2mQKEV7PVMngUBB+fCU7/EvYr+pmcuRgPXGlG8as1sJymHHo8iRcRKoZaMGm8LrruR i2qu18AM2LAh1e2UcM3T0kf0BwqwwlOMXH47vWP4LQENchSaGyu7vhYZujKkeb30Di FUKKoGAart45A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SQHs91ZMTz6twb; Wed, 8 Nov 2023 09:13:17 +0100 (CET) In-Reply-To: <87wmuzq9dl.fsf@cassou.me> (Damien Cassou's message of "Fri, 03 Nov 2023 14:00:54 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273972 Archived-At: --=-=-= Content-Type: text/plain Damien Cassou writes: > Dmitry Gutov writes: >> On 02/11/2023 21:58, Damien Cassou wrote: >>> If I may, the code of `project-remember-projects-under' seems to suffer >>> from a similar mismatch between the docstring and implementation when >>> RECURSIVE is nil: only the DIR directory is tested and not "known >>> projects below a directory DIR". >> >> Have you seen this problem when testing it? > > The patch is working perfectly find, thank you. I was talking about an > unrelated (but similar) problem in a different function: > `project-forget-projects-under'. My message incorrectly referred to the > function you already fixed. Sorry for the confusion. I don't think this is the same problem, in `project-forget-projects-under' there is no manual recursive descent, just some duplicated code. We could also re-write it to look like this: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 95db9d0ef4c..5f1cce160b2 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1905,15 +1905,12 @@ project-forget-projects-under forgotten projects." (interactive "DDirectory: \nP") (let ((count 0)) - (if recursive - (dolist (proj (project-known-project-roots)) - (when (file-in-directory-p proj dir) - (project-forget-project proj) - (setq count (1+ count)))) - (dolist (proj (project-known-project-roots)) - (when (file-equal-p (file-name-directory proj) dir) - (project-forget-project proj) - (setq count (1+ count))))) + (dolist (proj (project-known-project-roots)) + (when (if recursive + (file-in-directory-p proj dir) + (file-equal-p (file-name-directory proj) dir)) + (project-forget-project proj) + (setq count (1+ count)))) (if (zerop count) (message "No projects were forgotten") (project--write-project-list) --=-=-= Content-Type: text/plain But that would incur a branch in every iteration of `dolist'. Either way, I'll push the first patch to master since there haven't been any objections to that change. --=-=-=--