From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries Date: Wed, 31 Jan 2024 22:01:18 +0800 Message-ID: <87y1c5ob4h.fsf@yahoo.com> References: <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org> <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> <540cc339-b7d4-4c1a-b084-c7f739ad4947@gutov.dev> <8734ue327d.fsf@gmail.com> <87a5omf1e8.fsf@yahoo.com> <878r45px71.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8894"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 31 15:02:27 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVBAZ-00029Y-GD for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Jan 2024 15:02:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVB9v-0006kx-JJ; Wed, 31 Jan 2024 09:01:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVB9i-0006kC-7M for emacs-devel@gnu.org; Wed, 31 Jan 2024 09:01:36 -0500 Original-Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVB9f-0008Pg-4q for emacs-devel@gnu.org; Wed, 31 Jan 2024 09:01:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706709688; bh=zVWUfWhB8l57APGX4prj9e89xpixx74laSnZBMwPT6k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=fNRaIvFMShE0YkzsCEPpIHwfeYiwPQ1HAWaKTkc7KfAAojaCXYezm+/CXiC/vNgtgs7zswDZCaQyiw1rQffjYGKn4lbCjKRpMfeuXSxFIeCCKfLf6MhBKb5hz54ibIyd8f+R4jfmd+6SqRlt4R6374MeaSoGBOUKX457bYyPpnLVsdTVKc7tEGviOuLuMLoaSfuXSjqRQtSVy0tpQNzIhh2jaMxCslZ0p4cCl+U9DUNKZqK+4erQkTouqYYOiWnKQvt9zBrHWCN4k0EtanspLFNHaA3J8jCuGsknBe+Gwcjq1WDHJCcc5C2FBmSBibno0rH4vtTi7yWGljc8tBxaKw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706709688; bh=K5l1EbZczOHugfsbEpzMpSc3RMbsYjnfxarjJdGVJAp=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=AnU6hpNnjiRtMzISvDAecNNxOfANjXNNZWwdZeF9oy/9OfuCCMhGKr2WDNC24NYIRvlVp6h5VAHTA2oV2ABvM5vzHcgEMaOYjBoTb2BP/njvzWVJL4On8abNz2zV0bKUt1Q+rYSIOM5XUliO23zRWg7p1kxFkxXm81CSrVilTOtmf59co2Q02h8xFt3lG6tJXmyIzB1a95SCS+hN5tBxwYTIu6+QtTdueIQrjaaOwTburdXVvZqfzUvhbXY4aAPXCmLveR8la/v5pwzbe8S9uhiY3zUT0Bxk6ck2/B3RX0LXakypy4Hb2W5dy0M4D21JXfXO9vrFlIZXhxGnKXIb6g== X-YMail-OSG: RwqX2UkVM1mo_YjzZ4S3Kg1Ho1rf3YSVjhrC83xOsyOv8dv3OJoQVL2KcrObImo 6YdkB5jRYlj9PCrIJzPHwKbYyqwVOqDKY4U5zX2SjplegYlkpWCl7wb4ZuPe0T0vVrCxwnXDhI7O .O1RAQi1FWlyvuFRRYTAuaB0pAXHG_oZs_.4u2GU92AzaBwiKOhBbljC3DbFoVoOowb1YBi5B7MW 8E.PaduK4yFuF8qvo7fdtuWbg0cTjq0IsVUzsjfLYPA0gCTZ7cNBYIlk_rrY.I6XbGr0BuZSArfJ sWl5gfVVyoNTau.ybJJNpEW0y5mrQXoI.E2dzCsUTVpvOoC693bkgXleBvOquD8SpflrbY.YNtu8 BQarNGTawVVm6EuRC0GYTrm4GSEfF02wPi3IVpFvsMWNPoZd4vk2O7ZA6z2Lq8OQc7Dpt2oG3Qhl YD_W3E1Fg5CRuH2iIrl6kcC3TX744sdGxW3Qyk6_jkYEI3oq6uCPQknuS0F.aOdZ7crQnH8SZOkt Q0SZfOvXxEeNxs6ixflK7k.Yzc0UbXVaA019VA876VSfSkBIBp7DcWnI2M7rAcxCeltQJRjiuPba Mi2OWFe1z3n9OxTKnlZew0h8x8AJY1l_sCUnajwrVecFD2nfIvqjNy4aKISr2w3b4OS0P5F6RPNL ne4FyJ4iQDbDoLRVVCWfmMrT29ffUx.N7o9hH8tqo4aK4CpbGoBYJijqUFCROqaifVfgX8EHCXgl Urivu5yTLXA0EZsmY49bjBW6J2cPKyayNsNliCr4lAxrFNIrZk93MhJUjmR6mThMvUPqgVnYyp2M SIGyTb4nURkr4tD8_tzvw3IssJ1Ql0DHgD2n2c3p_U X-Sonic-MF: X-Sonic-ID: 331208d6-b638-4ab8-af87-73d060055855 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Wed, 31 Jan 2024 14:01:28 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-qvr7d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a9db8d4bb981cce179e1929b87ef0260; Wed, 31 Jan 2024 14:01:24 +0000 (UTC) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 31 Jan 2024 13:22:38 +0000") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.200; envelope-from=luangruo@yahoo.com; helo=sonic301-31.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315666 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > The unit tests are basically the only thing I can read from > your code. Really, in practice you'll be probably be the only one ever > reading that long-winded Fotran-like code, so I wish you stick around > for a long time maintaining it. Not only are the insults uncalled-for, the assumptions they rest on are also completely untrue. Great volumes of "long-winded Fortran-like code" exist in Emacs with no shortage of maintainers, just as they do in other established free software projects. See any file in CC Mode, or GCC's reload.cc, which features this massive conditional dwarfing any of ours: scalar_int_mode inner_mode; if (in !=3D 0 && GET_CODE (in) =3D=3D SUBREG && targetm.can_change_mode_class (GET_MODE (SUBREG_REG (in)), inmode, rclass) && contains_allocatable_reg_of_mode[rclass][GET_MODE (SUBREG_REG (in)= )] && (strict_low || (subreg_lowpart_p (in) && (CONSTANT_P (SUBREG_REG (in)) || GET_CODE (SUBREG_REG (in)) =3D=3D PLUS || (((REG_P (SUBREG_REG (in)) && REGNO (SUBREG_REG (in)) >=3D FIRST_PSEUDO_REGISTER) || MEM_P (SUBREG_REG (in))) && (paradoxical_subreg_p (inmode, GET_MODE (SUBREG_REG (in))) || (known_le (GET_MODE_SIZE (inmode), UNITS_PER_WORD) && is_a (GET_MODE (SUBREG_REG (in)), &inner_mode) && GET_MODE_SIZE (inner_mode) <=3D UNITS_PER_WORD && paradoxical_subreg_p (inmode, inner_mode) && LOAD_EXTEND_OP (inner_mode) !=3D UNKNOWN) || (WORD_REGISTER_OPERATIONS && partial_subreg_p (inmode, GET_MODE (SUBREG_REG (in))) && (known_equal_after_align_down (GET_MODE_SIZE (inmode) - 1, GET_MODE_SIZE (GET_MODE (SUBREG_REG (in))) - 1, UNITS_PER_WORD))))) || (REG_P (SUBREG_REG (in)) && REGNO (SUBREG_REG (in)) < FIRST_PSEUDO_REGISTER /* The case where out is nonzero is handled differently in the following statement. */ && (out =3D=3D 0 || subreg_lowpart_p (in)) && (complex_word_subreg_p (inmode, SUBREG_REG (in)) || !targetm.hard_regno_mode_ok (subreg_regno (in), inmode))) || (secondary_reload_class (1, rclass, inmode, in) !=3D NO_REGS && (secondary_reload_class (1, rclass, GET_MODE (SUBREG_REG (in)), SUBREG_REG (in)) =3D=3D NO_REGS)) || (REG_P (SUBREG_REG (in)) && REGNO (SUBREG_REG (in)) < FIRST_PSEUDO_REGISTER && !REG_CAN_CHANGE_MODE_P (REGNO (SUBREG_REG (in)), GET_MODE (SUBREG_REG (in)), inmode)))) || (REG_P (SUBREG_REG (in)) && REGNO (SUBREG_REG (in)) >=3D FIRST_PSEUDO_REGISTER && reg_equiv_mem (REGNO (SUBREG_REG (in))) && (mode_dependent_address_p (XEXP (reg_equiv_mem (REGNO (SUBREG_REG (in))), 0), MEM_ADDR_SPACE (reg_equiv_mem (REGNO (SUBREG_REG (in))))))))) I'm aware that GCC is abandoning reload for a new register allocator, whose coding style is not substantially different, but offers fewer in the way of prodigious conditionals to prove my point. Whether you want to work on log-edit.el, of course, is up to you.