From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#69578: 30.0.50; tab-bar-mode binding of (control tab) not always useful Date: Mon, 11 Mar 2024 15:23:51 +0100 Message-ID: <87y1aog83s.fsf@bernoul.li> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19252"; mail-complaints-to="usenet@ciao.gmane.io" To: 69578@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 11 15:24:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjga9-0004jB-2Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Mar 2024 15:24:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjgZr-0007iP-7g; Mon, 11 Mar 2024 10:24:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjgZo-0007iB-Ex for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 10:24:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjgZo-0000HF-1L for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 10:24:28 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjgaL-0002zN-O9 for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 10:25:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Mar 2024 14:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69578 X-GNU-PR-Package: emacs Original-Received: via spool by 69578-submit@debbugs.gnu.org id=B69578.171016708111460 (code B ref 69578); Mon, 11 Mar 2024 14:25:01 +0000 Original-Received: (at 69578) by debbugs.gnu.org; 11 Mar 2024 14:24:41 +0000 Original-Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjga1-0002yl-3v for submit@debbugs.gnu.org; Mon, 11 Mar 2024 10:24:41 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:46144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjgZu-0002yT-Ce for 69578@debbugs.gnu.org; Mon, 11 Mar 2024 10:24:39 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DC54A16717 for <69578@debbugs.gnu.org>; Mon, 11 Mar 2024 15:23:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:from:from; s=sel2011a; t=1710167033; bh=WFYo2wg 2M2UQJC3xeGTArQcM08DO3dtY64uhzz97JFY=; b=f1axbMTZBONdsx7G0f0I0ga YQTk2ejkJ5Unsff3svSRGMlRtkqlkj2p+tY3HrLCjbJcQkTLBMJ8KsKVOTbpKKZp w5NAENx8fP8xuEL8tDKqk1GKBrXowEpSyv3HzyFY29Grj3K/5UAsG8BZy0jkC66L l522nL/Ek4QWsUF6Iexc= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id PlgdVt-AOYRh for <69578@debbugs.gnu.org>; Mon, 11 Mar 2024 15:23:53 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 984831652E for <69578@debbugs.gnu.org>; Mon, 11 Mar 2024 15:23:53 +0100 (CET) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281474 Archived-At: > The developers of Org mode took courage and replaced their C-TAB > bindings with C-c C-TAB: It indeed takes courage to change key bindings; there will always be a few users who get very upset by such a change. > These bindings stop taking effect if a mode has its own bindings for > control tab, for instance. A prominent example is Magit. I have addressed this in Magit as described in this commit message: magit-section-cycle: Pivot to tab-next if there is a binding conflict If `tab-bar-mode' is enable, then "C-" is bound to `tab-next' in the global map. That conflicts with our local (and much older) binding for `magit-section-cycle'. Address this conflict by teaching `magit-section-cycle' to pivot to `tab-next', but only if `tab-bar-mode' is enabled. That way, users who do not use `tab-bar-mode' (i.e., the majority), are not affected by this unfortunate conflict. `tab-bar-mode' users will have to get used to the much less convenient "C-c TAB" binding to cycle section visibility. Alternatively they can advice `tab-bar--define-keys' to bind another key to `tab-next'. It would be nice if `tab-bar-mode', instead of modifying the global map, used a mode map, and thus didn't make it so very hard to change its key bindings. > So, maybe these bindings should not be done? Too late for that now, but they should definitely be done in a way that users can customize, without having to advice tab-bar--define-keys (and tab-bar--undefine-keys). Maybe by using a mode map? If there is some reason this cannot be done, then maybe a "dummy keymap" could be used? (User could then manipulate the fake tab-bar-mode-map like any keymap, but the bindings it contains would then somehow be "transplanted" into the global map by tab-bar--define-keys.) >> Thanks, should we therefore close this bug? > > I'll close it in a second, thanks. This seems premature, making it so hard for users to change the tab-bar bindings seems like something that needs to be fixed.