From: Alcor via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 69920@debbugs.gnu.org
Subject: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines
Date: Fri, 22 Mar 2024 23:25:20 +0100 [thread overview]
Message-ID: <87y1a952gf.fsf@tilde.club> (raw)
In-Reply-To: <87wmpuouay.fsf@tilde.club> (alcor@tilde.club's message of "Fri, 22 Mar 2024 22:01:09 +0100")
Tags: patch
Add patch available mark to bug (forgot to do that in the previous
message).
git blame'ing the line in question on yields a decade-old
commit. Apparently, this used to be (insert "\n\n") … (delete-region b
(+ b 2)) about ~10 years ago, and the last relevant change turned that
into (insert "\n") … (delete-region b (1+ b)), but it seems lots of
other things on that codepath changed in the meantime.
FWIW, (insert-image … "x") (insert "\n") inserts two characters,
i.e. the image itself "x" and "\n", so it should either be (insert "\n")
… (delete-region b (+ 2 b)) or, alternatively just (delete-region b (1+
b)) (without any `insert' call).
next prev parent reply other threads:[~2024-03-22 22:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 17:59 bug#69920: 29.2; gnus: article-mode: Toggling MIME inline attachment previews adds superfluous newlines Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-22 21:01 ` bug#69920: Proposed fix - " Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-22 22:25 ` Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-03-23 6:59 ` Eli Zaretskii
2024-03-23 9:53 ` Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-23 10:20 ` Eli Zaretskii
2024-04-06 8:59 ` Eli Zaretskii
2024-04-18 9:00 ` Eli Zaretskii
2024-04-22 2:48 ` Eric Abrahamsen
2024-04-22 12:42 ` Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-22 14:58 ` bug#69920: 29.2; gnus: article-mode: " Eric Abrahamsen
2024-03-23 6:52 ` bug#69920: Proposed fix - " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1a952gf.fsf@tilde.club \
--to=bug-gnu-emacs@gnu.org \
--cc=69920@debbugs.gnu.org \
--cc=alcor@tilde.club \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.