all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: Call EXT-enable for `org-modules' (was Re: [PATCH] org-ctags.el: Do not activate on load)
Date: Wed, 01 May 2024 10:21:17 +0000	[thread overview]
Message-ID: <87y18teste.fsf@localhost> (raw)
In-Reply-To: <v0qk6b$12m4$1@ciao.gmane.io>

Max Nikulin <manikulin@gmail.com> writes:

>> Applied, onto main.
>
> I was expecting that you would be against it since it is a breaking change.
>
> See a follow-up to
> Ihor Radchenko. Re: Autoloading side effects
> (was: Re: [BUG] org-mouse is activated without explicit require)
> Mon, 12 Dec 2022 10:25:16 +0000
> <https://list.orgmode.org/871qp4j4vn.fsf@localhost>

Not against. The side effects in org-ctags are _disruptive_. And Bastien
agreed that we can go ahead with breaking change in this case.

Later in the thread we deviated to discussing what exactly constitutes a
harmful side effect and what is acceptable, but that's a more general
discussion. org-ctags is clearly too aggressive.

> However now I am in doubts why org-ctags is not a minor mode.

What would be the benefit?

>  ** Miscellaneous
> +*** ~feature-enable~ functions are called for extensions from ~org-modules~
> +
> +Accordingly to Emacs [[info:elisp#Coding Conventions][coding conventions]]
> +loading a library must not modify behavior
> +since it may be done for the sake of help or command completion.
> +To make user configuration more convenient, when an extension ~EXT~ listed
> +in ~org-modules~ implements ~EXT-enable~ function, it is executed
> +during loading of Org mode or in response to customization of ~org-modules~.
> +So instead of ~(require 'EXT)~ in your init file add ~EXT~ to ~org-modules~.
> +See also
> +[[*~org-ctags~ is not activated by default any more][~org-ctags~ is not activated by default any more]].

I'd like to discuss this idea with enable-feature on emacs-devel first.
Maybe we can adapt it more widely without special handling for
org-modules.

See
https://yhetil.org/emacs-devel/87zft9esva.fsf@localhost/
[FR] Provide a way to activate packages automatically for side effect

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-05-01 10:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 23:57 [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)] Martin Marshall
2024-02-10  4:49 ` Is there something people use instead of org-ctags? (was: [PATCH] `org-ctags-create-tags` creates empty TAGS file) Martin Marshall
2024-02-10 14:29   ` Ihor Radchenko
2024-02-10 14:27 ` [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)] Ihor Radchenko
2024-02-10 21:10   ` Morgan Willcock
2024-02-10 21:20     ` Ihor Radchenko
2024-03-19 10:21     ` Max Nikulin
2024-03-20 12:08       ` Ihor Radchenko
2024-04-28  7:37         ` [PATCH] org-ctags.el: Protect shell specials in directory name Max Nikulin
2024-04-28 12:53           ` Ihor Radchenko
2024-04-28 16:51             ` Max Nikulin
2024-04-28 16:55               ` Ihor Radchenko
2024-04-28 16:58                 ` Max Nikulin
2024-04-28 17:02                   ` Ihor Radchenko
2024-04-29 10:26                     ` Max Nikulin
2024-04-29 13:12                       ` Ihor Radchenko
2024-04-29 16:54                         ` [PATCH] org-ctags.el: Do not activate on load Max Nikulin
2024-04-30 10:02                           ` Ihor Radchenko
2024-04-30 11:20                             ` [PATCH] org.el: Call EXT-enable for `org-modules' (was Re: [PATCH] org-ctags.el: Do not activate on load) Max Nikulin
2024-05-01 10:21                               ` Ihor Radchenko [this message]
2024-05-01 11:38                                 ` Max Nikulin
2024-05-01 13:57                                   ` Ihor Radchenko
2024-04-30 12:59                             ` [PATCH] org-ctags.el: Do not activate on load Ihor Radchenko
2024-04-30 13:37                               ` Max Nikulin
2024-04-30 15:31                                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y18teste.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.